From b26174f4203eea64d9a8f6870a5251b7284630f3 Mon Sep 17 00:00:00 2001
From: ben <me@benjamyn.love>
Date: Mon, 9 Oct 2023 07:29:02 -0400
Subject: [PATCH] Use request validation

---
 app/Http/Controllers/Api/UserController.php | 18 ++----------
 app/Http/Requests/StoreUserRequest.php      | 32 +++++++++++++++++++++
 2 files changed, 35 insertions(+), 15 deletions(-)
 create mode 100644 app/Http/Requests/StoreUserRequest.php

diff --git a/app/Http/Controllers/Api/UserController.php b/app/Http/Controllers/Api/UserController.php
index 7cea24d..933bd91 100644
--- a/app/Http/Controllers/Api/UserController.php
+++ b/app/Http/Controllers/Api/UserController.php
@@ -5,27 +5,15 @@ namespace App\Http\Controllers\Api;
 use App\Http\Controllers\Controller;
 use App\Models\User;
 use Illuminate\Support\Str;
-use Illuminate\Http\Request;
+use App\Http\Requests\StoreUserRequest;
 use Illuminate\Support\Facades\Validator;
 
 class UserController extends Controller
 {
-    public function registerUser(Request $request)
+    public function registerUser(StoreUserRequest $request)
     {
-        $validator = Validator::make($request->all(), [
-            'firstname' => ['required', 'string'],
-            'lastname' => ['required', 'string'],
-            'email' => ['required', 'string'],
-            'uuid' => ['required', 'string'],
-            'profile' => ['required', 'string'],
-        ]);
-        if ($validator->fails()) {
 
-            return response()
-                    ->json($validator->errors());
-        }
-
-        $validated = $validator->validated();
+        $validated = $request->validated();
         $validated['is_admin'] = false;
         $validated['password'] = Str::random(8);
         $validated['status'] = true;
diff --git a/app/Http/Requests/StoreUserRequest.php b/app/Http/Requests/StoreUserRequest.php
new file mode 100644
index 0000000..032a152
--- /dev/null
+++ b/app/Http/Requests/StoreUserRequest.php
@@ -0,0 +1,32 @@
+<?php
+
+namespace App\Http\Requests;
+
+use Illuminate\Foundation\Http\FormRequest;
+
+class StoreUserRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     */
+    public function authorize(): bool
+    {
+        return true;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array<string, \Illuminate\Contracts\Validation\ValidationRule|array<mixed>|string>
+     */
+    public function rules(): array
+    {
+        return [
+            'firstname' => ['required', 'string'],
+            'lastname' => ['required', 'string'],
+            'email' => ['required', 'string'],
+            'uuid' => ['required', 'string'],
+            'profile' => ['required', 'string'],
+        ];
+    }
+}