fix/headerauth-crash-missing-header #19

						
				@ -15,6 +15,10 @@ class HeaderAuth

				     */

				    public function handle(Request $request, Closure $next): Response

				    {

				        if (is_null($request->header('X-BOTAUTH'))) {

llama commented

2023-10-10 01:15:31 -04:00

If do empty here instead of is_null

if (empty($request->header('X-BOTAUTH'))) {

If do empty here instead of is_null ``` if (empty($request->header('X-BOTAUTH'))) { ```

benjamyn added 2 commits 2023-10-10 01:35:57 -04:00

Merge branch 'feat/user-reg-api' into fix/headerauth-crash-missing-header 8519764f8f

empty instead of is_null 7a8b0fdf10

kdonaldson requested changes 2023-10-10 01:56:36 -04:00

app/Http/Middleware/HeaderAuth.php Outdated

						
				@ -15,6 +15,10 @@ class HeaderAuth

				     */

				    public function handle(Request $request, Closure $next): Response

				    {

				        if (empty($request->header('X-BOTAUTH'))) {

kdonaldson commented

2023-10-10 01:56:34 -04:00

->hasHeader(...) also works instead of having to do the empty check.

Alternatively you can do this:

$header = $request->header('X-BotAuth'); // Returns null when no value is found by default

if (! $header) {
    // return failure response
}

if (! hash_equals(config('bot.header_auth'), $header)) {
    // return failure response
}

return $next($request);

->header(...) has a second parameter that can be specified as a default value when header is not present.
Most of the time in Laravel when there's a "get" kind of function like this there's a secondary "default" parameter that defaults to null you can use, for example config(...), Arr::get(...), etc.

`->hasHeader(...)` also works instead of having to do the empty check. Alternatively you can do this: ```php $header = $request->header('X-BotAuth'); // Returns null when no value is found by default if (! $header) { // return failure response } if (! hash_equals(config('bot.header_auth'), $header)) { // return failure response } return $next($request); ``` `->header(...)` has a second parameter that can be specified as a default value when header is not present. Most of the time in Laravel when there's a "get" kind of function like this there's a secondary "default" parameter that defaults to null you can use, for example config(...), Arr::get(...), etc.