Fixed reflected XSS described in issue 1265
This commit is contained in:
1 parent
ae1b12c120
commit
d2174725a9
3 files changed
+7
-3
No files matched your search
@@ -87,7 +87,7 @@ class ScatterChart extends Operation {
|
||||
const recordDelimiter = Utils.charRep(args[0]),
|
||||
fieldDelimiter = Utils.charRep(args[1]),
|
||||
columnHeadingsAreIncluded = args[2],
|
||||
fillColour = args[5],
|
||||
fillColour = Utils.escapeHtml(args[5]),
|
||||
radius = args[6],
|
||||
colourInInput = args[7],
|
||||
dimension = 500;
|
||||
|
||||
@@ -72,7 +72,10 @@ class SeriesChart extends Operation {
|
||||
fieldDelimiter = Utils.charRep(args[1]),
|
||||
xLabel = args[2],
|
||||
pipRadius = args[3],
|
||||
seriesColours = args[4].split(","),
|
||||
// Escape HTML from all colours to prevent reflected XSS. See https://github.com/gchq/CyberChef/issues/1265
|
||||
seriesColours = args[4].split(",").map((colour) => {
|
||||
return Utils.escapeHtml(colour)
|
||||
}),
|
||||
svgWidth = 500,
|
||||
interSeriesPadding = 20,
|
||||
xAxisHeight = 50,
|
||||
|
||||
Reference in new issue
Block a user