Update tests

client/storage/liststorage_test.go

@@ -43,6 +43,17 @@ func TestListStorage(t *testing.T) {
 		return nil
 	})
 
+	t.Run("create same storage returns no error", func(t *testing.T) {
+		fx.db.View(func(txn *badger.Txn) error {
+			// this is ok, because we only create new list storage when we create space storage
+			listStore, err := createListStorage(spaceId, fx.db, txn, aclRoot)
+			require.NoError(t, err)
+			testListInDB(t, listStore, aclRoot, aclRoot.Id)
+
+			return nil
+		})
+	})
+
 	t.Run("set head", func(t *testing.T) {
 		head := "newHead"
 		require.NoError(t, listStore.SetHead(head))

client/storage/spacestorage_test.go

@@ -42,11 +42,14 @@ func TestSpaceStorage_Create(t *testing.T) {
 	payload := spaceTestPayload()
 	store, err := createSpaceStorage(fx.db, payload)
 	require.NoError(t, err)
-	defer func() {
-		require.NoError(t, store.Close())
-	}()
 
 	testSpaceInDB(t, store, payload)
+	require.NoError(t, store.Close())
+
+	t.Run("create same storage returns error", func(t *testing.T) {
+		_, err := createSpaceStorage(fx.db, payload)
+		require.Error(t, err)
+	})
 }
 
 func TestSpaceStorage_NewAndCreateTree(t *testing.T) {
@@ -103,4 +106,3 @@ func TestSpaceStorage_StoredIds(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, ids, storedIds)
 }
-

client/storage/treestorage_test.go

@@ -71,6 +71,11 @@ func TestTreeStorage_Create(t *testing.T) {
 	store, err := createTreeStorage(fx.db, spaceId, payload)
 	require.NoError(t, err)
 	testTreePayloadInDB(t, store, payload)
+
+	t.Run("create same storage returns error", func(t *testing.T) {
+		_, err := createTreeStorage(fx.db, spaceId, payload)
+		require.Error(t, err)
+	})
 }
 
 func TestTreeStorage_Methods(t *testing.T) {

node/storage/liststorage_test.go

@@ -29,6 +29,13 @@ func TestListStorage_Create(t *testing.T) {
 	listStore, err := createListStorage(fx.db, aclRoot)
 	require.NoError(t, err)
 	testListInDB(t, listStore, aclRoot, aclRoot.Id)
+
+	t.Run("create same list storage returns nil", func(t *testing.T) {
+		// this is ok, because we only create new list storage when we create space storage
+		listStore, err := createListStorage(fx.db, aclRoot)
+		require.NoError(t, err)
+		testListInDB(t, listStore, aclRoot, aclRoot.Id)
+	})
 }
 
 func TestListStorage_Methods(t *testing.T) {

node/storage/spacestorage_test.go

@@ -42,11 +42,14 @@ func TestSpaceStorage_Create(t *testing.T) {
 	payload := spaceTestPayload()
 	store, err := createSpaceStorage(dir, payload)
 	require.NoError(t, err)
-	defer func() {
-		require.NoError(t, store.Close())
-	}()
 
 	testSpaceInDB(t, store, payload)
+	require.NoError(t, store.Close())
+
+	t.Run("create same storage returns error", func(t *testing.T) {
+		_, err := createSpaceStorage(dir, payload)
+		require.Error(t, err)
+	})
 }
 
 func TestSpaceStorage_NewAndCreateTree(t *testing.T) {

node/storage/treestorage_test.go

@@ -70,6 +70,11 @@ func TestTreeStorage_Create(t *testing.T) {
 	store, err := createTreeStorage(fx.db, payload)
 	require.NoError(t, err)
 	testTreePayloadInDB(t, store, payload)
+
+	t.Run("create same storage returns error", func(t *testing.T) {
+		_, err := createTreeStorage(fx.db, payload)
+		require.Error(t, err)
+	})
 }
 
 func TestTreeStorage_Methods(t *testing.T) {