PriceyBot/PriceyBotPanel
Archived
5
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects 1 Releases 4 Wiki Activity

feat/admin-send-quote #15

Merged
llama merged 5 commits from feat/admin-send-quote into master 2023-10-09 05:09:57 -04:00
Conversation 5 Commits 5 Files Changed 4 +21 -4
benjamyn commented 2023-10-09 04:49:49 -04:00
Owner
Copy Link

pls review @llama

pls review @llama
benjamyn added 3 commits 2023-10-09 04:49:50 -04:00 
will make pretty later
llama requested changes 2023-10-09 04:58:54 -04:00
routes/web.php Outdated
@ -25,6 +25,10 @@ Route::view('profile', 'profile')
->middleware(['auth'])
->name('profile');
Route::view('send', 'send')
llama commented 2023-10-09 04:58:30 -04:00
Owner

can we prefix send with admin/

once we start getting more admin tools, it'll get mess but the rest looks good to me :D

can we prefix send with admin/ once we start getting more admin tools, it'll get mess but the rest looks good to me :D
benjamyn added 1 commit 2023-10-09 05:04:00 -04:00
benjamyn commented 2023-10-09 05:04:16 -04:00
Author
Owner
Copy Link

Feeeexed

Feeeexed
llama reviewed 2023-10-09 05:05:36 -04:00
resources/views/components/sidebar.blade.php Outdated
@ -36,3 +36,3 @@
<li>
{{-- TODO: fill with SVG icons to make it pretty --}}
{{-- <x-sidebar-nav :href="route('a-1')" route="a-1">First Page</x-sidebar-nav>--}}
<x-sidebar-nav :href="route('send')" route="send">Send Quote</x-sidebar-nav>
llama commented 2023-10-09 05:05:36 -04:00
Owner

I think this also needs to be /admin/send

I think this also needs to be /admin/send
benjamyn marked this conversation as resolved
llama requested changes 2023-10-09 05:06:22 -04:00
routes/web.php
@ -25,6 +25,10 @@ Route::view('profile', 'profile')
->middleware(['auth'])
->name('profile');
Route::view('send', 'admin.send')
llama commented 2023-10-09 05:06:19 -04:00
Owner

Route::view('admin/send', 'admin.send')

will be better I think

Route::view('admin/send', 'admin.send') will be better I think
benjamyn added 1 commit 2023-10-09 05:09:01 -04:00
llama approved these changes 2023-10-09 05:09:26 -04:00
llama merged commit 6ec3ba9f23 into master 2023-10-09 05:09:57 -04:00
benjamyn deleted branch feat/admin-send-quote 2023-10-09 05:34:35 -04:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
llama
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agoodlet balgie benjamyn kdonaldson llama
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: PriceyBot/PriceyBotPanel#15
No description provided.
Delete Branch "feat/admin-send-quote"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?