net test

Makefile

@@ -20,7 +20,6 @@ proto:
 	protoc --gogofaster_out=$(PKGMAP):. --go-drpc_out=protolib=github.com/gogo/protobuf:. net/streampool/testservice/protos/*.proto
 	protoc --gogofaster_out=:. net/secureservice/handshake/handshakeproto/protos/*.proto
 	protoc --gogofaster_out=$(PKGMAP):. --go-drpc_out=protolib=github.com/gogo/protobuf:. coordinator/coordinatorproto/protos/*.proto
-	protoc --gogofaster_out=:. --go-drpc_out=protolib=github.com/gogo/protobuf:. consensus/consensusproto/protos/*.proto
 
 deps:
 	go mod download

accountservice/mock_accountservice/helper.go

@@ -3,7 +3,7 @@ package mock_accountservice
 import (
 	"github.com/anyproto/any-sync/accountservice"
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
-	"go.uber.org/mock/gomock"
+	"github.com/golang/mock/gomock"
 )
 
 func NewAccountServiceWithAccount(ctrl *gomock.Controller, acc *accountdata.AccountKeys) *MockService {

accountservice/mock_accountservice/mock_accountservice.go

@@ -9,7 +9,7 @@ import (
 
 	app "github.com/anyproto/any-sync/app"
 	accountdata "github.com/anyproto/any-sync/commonspace/object/accountdata"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockService is a mock of Service interface.

app/app.go

@@ -61,7 +61,6 @@ type App struct {
 	startStat      Stat
 	stopStat       Stat
 	deviceState    int
-	versionName    string
 	anySyncVersion string
 }
 
@@ -79,19 +78,6 @@ func (app *App) Version() string {
 	return GitSummary
 }
 
-// SetVersionName sets the custom application version
-func (app *App) SetVersionName(v string) {
-	app.versionName = v
-}
-
-// VersionName returns a string with the settled app version or auto-generated version if it didn't set
-func (app *App) VersionName() string {
-	if app.versionName != "" {
-		return app.versionName
-	}
-	return AppName + ":" + GitSummary + "/any-sync:" + app.AnySyncVersion()
-}
-
 type Stat struct {
 	SpentMsPerComp map[string]int64
 	SpentMsTotal   int64
@@ -262,15 +248,6 @@ func (app *App) Start(ctx context.Context) (err error) {
 	return
 }
 
-// IterateComponents iterates over all registered components. It's safe for concurrent use.
-func (app *App) IterateComponents(fn func(Component)) {
-	app.mu.RLock()
-	defer app.mu.RUnlock()
-	for _, s := range app.components {
-		fn(s)
-	}
-}
-
 func stackAllGoroutines() []byte {
 	buf := make([]byte, 1024)
 	for {

app/app_test.go

@@ -55,21 +55,6 @@ func TestAppServiceRegistry(t *testing.T) {
 	})
 }
 
-func TestApp_IterateComponents(t *testing.T) {
-	app := new(App)
-
-	app.Register(newTestService(testTypeRunnable, "c1", nil, nil))
-	app.Register(newTestService(testTypeRunnable, "r1", nil, nil))
-	app.Register(newTestService(testTypeComponent, "s1", nil, nil))
-
-	var got []string
-	app.IterateComponents(func(s Component) {
-		got = append(got, s.Name())
-	})
-
-	assert.ElementsMatch(t, []string{"c1", "r1", "s1"}, got)
-}
-
 func TestAppStart(t *testing.T) {
 	t.Run("SuccessStartStop", func(t *testing.T) {
 		app := new(App)

app/ldiff/mock_ldiff/mock_ldiff.go

@@ -9,7 +9,7 @@ import (
 	reflect "reflect"
 
 	ldiff "github.com/anyproto/any-sync/app/ldiff"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockDiff is a mock of Diff interface.

app/ocache/entry.go

@@ -2,10 +2,9 @@ package ocache
 
 import (
 	"context"
+	"go.uber.org/zap"
 	"sync"
 	"time"
-
-	"go.uber.org/zap"
 )
 
 type entryState int
@@ -26,7 +25,6 @@ type entry struct {
 	value     Object
 	close     chan struct{}
 	mx        sync.Mutex
-	cancel    context.CancelFunc
 }
 
 func newEntry(id string, value Object, state entryState) *entry {
@@ -51,20 +49,6 @@ func (e *entry) isClosing() bool {
 	return e.state == entryStateClosed || e.state == entryStateClosing
 }
 
-func (e *entry) setCancel(cancel context.CancelFunc) {
-	e.mx.Lock()
-	defer e.mx.Unlock()
-	e.cancel = cancel
-}
-
-func (e *entry) cancelLoad() {
-	e.mx.Lock()
-	defer e.mx.Unlock()
-	if e.cancel != nil {
-		e.cancel()
-	}
-}
-
 func (e *entry) waitLoad(ctx context.Context, id string) (value Object, err error) {
 	select {
 	case <-ctx.Done():

app/ocache/ocache.go

@@ -3,11 +3,10 @@ package ocache
 import (
 	"context"
 	"errors"
-	"sync"
-	"time"
-
 	"github.com/anyproto/any-sync/app/logger"
 	"go.uber.org/zap"
+	"sync"
+	"time"
 )
 
 var (
@@ -158,10 +157,7 @@ func (c *oCache) Pick(ctx context.Context, id string) (value Object, err error)
 
 func (c *oCache) load(ctx context.Context, id string, e *entry) {
 	defer close(e.load)
-	ctx, cancel := context.WithCancel(ctx)
-	e.setCancel(cancel)
 	value, err := c.loadFunc(ctx, id)
-	cancel()
 
 	c.mu.Lock()
 	defer c.mu.Unlock()
@@ -319,7 +315,6 @@ func (c *oCache) Close() (err error) {
 	close(c.closeCh)
 	var toClose []*entry
 	for _, e := range c.data {
-		e.cancelLoad()
 		toClose = append(toClose, e)
 	}
 	c.mu.Unlock()

app/ocache/ocache_test.go

@@ -386,25 +386,6 @@ func Test_OCache_Remove(t *testing.T) {
 	})
 }
 
-func TestOCacheCancelWhenRemove(t *testing.T) {
-	c := New(func(ctx context.Context, id string) (value Object, err error) {
-		select {
-		case <-ctx.Done():
-			return nil, ctx.Err()
-		}
-	}, WithTTL(time.Millisecond*10))
-	stopLoad := make(chan struct{})
-	var err error
-	go func() {
-		_, err = c.Get(context.TODO(), "id")
-		stopLoad <- struct{}{}
-	}()
-	time.Sleep(time.Millisecond * 10)
-	c.Close()
-	<-stopLoad
-	require.Equal(t, context.Canceled, err)
-}
-
 func TestOCacheFuzzy(t *testing.T) {
 	t.Run("test many objects gc, get and remove simultaneously, close after", func(t *testing.T) {
 		tryCloseIds := make(map[string]bool)

commonspace/credentialprovider/mock_credentialprovider/mock_credentialprovider.go

@@ -10,7 +10,7 @@ import (
 
 	app "github.com/anyproto/any-sync/app"
 	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockCredentialProvider is a mock of CredentialProvider interface.

commonspace/deletionstate/deletionstate_test.go

@@ -3,8 +3,8 @@ package deletionstate
 import (
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/commonspace/spacestorage/mock_spacestorage"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"sort"
 	"testing"
 )

commonspace/deletionstate/mock_deletionstate/mock_deletionstate.go

@@ -9,7 +9,7 @@ import (
 
 	app "github.com/anyproto/any-sync/app"
 	deletionstate "github.com/anyproto/any-sync/commonspace/deletionstate"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockObjectDeletionState is a mock of ObjectDeletionState interface.

commonspace/headsync/diffsyncer.go

@@ -3,13 +3,10 @@ package headsync
 import (
 	"context"
 	"fmt"
-	"time"
-
 	"github.com/anyproto/any-sync/app/ldiff"
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/credentialprovider"
 	"github.com/anyproto/any-sync/commonspace/deletionstate"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl"
 	"github.com/anyproto/any-sync/commonspace/object/treemanager"
 	"github.com/anyproto/any-sync/commonspace/peermanager"
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
@@ -17,8 +14,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
 	"github.com/anyproto/any-sync/net/peer"
 	"github.com/anyproto/any-sync/net/rpc/rpcerr"
-	"github.com/anyproto/any-sync/util/slice"
 	"go.uber.org/zap"
+	"time"
 )
 
 type DiffSyncer interface {
@@ -41,7 +38,6 @@ func newDiffSyncer(hs *headSync) DiffSyncer {
 		log:                log,
 		syncStatus:         hs.syncStatus,
 		deletionState:      hs.deletionState,
-		syncAcl:            hs.syncAcl,
 	}
 }
 
@@ -57,7 +53,6 @@ type diffSyncer struct {
 	credentialProvider credentialprovider.CredentialProvider
 	syncStatus         syncstatus.StatusUpdater
 	treeSyncer         treemanager.TreeSyncer
-	syncAcl            syncacl.SyncAcl
 }
 
 func (d *diffSyncer) Init() {
@@ -121,7 +116,6 @@ func (d *diffSyncer) syncWithPeer(ctx context.Context, p peer.Peer) (err error)
 		cl           = d.clientFactory.Client(conn)
 		rdiff        = NewRemoteDiff(d.spaceId, cl)
 		stateCounter = d.syncStatus.StateCounter()
-		syncAclId    = d.syncAcl.Id()
 	)
 
 	newIds, changedIds, removedIds, err := d.diff.Diff(ctx, rdiff)
@@ -144,29 +138,17 @@ func (d *diffSyncer) syncWithPeer(ctx context.Context, p peer.Peer) (err error)
 	// not syncing ids which were removed through settings document
 	missingIds := d.deletionState.Filter(newIds)
 	existingIds := append(d.deletionState.Filter(removedIds), d.deletionState.Filter(changedIds)...)
+
 	d.syncStatus.RemoveAllExcept(p.Id(), existingIds, stateCounter)
 
-	prevExistingLen := len(existingIds)
-	existingIds = slice.DiscardFromSlice(existingIds, func(s string) bool {
-		return s == syncAclId
-	})
-	// if we removed acl head from the list
-	if len(existingIds) < prevExistingLen {
-		if syncErr := d.syncAcl.SyncWithPeer(ctx, p.Id()); syncErr != nil {
-			log.Warn("failed to send acl sync message to peer", zap.String("aclId", syncAclId))
-		}
-	}
-
-	// treeSyncer should not get acl id, that's why we filter existing ids before
 	err = d.treeSyncer.SyncAll(ctx, p.Id(), existingIds, missingIds)
 	if err != nil {
 		return err
 	}
-	d.log.Info("sync done:",
-		zap.Int("newIds", len(newIds)),
+	d.log.Info("sync done:", zap.Int("newIds", len(newIds)),
 		zap.Int("changedIds", len(changedIds)),
 		zap.Int("removedIds", len(removedIds)),
-		zap.Int("already deleted ids", totalLen-prevExistingLen-len(missingIds)),
+		zap.Int("already deleted ids", totalLen-len(existingIds)-len(missingIds)),
 		zap.String("peerId", p.Id()),
 	)
 	return

commonspace/headsync/diffsyncer_test.go

@@ -4,19 +4,18 @@ import (
 	"bytes"
 	"context"
 	"fmt"
-	"testing"
-	"time"
-
 	"github.com/anyproto/any-sync/app/ldiff"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/liststorage/mock_liststorage"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage/mock_treestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/net/peer"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"storj.io/drpc"
+	"testing"
+	"time"
 )
 
 type pushSpaceRequestMatcher struct {
@@ -109,7 +108,6 @@ func TestDiffSyncer(t *testing.T) {
 		fx.initDiffSyncer(t)
 		defer fx.stop()
 		mPeer := mockPeer{}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
 		fx.peerManagerMock.EXPECT().
 			GetResponsiblePeers(gomock.Any()).
 			Return([]peer.Peer{mPeer}, nil)
@@ -123,26 +121,6 @@ func TestDiffSyncer(t *testing.T) {
 		require.NoError(t, fx.diffSyncer.Sync(ctx))
 	})
 
-	t.Run("diff syncer sync, acl changed", func(t *testing.T) {
-		fx := newHeadSyncFixture(t)
-		fx.initDiffSyncer(t)
-		defer fx.stop()
-		mPeer := mockPeer{}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
-		fx.peerManagerMock.EXPECT().
-			GetResponsiblePeers(gomock.Any()).
-			Return([]peer.Peer{mPeer}, nil)
-		fx.diffMock.EXPECT().
-			Diff(gomock.Any(), gomock.Eq(NewRemoteDiff(fx.spaceState.SpaceId, fx.clientMock))).
-			Return([]string{"new"}, []string{"changed"}, nil, nil)
-		fx.deletionStateMock.EXPECT().Filter([]string{"new"}).Return([]string{"new"}).Times(1)
-		fx.deletionStateMock.EXPECT().Filter([]string{"changed"}).Return([]string{"changed", "aclId"}).Times(1)
-		fx.deletionStateMock.EXPECT().Filter(nil).Return(nil).Times(1)
-		fx.treeSyncerMock.EXPECT().SyncAll(gomock.Any(), mPeer.Id(), []string{"changed"}, []string{"new"}).Return(nil)
-		fx.aclMock.EXPECT().SyncWithPeer(gomock.Any(), mPeer.Id()).Return(nil)
-		require.NoError(t, fx.diffSyncer.Sync(ctx))
-	})
-
 	t.Run("diff syncer sync conf error", func(t *testing.T) {
 		fx := newHeadSyncFixture(t)
 		fx.initDiffSyncer(t)
@@ -160,7 +138,6 @@ func TestDiffSyncer(t *testing.T) {
 		fx.initDiffSyncer(t)
 		defer fx.stop()
 		deletedId := "id"
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
 		fx.deletionStateMock.EXPECT().Exists(deletedId).Return(true)
 
 		// this should not result in any mock being called
@@ -174,7 +151,6 @@ func TestDiffSyncer(t *testing.T) {
 		newId := "newId"
 		newHeads := []string{"h1", "h2"}
 		hash := "hash"
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
 		fx.diffMock.EXPECT().Set(ldiff.Element{
 			Id:   newId,
 			Head: concatStrings(newHeads),
@@ -189,12 +165,11 @@ func TestDiffSyncer(t *testing.T) {
 		fx := newHeadSyncFixture(t)
 		fx.initDiffSyncer(t)
 		defer fx.stop()
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
 		aclStorageMock := mock_liststorage.NewMockListStorage(fx.ctrl)
 		settingsStorage := mock_treestorage.NewMockTreeStorage(fx.ctrl)
 		settingsId := "settingsId"
 		aclRootId := "aclRootId"
-		aclRoot := &consensusproto.RawRecordWithId{
+		aclRoot := &aclrecordproto.RawAclRecordWithId{
 			Id: aclRootId,
 		}
 		settingsRoot := &treechangeproto.RawTreeChangeWithId{
@@ -235,7 +210,6 @@ func TestDiffSyncer(t *testing.T) {
 		fx := newHeadSyncFixture(t)
 		fx.initDiffSyncer(t)
 		defer fx.stop()
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
 		fx.peerManagerMock.EXPECT().
 			GetResponsiblePeers(gomock.Any()).
 			Return([]peer.Peer{mockPeer{}}, nil)
@@ -251,7 +225,6 @@ func TestDiffSyncer(t *testing.T) {
 		fx.initDiffSyncer(t)
 		defer fx.stop()
 		mPeer := mockPeer{}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
 		fx.peerManagerMock.EXPECT().
 			GetResponsiblePeers(gomock.Any()).
 			Return([]peer.Peer{mPeer}, nil)

commonspace/headsync/headsync.go

@@ -3,16 +3,12 @@ package headsync
 
 import (
 	"context"
-	"sync/atomic"
-	"time"
-
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/app/ldiff"
 	"github.com/anyproto/any-sync/app/logger"
 	config2 "github.com/anyproto/any-sync/commonspace/config"
 	"github.com/anyproto/any-sync/commonspace/credentialprovider"
 	"github.com/anyproto/any-sync/commonspace/deletionstate"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl"
 	"github.com/anyproto/any-sync/commonspace/object/treemanager"
 	"github.com/anyproto/any-sync/commonspace/peermanager"
 	"github.com/anyproto/any-sync/commonspace/spacestate"
@@ -25,6 +21,8 @@ import (
 	"github.com/anyproto/any-sync/util/slice"
 	"go.uber.org/zap"
 	"golang.org/x/exp/slices"
+	"sync/atomic"
+	"time"
 )
 
 var log = logger.NewNamed(CName)
@@ -62,7 +60,6 @@ type headSync struct {
 	credentialProvider credentialprovider.CredentialProvider
 	syncStatus         syncstatus.StatusService
 	deletionState      deletionstate.ObjectDeletionState
-	syncAcl            syncacl.SyncAcl
 }
 
 func New() HeadSync {
@@ -74,7 +71,6 @@ var createDiffSyncer = newDiffSyncer
 func (h *headSync) Init(a *app.App) (err error) {
 	shared := a.MustComponent(spacestate.CName).(*spacestate.SpaceState)
 	cfg := a.MustComponent("config").(config2.ConfigGetter)
-	h.syncAcl = a.MustComponent(syncacl.CName).(syncacl.SyncAcl)
 	h.spaceId = shared.SpaceId
 	h.spaceIsDeleted = shared.SpaceIsDeleted
 	h.syncPeriod = cfg.GetSpace().SyncPeriod
@@ -96,7 +92,6 @@ func (h *headSync) Init(a *app.App) (err error) {
 		return h.syncer.Sync(ctx)
 	}
 	h.periodicSync = periodicsync.NewPeriodicSync(h.syncPeriod, time.Minute, sync, h.log)
-	h.syncAcl.SetHeadUpdater(h)
 	// TODO: move to run?
 	h.syncer.Init()
 	return nil
@@ -182,10 +177,6 @@ func (h *headSync) fillDiff(objectIds []string) {
 			Head: concatStrings(heads),
 		})
 	}
-	els = append(els, ldiff.Element{
-		Id:   h.syncAcl.Id(),
-		Head: h.syncAcl.Head().Id,
-	})
 	h.diff.Set(els...)
 	if err := h.storage.WriteSpaceHash(h.diff.Hash()); err != nil {
 		h.log.Error("can't write space hash", zap.Error(err))

commonspace/headsync/headsync_test.go

@@ -11,9 +11,6 @@ import (
 	"github.com/anyproto/any-sync/commonspace/deletionstate"
 	"github.com/anyproto/any-sync/commonspace/deletionstate/mock_deletionstate"
 	"github.com/anyproto/any-sync/commonspace/headsync/mock_headsync"
-	"github.com/anyproto/any-sync/commonspace/object/acl/list"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl/mock_syncacl"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage/mock_treestorage"
 	"github.com/anyproto/any-sync/commonspace/object/treemanager"
 	"github.com/anyproto/any-sync/commonspace/object/treemanager/mock_treemanager"
@@ -26,8 +23,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
 	"github.com/anyproto/any-sync/nodeconf"
 	"github.com/anyproto/any-sync/nodeconf/mock_nodeconf"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"sync/atomic"
 	"testing"
 )
@@ -63,7 +60,6 @@ type headSyncFixture struct {
 	treeSyncerMock         *mock_treemanager.MockTreeSyncer
 	diffMock               *mock_ldiff.MockDiff
 	clientMock             *mock_spacesyncproto.MockDRPCSpaceSyncClient
-	aclMock                *mock_syncacl.MockSyncAcl
 	headSync               *headSync
 	diffSyncer             *diffSyncer
 }
@@ -91,13 +87,9 @@ func newHeadSyncFixture(t *testing.T) *headSyncFixture {
 	treeSyncerMock := mock_treemanager.NewMockTreeSyncer(ctrl)
 	diffMock := mock_ldiff.NewMockDiff(ctrl)
 	clientMock := mock_spacesyncproto.NewMockDRPCSpaceSyncClient(ctrl)
-	aclMock := mock_syncacl.NewMockSyncAcl(ctrl)
-	aclMock.EXPECT().Name().AnyTimes().Return(syncacl.CName)
-	aclMock.EXPECT().SetHeadUpdater(gomock.Any()).AnyTimes()
 	hs := &headSync{}
 	a := &app.App{}
 	a.Register(spaceState).
-		Register(aclMock).
 		Register(mockConfig{}).
 		Register(configurationMock).
 		Register(storageMock).
@@ -123,7 +115,6 @@ func newHeadSyncFixture(t *testing.T) *headSyncFixture {
 		treeSyncerMock:         treeSyncerMock,
 		diffMock:               diffMock,
 		clientMock:             clientMock,
-		aclMock:                aclMock,
 	}
 }
 
@@ -153,8 +144,6 @@ func TestHeadSync(t *testing.T) {
 		treeMock := mock_treestorage.NewMockTreeStorage(fx.ctrl)
 		fx.storageMock.EXPECT().StoredIds().Return(ids, nil)
 		fx.storageMock.EXPECT().TreeStorage(ids[0]).Return(treeMock, nil)
-		fx.aclMock.EXPECT().Id().AnyTimes().Return("aclId")
-		fx.aclMock.EXPECT().Head().AnyTimes().Return(&list.AclRecord{Id: "headId"})
 		treeMock.EXPECT().Heads().Return([]string{"h1", "h2"}, nil)
 		fx.diffMock.EXPECT().Set(ldiff.Element{
 			Id:   "id1",

commonspace/headsync/mock_headsync/mock_headsync.go

@@ -8,7 +8,7 @@ import (
 	context "context"
 	reflect "reflect"
 
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockDiffSyncer is a mock of DiffSyncer interface.

commonspace/object/acl/aclrecordproto/protos/aclrecord.proto

@@ -2,7 +2,26 @@ syntax = "proto3";
 package aclrecord;
 option go_package = "commonspace/object/acl/aclrecordproto";
 
-// AclRoot is a root of access control list
+message RawAclRecord {
+    bytes payload = 1;
+    bytes signature = 2;
+    bytes acceptorIdentity = 3;
+    bytes acceptorSignature = 4;
+}
+
+message RawAclRecordWithId {
+    bytes payload = 1;
+    string id = 2;
+}
+
+message AclRecord {
+    string prevId = 1;
+    bytes identity = 2;
+    bytes data = 3;
+    string readKeyId = 4;
+    int64 timestamp = 5;
+}
+
 message AclRoot {
     bytes identity = 1;
     bytes masterKey = 2;
@@ -12,95 +31,82 @@ message AclRoot {
     bytes identitySignature = 6;
 }
 
-// AclAccountInvite contains the public invite key, the private part of which is sent to the user directly
-message AclAccountInvite {
-    bytes inviteKey = 1;
-}
-
-// AclAccountRequestJoin contains the reference to the invite record and the data of the person who wants to join, confirmed by the private invite key
-message AclAccountRequestJoin {
-    bytes inviteIdentity = 1;
-    string inviteRecordId = 2;
-    bytes inviteIdentitySignature = 3;
-    bytes metadata = 4;
-}
-
-// AclAccountRequestAccept contains the reference to join record and all read keys, encrypted with the identity of the requestor
-message AclAccountRequestAccept {
-    bytes identity = 1;
-    string requestRecordId = 2;
-    repeated AclReadKeyWithRecord encryptedReadKeys = 3;
-    AclUserPermissions permissions = 4;
-}
-
-// AclAccountRequestDecline contains the reference to join record
-message AclAccountRequestDecline {
-    string requestRecordId = 1;
-}
-
-// AclAccountInviteRevoke revokes the invite record
-message AclAccountInviteRevoke {
-    string inviteRecordId = 1;
-}
-
-// AclReadKeys are a read key with record id
-message AclReadKeyWithRecord {
-    string recordId = 1;
-    bytes encryptedReadKey = 2;
-}
-
-// AclEncryptedReadKeys are new key for specific identity
-message AclEncryptedReadKey {
-    bytes identity = 1;
-    bytes encryptedReadKey = 2;
-}
-
-// AclAccountPermissionChange changes permissions of specific account
-message AclAccountPermissionChange {
-    bytes identity = 1;
-    AclUserPermissions permissions = 2;
-}
-
-// AclReadKeyChange changes the key for a space
-message AclReadKeyChange {
-    repeated AclEncryptedReadKey accountKeys = 1;
-}
-
-// AclAccountRemove removes an account and changes read key for space
-message AclAccountRemove {
-    repeated bytes identities = 1;
-    repeated AclEncryptedReadKey accountKeys = 2;
-}
-
-// AclAccountRequestRemove adds a request to remove an account
-message AclAccountRequestRemove {
-}
-
-// AclContentValue contains possible values for Acl
 message AclContentValue {
     oneof value {
-        AclAccountInvite invite = 1;
-        AclAccountInviteRevoke inviteRevoke = 2;
-        AclAccountRequestJoin requestJoin = 3;
-        AclAccountRequestAccept requestAccept = 4;
-        AclAccountPermissionChange permissionChange = 5;
-        AclAccountRemove accountRemove = 6;
-        AclReadKeyChange readKeyChange = 7;
-        AclAccountRequestDecline requestDecline = 8;
-        AclAccountRequestRemove accountRequestRemove = 9;
+        AclUserAdd userAdd = 1;
+        AclUserRemove userRemove = 2;
+        AclUserPermissionChange userPermissionChange = 3;
+        AclUserInvite userInvite = 4;
+        AclUserJoin userJoin = 5;
     }
 }
 
-// AclData contains different acl content
 message AclData {
     repeated AclContentValue aclContent = 1;
 }
 
-// AclUserPermissions contains different possible user roles
-enum AclUserPermissions {
-    None = 0;
-    Owner = 1;
-    Admin = 2;
-    Writer = 3;
-    Reader = 4;
+message AclState {
+    repeated string readKeyIds = 1;
+    repeated AclUserState userStates = 2;
+    map<string, AclUserInvite> invites = 3;
 }
+
+message AclUserState {
+    bytes identity = 1;
+    AclUserPermissions permissions = 2;
+}
+
+message AclUserAdd {
+    bytes identity = 1;
+    repeated bytes encryptedReadKeys = 2;
+    AclUserPermissions permissions = 3;
+}
+
+message AclUserInvite {
+    bytes acceptPublicKey = 1;
+    repeated bytes encryptedReadKeys = 2;
+    AclUserPermissions permissions = 3;
+}
+
+message AclUserJoin {
+    bytes identity = 1;
+    bytes acceptSignature = 2;
+    bytes acceptPubKey = 3;
+    repeated bytes encryptedReadKeys = 4;
+}
+
+message AclUserRemove {
+    bytes identity = 1;
+    repeated AclReadKeyReplace readKeyReplaces = 2;
+}
+
+message AclReadKeyReplace {
+    bytes identity = 1;
+    bytes encryptedReadKey = 2;
+}
+
+message AclUserPermissionChange {
+    bytes identity = 1;
+    AclUserPermissions permissions = 2;
+}
+
+enum AclUserPermissions {
+    Admin = 0;
+    Writer = 1;
+    Reader = 2;
+}
+
+message AclSyncMessage {
+    AclSyncContentValue content = 1;
+}
+
+// AclSyncContentValue provides different types for acl sync
+message AclSyncContentValue {
+    oneof value {
+        AclAddRecords addRecords = 1;
+    }
+}
+
+message AclAddRecords {
+    repeated RawAclRecordWithId records = 1;
+}

commonspace/object/acl/list/aclrecordbuilder.go

@@ -1,14 +1,11 @@
 package list
 
 import (
-	"time"
-
-	"github.com/anyproto/any-sync/commonspace/object/accountdata"
 	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/util/cidutil"
 	"github.com/anyproto/any-sync/util/crypto"
 	"github.com/gogo/protobuf/proto"
+	"time"
 )
 
 type RootContent struct {
@@ -18,387 +15,26 @@ type RootContent struct {
 	EncryptedReadKey []byte
 }
 
-type RequestJoinPayload struct {
-	InviteRecordId string
-	InviteKey      crypto.PrivKey
-	Metadata       []byte
-}
-
-type RequestAcceptPayload struct {
-	RequestRecordId string
-	Permissions     AclPermissions
-}
-
-type PermissionChangePayload struct {
-	Identity    crypto.PubKey
-	Permissions AclPermissions
-}
-
-type AccountRemovePayload struct {
-	Identities []crypto.PubKey
-	ReadKey    crypto.SymKey
-}
-
-type InviteResult struct {
-	InviteRec *consensusproto.RawRecord
-	InviteKey crypto.PrivKey
-}
-
 type AclRecordBuilder interface {
-	UnmarshallWithId(rawIdRecord *consensusproto.RawRecordWithId) (rec *AclRecord, err error)
-	Unmarshall(rawRecord *consensusproto.RawRecord) (rec *AclRecord, err error)
-
-	BuildRoot(content RootContent) (rec *consensusproto.RawRecordWithId, err error)
-	BuildInvite() (res InviteResult, err error)
-	BuildInviteRevoke(inviteRecordId string) (rawRecord *consensusproto.RawRecord, err error)
-	BuildRequestJoin(payload RequestJoinPayload) (rawRecord *consensusproto.RawRecord, err error)
-	BuildRequestAccept(payload RequestAcceptPayload) (rawRecord *consensusproto.RawRecord, err error)
-	BuildRequestDecline(requestRecordId string) (rawRecord *consensusproto.RawRecord, err error)
-	BuildRequestRemove() (rawRecord *consensusproto.RawRecord, err error)
-	BuildPermissionChange(payload PermissionChangePayload) (rawRecord *consensusproto.RawRecord, err error)
-	BuildReadKeyChange(newKey crypto.SymKey) (rawRecord *consensusproto.RawRecord, err error)
-	BuildAccountRemove(payload AccountRemovePayload) (rawRecord *consensusproto.RawRecord, err error)
+	Unmarshall(rawIdRecord *aclrecordproto.RawAclRecordWithId) (rec *AclRecord, err error)
+	BuildRoot(content RootContent) (rec *aclrecordproto.RawAclRecordWithId, err error)
 }
 
 type aclRecordBuilder struct {
-	id          string
-	keyStorage  crypto.KeyStorage
-	accountKeys *accountdata.AccountKeys
-	verifier    AcceptorVerifier
-	state       *AclState
+	id         string
+	keyStorage crypto.KeyStorage
 }
 
-func NewAclRecordBuilder(id string, keyStorage crypto.KeyStorage, keys *accountdata.AccountKeys, verifier AcceptorVerifier) AclRecordBuilder {
+func NewAclRecordBuilder(id string, keyStorage crypto.KeyStorage) AclRecordBuilder {
 	return &aclRecordBuilder{
-		id:          id,
-		keyStorage:  keyStorage,
-		accountKeys: keys,
-		verifier:    verifier,
+		id:         id,
+		keyStorage: keyStorage,
 	}
 }
 
-func (a *aclRecordBuilder) buildRecord(aclContent *aclrecordproto.AclContentValue) (rawRec *consensusproto.RawRecord, err error) {
-	aclData := &aclrecordproto.AclData{AclContent: []*aclrecordproto.AclContentValue{
-		aclContent,
-	}}
-	marshalledData, err := aclData.Marshal()
-	if err != nil {
-		return
-	}
-	protoKey, err := a.accountKeys.SignKey.GetPublic().Marshall()
-	if err != nil {
-		return
-	}
-	rec := &consensusproto.Record{
-		PrevId:    a.state.lastRecordId,
-		Identity:  protoKey,
-		Data:      marshalledData,
-		Timestamp: time.Now().Unix(),
-	}
-	marshalledRec, err := rec.Marshal()
-	if err != nil {
-		return
-	}
-	signature, err := a.accountKeys.SignKey.Sign(marshalledRec)
-	if err != nil {
-		return
-	}
-	rawRec = &consensusproto.RawRecord{
-		Payload:   marshalledRec,
-		Signature: signature,
-	}
-	return
-}
-
-func (a *aclRecordBuilder) BuildInvite() (res InviteResult, err error) {
-	if !a.state.Permissions(a.state.pubKey).CanManageAccounts() {
-		err = ErrInsufficientPermissions
-		return
-	}
-	privKey, pubKey, err := crypto.GenerateRandomEd25519KeyPair()
-	if err != nil {
-		return
-	}
-	invitePubKey, err := pubKey.Marshall()
-	if err != nil {
-		return
-	}
-	inviteRec := &aclrecordproto.AclAccountInvite{InviteKey: invitePubKey}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_Invite{Invite: inviteRec}}
-	rawRec, err := a.buildRecord(content)
-	if err != nil {
-		return
-	}
-	res.InviteKey = privKey
-	res.InviteRec = rawRec
-	return
-}
-
-func (a *aclRecordBuilder) BuildInviteRevoke(inviteRecordId string) (rawRecord *consensusproto.RawRecord, err error) {
-	if !a.state.Permissions(a.state.pubKey).CanManageAccounts() {
-		err = ErrInsufficientPermissions
-		return
-	}
-	_, exists := a.state.inviteKeys[inviteRecordId]
-	if !exists {
-		err = ErrNoSuchInvite
-		return
-	}
-	revokeRec := &aclrecordproto.AclAccountInviteRevoke{InviteRecordId: inviteRecordId}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_InviteRevoke{InviteRevoke: revokeRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildRequestJoin(payload RequestJoinPayload) (rawRecord *consensusproto.RawRecord, err error) {
-	key, exists := a.state.inviteKeys[payload.InviteRecordId]
-	if !exists {
-		err = ErrNoSuchInvite
-		return
-	}
-	if !payload.InviteKey.GetPublic().Equals(key) {
-		err = ErrIncorrectInviteKey
-	}
-	rawIdentity, err := a.accountKeys.SignKey.GetPublic().Raw()
-	if err != nil {
-		return
-	}
-	signature, err := payload.InviteKey.Sign(rawIdentity)
-	if err != nil {
-		return
-	}
-	protoIdentity, err := a.accountKeys.SignKey.GetPublic().Marshall()
-	if err != nil {
-		return
-	}
-	joinRec := &aclrecordproto.AclAccountRequestJoin{
-		InviteIdentity:          protoIdentity,
-		InviteRecordId:          payload.InviteRecordId,
-		InviteIdentitySignature: signature,
-		Metadata:                payload.Metadata,
-	}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_RequestJoin{RequestJoin: joinRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildRequestAccept(payload RequestAcceptPayload) (rawRecord *consensusproto.RawRecord, err error) {
-	if !a.state.Permissions(a.state.pubKey).CanManageAccounts() {
-		err = ErrInsufficientPermissions
-		return
-	}
-	request, exists := a.state.requestRecords[payload.RequestRecordId]
-	if !exists {
-		err = ErrNoSuchRequest
-		return
-	}
-	var encryptedReadKeys []*aclrecordproto.AclReadKeyWithRecord
-	for keyId, key := range a.state.userReadKeys {
-		rawKey, err := key.Raw()
-		if err != nil {
-			return nil, err
-		}
-		enc, err := request.RequestIdentity.Encrypt(rawKey)
-		if err != nil {
-			return nil, err
-		}
-		encryptedReadKeys = append(encryptedReadKeys, &aclrecordproto.AclReadKeyWithRecord{
-			RecordId:         keyId,
-			EncryptedReadKey: enc,
-		})
-	}
-	if err != nil {
-		return
-	}
-	requestIdentityProto, err := request.RequestIdentity.Marshall()
-	if err != nil {
-		return
-	}
-	acceptRec := &aclrecordproto.AclAccountRequestAccept{
-		Identity:          requestIdentityProto,
-		RequestRecordId:   payload.RequestRecordId,
-		EncryptedReadKeys: encryptedReadKeys,
-		Permissions:       aclrecordproto.AclUserPermissions(payload.Permissions),
-	}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_RequestAccept{RequestAccept: acceptRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildRequestDecline(requestRecordId string) (rawRecord *consensusproto.RawRecord, err error) {
-	if !a.state.Permissions(a.state.pubKey).CanManageAccounts() {
-		err = ErrInsufficientPermissions
-		return
-	}
-	_, exists := a.state.requestRecords[requestRecordId]
-	if !exists {
-		err = ErrNoSuchRequest
-		return
-	}
-	declineRec := &aclrecordproto.AclAccountRequestDecline{RequestRecordId: requestRecordId}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_RequestDecline{RequestDecline: declineRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildPermissionChange(payload PermissionChangePayload) (rawRecord *consensusproto.RawRecord, err error) {
-	permissions := a.state.Permissions(a.state.pubKey)
-	if !permissions.CanManageAccounts() || payload.Identity.Equals(a.state.pubKey) {
-		err = ErrInsufficientPermissions
-		return
-	}
-	if payload.Permissions.IsOwner() {
-		err = ErrIsOwner
-		return
-	}
-	protoIdentity, err := payload.Identity.Marshall()
-	if err != nil {
-		return
-	}
-	permissionRec := &aclrecordproto.AclAccountPermissionChange{
-		Identity:    protoIdentity,
-		Permissions: aclrecordproto.AclUserPermissions(payload.Permissions),
-	}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_PermissionChange{PermissionChange: permissionRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildReadKeyChange(newKey crypto.SymKey) (rawRecord *consensusproto.RawRecord, err error) {
-	if !a.state.Permissions(a.state.pubKey).CanManageAccounts() {
-		err = ErrInsufficientPermissions
-		return
-	}
-	rawKey, err := newKey.Raw()
-	if err != nil {
-		return
-	}
-	if len(rawKey) != crypto.KeyBytes {
-		err = ErrIncorrectReadKey
-		return
-	}
-	var aclReadKeys []*aclrecordproto.AclEncryptedReadKey
-	for _, st := range a.state.userStates {
-		protoIdentity, err := st.PubKey.Marshall()
-		if err != nil {
-			return nil, err
-		}
-		enc, err := st.PubKey.Encrypt(rawKey)
-		if err != nil {
-			return nil, err
-		}
-		aclReadKeys = append(aclReadKeys, &aclrecordproto.AclEncryptedReadKey{
-			Identity:         protoIdentity,
-			EncryptedReadKey: enc,
-		})
-	}
-	readRec := &aclrecordproto.AclReadKeyChange{AccountKeys: aclReadKeys}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_ReadKeyChange{ReadKeyChange: readRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildAccountRemove(payload AccountRemovePayload) (rawRecord *consensusproto.RawRecord, err error) {
-	deletedMap := map[string]struct{}{}
-	for _, key := range payload.Identities {
-		permissions := a.state.Permissions(key)
-		if permissions.IsOwner() {
-			return nil, ErrInsufficientPermissions
-		}
-		if permissions.NoPermissions() {
-			return nil, ErrNoSuchAccount
-		}
-		deletedMap[mapKeyFromPubKey(key)] = struct{}{}
-	}
-	if !a.state.Permissions(a.state.pubKey).CanManageAccounts() {
-		err = ErrInsufficientPermissions
-		return
-	}
-	rawKey, err := payload.ReadKey.Raw()
-	if err != nil {
-		return
-	}
-	if len(rawKey) != crypto.KeyBytes {
-		err = ErrIncorrectReadKey
-		return
-	}
-	var aclReadKeys []*aclrecordproto.AclEncryptedReadKey
-	for _, st := range a.state.userStates {
-		if _, exists := deletedMap[mapKeyFromPubKey(st.PubKey)]; exists {
-			continue
-		}
-		protoIdentity, err := st.PubKey.Marshall()
-		if err != nil {
-			return nil, err
-		}
-		enc, err := st.PubKey.Encrypt(rawKey)
-		if err != nil {
-			return nil, err
-		}
-		aclReadKeys = append(aclReadKeys, &aclrecordproto.AclEncryptedReadKey{
-			Identity:         protoIdentity,
-			EncryptedReadKey: enc,
-		})
-	}
-	var marshalledIdentities [][]byte
-	for _, key := range payload.Identities {
-		protoIdentity, err := key.Marshall()
-		if err != nil {
-			return nil, err
-		}
-		marshalledIdentities = append(marshalledIdentities, protoIdentity)
-	}
-	removeRec := &aclrecordproto.AclAccountRemove{AccountKeys: aclReadKeys, Identities: marshalledIdentities}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_AccountRemove{AccountRemove: removeRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) BuildRequestRemove() (rawRecord *consensusproto.RawRecord, err error) {
-	permissions := a.state.Permissions(a.state.pubKey)
-	if permissions.NoPermissions() {
-		err = ErrNoSuchAccount
-		return
-	}
-	if permissions.IsOwner() {
-		err = ErrIsOwner
-		return
-	}
-	removeRec := &aclrecordproto.AclAccountRequestRemove{}
-	content := &aclrecordproto.AclContentValue{Value: &aclrecordproto.AclContentValue_AccountRequestRemove{AccountRequestRemove: removeRec}}
-	return a.buildRecord(content)
-}
-
-func (a *aclRecordBuilder) Unmarshall(rawRecord *consensusproto.RawRecord) (rec *AclRecord, err error) {
-	aclRecord := &consensusproto.Record{}
-	err = proto.Unmarshal(rawRecord.Payload, aclRecord)
-	if err != nil {
-		return
-	}
-	pubKey, err := a.keyStorage.PubKeyFromProto(aclRecord.Identity)
-	if err != nil {
-		return
-	}
-	aclData := &aclrecordproto.AclData{}
-	err = proto.Unmarshal(aclRecord.Data, aclData)
-	if err != nil {
-		return
-	}
-	rec = &AclRecord{
-		PrevId:    aclRecord.PrevId,
-		Timestamp: aclRecord.Timestamp,
-		Data:      aclRecord.Data,
-		Signature: rawRecord.Signature,
-		Identity:  pubKey,
-		Model:     aclData,
-	}
-	res, err := pubKey.Verify(rawRecord.Payload, rawRecord.Signature)
-	if err != nil {
-		return
-	}
-	if !res {
-		err = ErrInvalidSignature
-		return
-	}
-	return
-}
-
-func (a *aclRecordBuilder) UnmarshallWithId(rawIdRecord *consensusproto.RawRecordWithId) (rec *AclRecord, err error) {
+func (a *aclRecordBuilder) Unmarshall(rawIdRecord *aclrecordproto.RawAclRecordWithId) (rec *AclRecord, err error) {
 	var (
-		rawRec = &consensusproto.RawRecord{}
+		rawRec = &aclrecordproto.RawAclRecord{}
 		pubKey crypto.PubKey
 	)
 	err = proto.Unmarshal(rawIdRecord.Payload, rawRec)
@@ -417,17 +53,14 @@ func (a *aclRecordBuilder) UnmarshallWithId(rawIdRecord *consensusproto.RawRecor
 		}
 		rec = &AclRecord{
 			Id:        rawIdRecord.Id,
+			ReadKeyId: rawIdRecord.Id,
 			Timestamp: aclRoot.Timestamp,
 			Signature: rawRec.Signature,
 			Identity:  pubKey,
 			Model:     aclRoot,
 		}
 	} else {
-		err = a.verifier.VerifyAcceptor(rawRec)
-		if err != nil {
-			return
-		}
-		aclRecord := &consensusproto.Record{}
+		aclRecord := &aclrecordproto.AclRecord{}
 		err = proto.Unmarshal(rawRec.Payload, aclRecord)
 		if err != nil {
 			return
@@ -436,19 +69,14 @@ func (a *aclRecordBuilder) UnmarshallWithId(rawIdRecord *consensusproto.RawRecor
 		if err != nil {
 			return
 		}
-		aclData := &aclrecordproto.AclData{}
-		err = proto.Unmarshal(aclRecord.Data, aclData)
-		if err != nil {
-			return
-		}
 		rec = &AclRecord{
 			Id:        rawIdRecord.Id,
 			PrevId:    aclRecord.PrevId,
+			ReadKeyId: aclRecord.ReadKeyId,
 			Timestamp: aclRecord.Timestamp,
 			Data:      aclRecord.Data,
 			Signature: rawRec.Signature,
 			Identity:  pubKey,
-			Model:     aclData,
 		}
 	}
 
@@ -456,7 +84,7 @@ func (a *aclRecordBuilder) UnmarshallWithId(rawIdRecord *consensusproto.RawRecor
 	return
 }
 
-func (a *aclRecordBuilder) BuildRoot(content RootContent) (rec *consensusproto.RawRecordWithId, err error) {
+func (a *aclRecordBuilder) BuildRoot(content RootContent) (rec *aclrecordproto.RawAclRecordWithId, err error) {
 	rawIdentity, err := content.PrivKey.GetPublic().Raw()
 	if err != nil {
 		return
@@ -490,8 +118,8 @@ func (a *aclRecordBuilder) BuildRoot(content RootContent) (rec *consensusproto.R
 
 func verifyRaw(
 	pubKey crypto.PubKey,
-	rawRec *consensusproto.RawRecord,
-	recWithId *consensusproto.RawRecordWithId) (err error) {
+	rawRec *aclrecordproto.RawAclRecord,
+	recWithId *aclrecordproto.RawAclRecordWithId) (err error) {
 	// verifying signature
 	res, err := pubKey.Verify(rawRec.Payload, rawRec.Signature)
 	if err != nil {
@@ -509,7 +137,7 @@ func verifyRaw(
 	return
 }
 
-func marshalAclRoot(aclRoot *aclrecordproto.AclRoot, key crypto.PrivKey) (rawWithId *consensusproto.RawRecordWithId, err error) {
+func marshalAclRoot(aclRoot *aclrecordproto.AclRoot, key crypto.PrivKey) (rawWithId *aclrecordproto.RawAclRecordWithId, err error) {
 	marshalledRoot, err := aclRoot.Marshal()
 	if err != nil {
 		return
@@ -518,7 +146,7 @@ func marshalAclRoot(aclRoot *aclrecordproto.AclRoot, key crypto.PrivKey) (rawWit
 	if err != nil {
 		return
 	}
-	raw := &consensusproto.RawRecord{
+	raw := &aclrecordproto.RawAclRecord{
 		Payload:   marshalledRoot,
 		Signature: signature,
 	}
@@ -530,7 +158,7 @@ func marshalAclRoot(aclRoot *aclrecordproto.AclRoot, key crypto.PrivKey) (rawWit
 	if err != nil {
 		return
 	}
-	rawWithId = &consensusproto.RawRecordWithId{
+	rawWithId = &aclrecordproto.RawAclRecordWithId{
 		Payload: marshalledRaw,
 		Id:      aclHeadId,
 	}

commonspace/object/acl/list/aclrecordbuilder_test.go

@@ -0,0 +1,9 @@
+package list
+
+import (
+	"testing"
+)
+
+func TestAclRecordBuilder_BuildUserJoin(t *testing.T) {
+	return
+}

commonspace/object/acl/list/aclstate.go

@@ -2,7 +2,7 @@ package list
 
 import (
 	"errors"
-
+	"fmt"
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/util/crypto"
@@ -13,24 +13,19 @@ import (
 var log = logger.NewNamedSugared("common.commonspace.acllist")
 
 var (
-	ErrNoSuchAccount             = errors.New("no such account")
-	ErrPendingRequest            = errors.New("already exists pending request")
-	ErrUnexpectedContentType     = errors.New("unexpected content type")
-	ErrIncorrectIdentity         = errors.New("incorrect identity")
-	ErrIncorrectInviteKey        = errors.New("incorrect invite key")
-	ErrFailedToDecrypt           = errors.New("failed to decrypt key")
-	ErrNoSuchRecord              = errors.New("no such record")
-	ErrNoSuchRequest             = errors.New("no such request")
-	ErrNoSuchInvite              = errors.New("no such invite")
-	ErrInsufficientPermissions   = errors.New("insufficient permissions")
-	ErrIsOwner                   = errors.New("can't be made by owner")
-	ErrIncorrectNumberOfAccounts = errors.New("incorrect number of accounts")
-	ErrDuplicateAccounts         = errors.New("duplicate accounts")
-	ErrNoReadKey                 = errors.New("acl state doesn't have a read key")
-	ErrIncorrectReadKey          = errors.New("incorrect read key")
-	ErrInvalidSignature          = errors.New("signature is invalid")
-	ErrIncorrectRoot             = errors.New("incorrect root")
-	ErrIncorrectRecordSequence   = errors.New("incorrect prev id of a record")
+	ErrNoSuchUser              = errors.New("no such user")
+	ErrFailedToDecrypt         = errors.New("failed to decrypt key")
+	ErrUserRemoved             = errors.New("user was removed from the document")
+	ErrDocumentForbidden       = errors.New("your user was forbidden access to the document")
+	ErrUserAlreadyExists       = errors.New("user already exists")
+	ErrNoSuchRecord            = errors.New("no such record")
+	ErrNoSuchInvite            = errors.New("no such invite")
+	ErrOldInvite               = errors.New("invite is too old")
+	ErrInsufficientPermissions = errors.New("insufficient permissions")
+	ErrNoReadKey               = errors.New("acl state doesn't have a read key")
+	ErrInvalidSignature        = errors.New("signature is invalid")
+	ErrIncorrectRoot           = errors.New("incorrect root")
+	ErrIncorrectRecordSequence = errors.New("incorrect prev id of a record")
 )
 
 type UserPermissionPair struct {
@@ -41,71 +36,37 @@ type UserPermissionPair struct {
 type AclState struct {
 	id               string
 	currentReadKeyId string
-	// userReadKeys is a map recordId -> read key which tells us about every read key
-	userReadKeys map[string]crypto.SymKey
-	// userStates is a map pubKey -> state which defines current user state
-	userStates map[string]AclUserState
-	// statesAtRecord is a map recordId -> state which define user state at particular record
-	//  probably this can grow rather large at some point, so we can maybe optimise later to have:
-	//  - map pubKey -> []recordIds (where recordIds is an array where such identity permissions were changed)
-	statesAtRecord map[string][]AclUserState
-	// inviteKeys is a map recordId -> invite
-	inviteKeys map[string]crypto.PubKey
-	// requestRecords is a map recordId -> RequestRecord
-	requestRecords map[string]RequestRecord
-	// pendingRequests is a map pubKey -> recordId
-	pendingRequests map[string]string
-	key             crypto.PrivKey
-	pubKey          crypto.PubKey
-	keyStore        crypto.KeyStorage
-	totalReadKeys   int
+	userReadKeys     map[string]crypto.SymKey
+	userStates       map[string]AclUserState
+	statesAtRecord   map[string][]AclUserState
+	key              crypto.PrivKey
+	pubKey           crypto.PubKey
+	keyStore         crypto.KeyStorage
+	totalReadKeys    int
 
-	lastRecordId     string
-	contentValidator ContentValidator
+	lastRecordId string
 }
 
 func newAclStateWithKeys(
 	id string,
 	key crypto.PrivKey) (*AclState, error) {
-	st := &AclState{
-		id:              id,
-		key:             key,
-		pubKey:          key.GetPublic(),
-		userReadKeys:    make(map[string]crypto.SymKey),
-		userStates:      make(map[string]AclUserState),
-		statesAtRecord:  make(map[string][]AclUserState),
-		inviteKeys:      make(map[string]crypto.PubKey),
-		requestRecords:  make(map[string]RequestRecord),
-		pendingRequests: make(map[string]string),
-		keyStore:        crypto.NewKeyStorage(),
-	}
-	st.contentValidator = &contentValidator{
-		keyStore: st.keyStore,
-		aclState: st,
-	}
-	return st, nil
+	return &AclState{
+		id:             id,
+		key:            key,
+		pubKey:         key.GetPublic(),
+		userReadKeys:   make(map[string]crypto.SymKey),
+		userStates:     make(map[string]AclUserState),
+		statesAtRecord: make(map[string][]AclUserState),
+	}, nil
 }
 
 func newAclState(id string) *AclState {
-	st := &AclState{
-		id:              id,
-		userReadKeys:    make(map[string]crypto.SymKey),
-		userStates:      make(map[string]AclUserState),
-		statesAtRecord:  make(map[string][]AclUserState),
-		inviteKeys:      make(map[string]crypto.PubKey),
-		requestRecords:  make(map[string]RequestRecord),
-		pendingRequests: make(map[string]string),
-		keyStore:        crypto.NewKeyStorage(),
+	return &AclState{
+		id:             id,
+		userReadKeys:   make(map[string]crypto.SymKey),
+		userStates:     make(map[string]AclUserState),
+		statesAtRecord: make(map[string][]AclUserState),
 	}
-	st.contentValidator = &contentValidator{
-		keyStore: st.keyStore,
-		aclState: st,
-	}
-	return st
-}
-
-func (st *AclState) Validator() ContentValidator {
-	return st.contentValidator
 }
 
 func (st *AclState) CurrentReadKeyId() string {
@@ -113,7 +74,7 @@ func (st *AclState) CurrentReadKeyId() string {
 }
 
 func (st *AclState) CurrentReadKey() (crypto.SymKey, error) {
-	key, exists := st.userReadKeys[st.CurrentReadKeyId()]
+	key, exists := st.userReadKeys[st.currentReadKeyId]
 	if !exists {
 		return nil, ErrNoReadKey
 	}
@@ -136,7 +97,7 @@ func (st *AclState) StateAtRecord(id string, pubKey crypto.PubKey) (AclUserState
 			return perm, nil
 		}
 	}
-	return AclUserState{}, ErrNoSuchAccount
+	return AclUserState{}, ErrNoSuchUser
 }
 
 func (st *AclState) applyRecord(record *AclRecord) (err error) {
@@ -149,18 +110,17 @@ func (st *AclState) applyRecord(record *AclRecord) (err error) {
 		err = ErrIncorrectRecordSequence
 		return
 	}
-	// if the record is root record
 	if record.Id == st.id {
 		err = st.applyRoot(record)
 		if err != nil {
 			return
 		}
 		st.statesAtRecord[record.Id] = []AclUserState{
-			st.userStates[mapKeyFromPubKey(record.Identity)],
+			{PubKey: record.Identity, Permissions: aclrecordproto.AclUserPermissions_Admin},
 		}
 		return
 	}
-	// if the model is not cached
+
 	if record.Model == nil {
 		aclData := &aclrecordproto.AclData{}
 		err = proto.Unmarshal(record.Data, aclData)
@@ -169,16 +129,18 @@ func (st *AclState) applyRecord(record *AclRecord) (err error) {
 		}
 		record.Model = aclData
 	}
-	// applying records contents
+
 	err = st.applyChangeData(record)
 	if err != nil {
 		return
 	}
-	// getting all states for users at record and saving them
+
+	// getting all states for users at record
 	var states []AclUserState
 	for _, state := range st.userStates {
 		states = append(states, state)
 	}
+
 	st.statesAtRecord[record.Id] = states
 	return
 }
@@ -194,9 +156,9 @@ func (st *AclState) applyRoot(record *AclRecord) (err error) {
 	// adding user to the list
 	userState := AclUserState{
 		PubKey:      record.Identity,
-		Permissions: AclPermissions(aclrecordproto.AclUserPermissions_Owner),
+		Permissions: aclrecordproto.AclUserPermissions_Admin,
 	}
-	st.currentReadKeyId = record.Id
+	st.currentReadKeyId = record.ReadKeyId
 	st.userStates[mapKeyFromPubKey(record.Identity)] = userState
 	st.totalReadKeys++
 	return
@@ -219,191 +181,92 @@ func (st *AclState) saveReadKeyFromRoot(record *AclRecord) (err error) {
 			return
 		}
 	}
+
 	st.userReadKeys[record.Id] = readKey
 	return
 }
 
 func (st *AclState) applyChangeData(record *AclRecord) (err error) {
+	defer func() {
+		if err != nil {
+			return
+		}
+		if record.ReadKeyId != st.currentReadKeyId {
+			st.totalReadKeys++
+			st.currentReadKeyId = record.ReadKeyId
+		}
+	}()
 	model := record.Model.(*aclrecordproto.AclData)
+	if !st.isUserJoin(model) {
+		// we check signature when we add this to the List, so no need to do it here
+		if _, exists := st.userStates[mapKeyFromPubKey(record.Identity)]; !exists {
+			err = ErrNoSuchUser
+			return
+		}
+
+		// only Admins can do non-user join changes
+		if !st.HasPermission(record.Identity, aclrecordproto.AclUserPermissions_Admin) {
+			// TODO: add string encoding
+			err = fmt.Errorf("user %s must have admin permissions", record.Identity.Account())
+			return
+		}
+	}
+
 	for _, ch := range model.GetAclContent() {
-		if err = st.applyChangeContent(ch, record.Id, record.Identity); err != nil {
+		if err = st.applyChangeContent(ch, record.Id); err != nil {
 			log.Info("error while applying changes: %v; ignore", zap.Error(err))
 			return err
 		}
 	}
+
 	return nil
 }
 
-func (st *AclState) applyChangeContent(ch *aclrecordproto.AclContentValue, recordId string, authorIdentity crypto.PubKey) error {
+func (st *AclState) applyChangeContent(ch *aclrecordproto.AclContentValue, recordId string) error {
 	switch {
-	case ch.GetPermissionChange() != nil:
-		return st.applyPermissionChange(ch.GetPermissionChange(), recordId, authorIdentity)
-	case ch.GetInvite() != nil:
-		return st.applyInvite(ch.GetInvite(), recordId, authorIdentity)
-	case ch.GetInviteRevoke() != nil:
-		return st.applyInviteRevoke(ch.GetInviteRevoke(), recordId, authorIdentity)
-	case ch.GetRequestJoin() != nil:
-		return st.applyRequestJoin(ch.GetRequestJoin(), recordId, authorIdentity)
-	case ch.GetRequestAccept() != nil:
-		return st.applyRequestAccept(ch.GetRequestAccept(), recordId, authorIdentity)
-	case ch.GetRequestDecline() != nil:
-		return st.applyRequestDecline(ch.GetRequestDecline(), recordId, authorIdentity)
-	case ch.GetAccountRemove() != nil:
-		return st.applyAccountRemove(ch.GetAccountRemove(), recordId, authorIdentity)
-	case ch.GetReadKeyChange() != nil:
-		return st.applyReadKeyChange(ch.GetReadKeyChange(), recordId, authorIdentity)
-	case ch.GetAccountRequestRemove() != nil:
-		return st.applyRequestRemove(ch.GetAccountRequestRemove(), recordId, authorIdentity)
+	case ch.GetUserPermissionChange() != nil:
+		return st.applyUserPermissionChange(ch.GetUserPermissionChange(), recordId)
+	case ch.GetUserAdd() != nil:
+		return st.applyUserAdd(ch.GetUserAdd(), recordId)
+	case ch.GetUserRemove() != nil:
+		return st.applyUserRemove(ch.GetUserRemove(), recordId)
+	case ch.GetUserInvite() != nil:
+		return st.applyUserInvite(ch.GetUserInvite(), recordId)
+	case ch.GetUserJoin() != nil:
+		return st.applyUserJoin(ch.GetUserJoin(), recordId)
 	default:
-		return ErrUnexpectedContentType
+		return fmt.Errorf("unexpected change type: %v", ch)
 	}
 }
 
-func (st *AclState) applyPermissionChange(ch *aclrecordproto.AclAccountPermissionChange, recordId string, authorIdentity crypto.PubKey) error {
+func (st *AclState) applyUserPermissionChange(ch *aclrecordproto.AclUserPermissionChange, recordId string) error {
 	chIdentity, err := st.keyStore.PubKeyFromProto(ch.Identity)
 	if err != nil {
 		return err
 	}
-	err = st.contentValidator.ValidatePermissionChange(ch, authorIdentity)
-	if err != nil {
-		return err
+	state, exists := st.userStates[mapKeyFromPubKey(chIdentity)]
+	if !exists {
+		return ErrNoSuchUser
 	}
-	stringKey := mapKeyFromPubKey(chIdentity)
-	state, _ := st.userStates[stringKey]
-	state.Permissions = AclPermissions(ch.Permissions)
-	st.userStates[stringKey] = state
+
+	state.Permissions = ch.Permissions
 	return nil
 }
 
-func (st *AclState) applyInvite(ch *aclrecordproto.AclAccountInvite, recordId string, authorIdentity crypto.PubKey) error {
-	inviteKey, err := st.keyStore.PubKeyFromProto(ch.InviteKey)
-	if err != nil {
-		return err
-	}
-	err = st.contentValidator.ValidateInvite(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	st.inviteKeys[recordId] = inviteKey
+func (st *AclState) applyUserInvite(ch *aclrecordproto.AclUserInvite, recordId string) error {
+	// TODO: check old code and bring it back :-)
 	return nil
 }
 
-func (st *AclState) applyInviteRevoke(ch *aclrecordproto.AclAccountInviteRevoke, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateInviteRevoke(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	delete(st.inviteKeys, ch.InviteRecordId)
+func (st *AclState) applyUserJoin(ch *aclrecordproto.AclUserJoin, recordId string) error {
 	return nil
 }
 
-func (st *AclState) applyRequestJoin(ch *aclrecordproto.AclAccountRequestJoin, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateRequestJoin(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	st.pendingRequests[mapKeyFromPubKey(authorIdentity)] = recordId
-	st.requestRecords[recordId] = RequestRecord{
-		RequestIdentity: authorIdentity,
-		RequestMetadata: ch.Metadata,
-		Type:            RequestTypeJoin,
-	}
+func (st *AclState) applyUserAdd(ch *aclrecordproto.AclUserAdd, recordId string) error {
 	return nil
 }
 
-func (st *AclState) applyRequestAccept(ch *aclrecordproto.AclAccountRequestAccept, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateRequestAccept(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	acceptIdentity, err := st.keyStore.PubKeyFromProto(ch.Identity)
-	if err != nil {
-		return err
-	}
-	record, _ := st.requestRecords[ch.RequestRecordId]
-	st.userStates[mapKeyFromPubKey(acceptIdentity)] = AclUserState{
-		PubKey:          acceptIdentity,
-		Permissions:     AclPermissions(ch.Permissions),
-		RequestMetadata: record.RequestMetadata,
-	}
-	delete(st.pendingRequests, mapKeyFromPubKey(st.requestRecords[ch.RequestRecordId].RequestIdentity))
-	if !st.pubKey.Equals(acceptIdentity) {
-		return nil
-	}
-	for _, key := range ch.EncryptedReadKeys {
-		decrypted, err := st.key.Decrypt(key.EncryptedReadKey)
-		if err != nil {
-			return err
-		}
-		sym, err := crypto.UnmarshallAESKey(decrypted)
-		if err != nil {
-			return err
-		}
-		st.userReadKeys[key.RecordId] = sym
-	}
-	return nil
-}
-
-func (st *AclState) applyRequestDecline(ch *aclrecordproto.AclAccountRequestDecline, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateRequestDecline(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	delete(st.pendingRequests, mapKeyFromPubKey(st.requestRecords[ch.RequestRecordId].RequestIdentity))
-	delete(st.requestRecords, ch.RequestRecordId)
-	return nil
-}
-
-func (st *AclState) applyRequestRemove(ch *aclrecordproto.AclAccountRequestRemove, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateRequestRemove(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	st.requestRecords[recordId] = RequestRecord{
-		RequestIdentity: authorIdentity,
-		Type:            RequestTypeRemove,
-	}
-	st.pendingRequests[mapKeyFromPubKey(authorIdentity)] = recordId
-	return nil
-}
-
-func (st *AclState) applyAccountRemove(ch *aclrecordproto.AclAccountRemove, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateAccountRemove(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	for _, rawIdentity := range ch.Identities {
-		identity, err := st.keyStore.PubKeyFromProto(rawIdentity)
-		if err != nil {
-			return err
-		}
-		idKey := mapKeyFromPubKey(identity)
-		delete(st.userStates, idKey)
-		delete(st.pendingRequests, idKey)
-	}
-	return st.updateReadKey(ch.AccountKeys, recordId)
-}
-
-func (st *AclState) applyReadKeyChange(ch *aclrecordproto.AclReadKeyChange, recordId string, authorIdentity crypto.PubKey) error {
-	err := st.contentValidator.ValidateReadKeyChange(ch, authorIdentity)
-	if err != nil {
-		return err
-	}
-	return st.updateReadKey(ch.AccountKeys, recordId)
-}
-
-func (st *AclState) updateReadKey(keys []*aclrecordproto.AclEncryptedReadKey, recordId string) error {
-	for _, accKey := range keys {
-		identity, _ := st.keyStore.PubKeyFromProto(accKey.Identity)
-		if st.pubKey.Equals(identity) {
-			res, err := st.decryptReadKey(accKey.EncryptedReadKey)
-			if err != nil {
-				return err
-			}
-			st.userReadKeys[recordId] = res
-		}
-	}
-	st.currentReadKeyId = recordId
+func (st *AclState) applyUserRemove(ch *aclrecordproto.AclUserRemove, recordId string) error {
 	return nil
 }
 
@@ -412,6 +275,7 @@ func (st *AclState) decryptReadKey(msg []byte) (crypto.SymKey, error) {
 	if err != nil {
 		return nil, ErrFailedToDecrypt
 	}
+
 	key, err := crypto.UnmarshallAESKey(decrypted)
 	if err != nil {
 		return nil, ErrFailedToDecrypt
@@ -419,31 +283,29 @@ func (st *AclState) decryptReadKey(msg []byte) (crypto.SymKey, error) {
 	return key, nil
 }
 
-func (st *AclState) Permissions(identity crypto.PubKey) AclPermissions {
+func (st *AclState) HasPermission(identity crypto.PubKey, permission aclrecordproto.AclUserPermissions) bool {
 	state, exists := st.userStates[mapKeyFromPubKey(identity)]
 	if !exists {
-		return AclPermissions(aclrecordproto.AclUserPermissions_None)
+		return false
 	}
-	return state.Permissions
+
+	return state.Permissions == permission
 }
 
-func (st *AclState) JoinRecords() (records []RequestRecord) {
-	for _, recId := range st.pendingRequests {
-		rec := st.requestRecords[recId]
-		if rec.Type == RequestTypeJoin {
-			records = append(records, rec)
-		}
-	}
-	return
+func (st *AclState) isUserJoin(data *aclrecordproto.AclData) bool {
+	// if we have a UserJoin, then it should always be the first one applied
+	return data.GetAclContent() != nil && data.GetAclContent()[0].GetUserJoin() != nil
 }
 
-func (st *AclState) RemoveRecords() (records []RequestRecord) {
-	for _, recId := range st.pendingRequests {
-		rec := st.requestRecords[recId]
-		if rec.Type == RequestTypeRemove {
-			records = append(records, rec)
-		}
-	}
+func (st *AclState) isUserAdd(data *aclrecordproto.AclData, identity []byte) bool {
+	return false
+}
+
+func (st *AclState) UserStates() map[string]AclUserState {
+	return st.userStates
+}
+
+func (st *AclState) Invite(acceptPubKey []byte) (invite *aclrecordproto.AclUserInvite, err error) {
 	return
 }
 

commonspace/object/acl/list/list.go

@@ -5,21 +5,16 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"sync"
-
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/liststorage"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/anyproto/any-sync/util/cidutil"
 	"github.com/anyproto/any-sync/util/crypto"
+	"sync"
 )
 
 type IterFunc = func(record *AclRecord) (IsContinue bool)
 
-var (
-	ErrIncorrectCID        = errors.New("incorrect CID")
-	ErrRecordAlreadyExists = errors.New("record already exists")
-)
+var ErrIncorrectCID = errors.New("incorrect CID")
 
 type RWLocker interface {
 	sync.Locker
@@ -27,46 +22,26 @@ type RWLocker interface {
 	RUnlock()
 }
 
-type AcceptorVerifier interface {
-	VerifyAcceptor(rec *consensusproto.RawRecord) (err error)
-}
-
-type NoOpAcceptorVerifier struct {
-}
-
-func (n NoOpAcceptorVerifier) VerifyAcceptor(rec *consensusproto.RawRecord) (err error) {
-	return nil
-}
-
 type AclList interface {
 	RWLocker
 	Id() string
-	Root() *consensusproto.RawRecordWithId
+	Root() *aclrecordproto.RawAclRecordWithId
 	Records() []*AclRecord
 	AclState() *AclState
 	IsAfter(first string, second string) (bool, error)
-	HasHead(head string) bool
 	Head() *AclRecord
-
-	RecordsAfter(ctx context.Context, id string) (records []*consensusproto.RawRecordWithId, err error)
-	RecordsBefore(ctx context.Context, headId string) (records []*consensusproto.RawRecordWithId, err error)
 	Get(id string) (*AclRecord, error)
-	GetIndex(idx int) (*AclRecord, error)
 	Iterate(iterFunc IterFunc)
 	IterateFrom(startId string, iterFunc IterFunc)
-
 	KeyStorage() crypto.KeyStorage
-	RecordBuilder() AclRecordBuilder
 
-	ValidateRawRecord(record *consensusproto.RawRecord) (err error)
-	AddRawRecord(rawRec *consensusproto.RawRecordWithId) (err error)
-	AddRawRecords(rawRecords []*consensusproto.RawRecordWithId) (err error)
+	AddRawRecord(rawRec *aclrecordproto.RawAclRecordWithId) (added bool, err error)
 
-	Close(ctx context.Context) (err error)
+	Close() (err error)
 }
 
 type aclList struct {
-	root    *consensusproto.RawRecordWithId
+	root    *aclrecordproto.RawAclRecordWithId
 	records []*AclRecord
 	indexes map[string]int
 	id      string
@@ -80,45 +55,18 @@ type aclList struct {
 	sync.RWMutex
 }
 
-type internalDeps struct {
-	storage          liststorage.ListStorage
-	keyStorage       crypto.KeyStorage
-	stateBuilder     *aclStateBuilder
-	recordBuilder    AclRecordBuilder
-	acceptorVerifier AcceptorVerifier
-}
-
-func BuildAclListWithIdentity(acc *accountdata.AccountKeys, storage liststorage.ListStorage, verifier AcceptorVerifier) (AclList, error) {
+func BuildAclListWithIdentity(acc *accountdata.AccountKeys, storage liststorage.ListStorage) (AclList, error) {
+	builder := newAclStateBuilderWithIdentity(acc)
 	keyStorage := crypto.NewKeyStorage()
-	deps := internalDeps{
-		storage:          storage,
-		keyStorage:       keyStorage,
-		stateBuilder:     newAclStateBuilderWithIdentity(acc),
-		recordBuilder:    NewAclRecordBuilder(storage.Id(), keyStorage, acc, verifier),
-		acceptorVerifier: verifier,
-	}
-	return build(deps)
+	return build(storage.Id(), keyStorage, builder, NewAclRecordBuilder(storage.Id(), keyStorage), storage)
 }
 
-func BuildAclList(storage liststorage.ListStorage, verifier AcceptorVerifier) (AclList, error) {
+func BuildAclList(storage liststorage.ListStorage) (AclList, error) {
 	keyStorage := crypto.NewKeyStorage()
-	deps := internalDeps{
-		storage:          storage,
-		keyStorage:       keyStorage,
-		stateBuilder:     newAclStateBuilder(),
-		recordBuilder:    NewAclRecordBuilder(storage.Id(), keyStorage, nil, verifier),
-		acceptorVerifier: verifier,
-	}
-	return build(deps)
+	return build(storage.Id(), keyStorage, newAclStateBuilder(), NewAclRecordBuilder(storage.Id(), crypto.NewKeyStorage()), storage)
 }
 
-func build(deps internalDeps) (list AclList, err error) {
-	var (
-		storage      = deps.storage
-		id           = deps.storage.Id()
-		recBuilder   = deps.recordBuilder
-		stateBuilder = deps.stateBuilder
-	)
+func build(id string, keyStorage crypto.KeyStorage, stateBuilder *aclStateBuilder, recBuilder AclRecordBuilder, storage liststorage.ListStorage) (list AclList, err error) {
 	head, err := storage.Head()
 	if err != nil {
 		return
@@ -129,7 +77,7 @@ func build(deps internalDeps) (list AclList, err error) {
 		return
 	}
 
-	record, err := recBuilder.UnmarshallWithId(rawRecordWithId)
+	record, err := recBuilder.Unmarshall(rawRecordWithId)
 	if err != nil {
 		return
 	}
@@ -141,7 +89,7 @@ func build(deps internalDeps) (list AclList, err error) {
 			return
 		}
 
-		record, err = recBuilder.UnmarshallWithId(rawRecordWithId)
+		record, err = recBuilder.Unmarshall(rawRecordWithId)
 		if err != nil {
 			return
 		}
@@ -171,7 +119,6 @@ func build(deps internalDeps) (list AclList, err error) {
 		return
 	}
 
-	recBuilder.(*aclRecordBuilder).state = state
 	list = &aclList{
 		root:          rootWithId,
 		records:       records,
@@ -185,37 +132,15 @@ func build(deps internalDeps) (list AclList, err error) {
 	return
 }
 
-func (a *aclList) RecordBuilder() AclRecordBuilder {
-	return a.recordBuilder
-}
-
 func (a *aclList) Records() []*AclRecord {
 	return a.records
 }
 
-func (a *aclList) ValidateRawRecord(rawRec *consensusproto.RawRecord) (err error) {
-	record, err := a.recordBuilder.Unmarshall(rawRec)
-	if err != nil {
+func (a *aclList) AddRawRecord(rawRec *aclrecordproto.RawAclRecordWithId) (added bool, err error) {
+	if _, ok := a.indexes[rawRec.Id]; ok {
 		return
 	}
-	return a.aclState.Validator().ValidateAclRecordContents(record)
-}
-
-func (a *aclList) AddRawRecords(rawRecords []*consensusproto.RawRecordWithId) (err error) {
-	for _, rec := range rawRecords {
-		err = a.AddRawRecord(rec)
-		if err != nil && err != ErrRecordAlreadyExists {
-			return
-		}
-	}
-	return
-}
-
-func (a *aclList) AddRawRecord(rawRec *consensusproto.RawRecordWithId) (err error) {
-	if _, ok := a.indexes[rawRec.Id]; ok {
-		return ErrRecordAlreadyExists
-	}
-	record, err := a.recordBuilder.UnmarshallWithId(rawRec)
+	record, err := a.recordBuilder.Unmarshall(rawRec)
 	if err != nil {
 		return
 	}
@@ -230,6 +155,15 @@ func (a *aclList) AddRawRecord(rawRec *consensusproto.RawRecordWithId) (err erro
 	if err = a.storage.SetHead(rawRec.Id); err != nil {
 		return
 	}
+	return true, nil
+}
+
+func (a *aclList) IsValidNext(rawRec *aclrecordproto.RawAclRecordWithId) (err error) {
+	_, err = a.recordBuilder.Unmarshall(rawRec)
+	if err != nil {
+		return
+	}
+	// TODO: change state and add "check" method for records
 	return
 }
 
@@ -237,7 +171,7 @@ func (a *aclList) Id() string {
 	return a.id
 }
 
-func (a *aclList) Root() *consensusproto.RawRecordWithId {
+func (a *aclList) Root() *aclrecordproto.RawAclRecordWithId {
 	return a.root
 }
 
@@ -262,27 +196,14 @@ func (a *aclList) Head() *AclRecord {
 	return a.records[len(a.records)-1]
 }
 
-func (a *aclList) HasHead(head string) bool {
-	_, exists := a.indexes[head]
-	return exists
-}
-
 func (a *aclList) Get(id string) (*AclRecord, error) {
 	recIdx, ok := a.indexes[id]
 	if !ok {
-		return nil, ErrNoSuchRecord
+		return nil, fmt.Errorf("no such record")
 	}
 	return a.records[recIdx], nil
 }
 
-func (a *aclList) GetIndex(idx int) (*AclRecord, error) {
-	// TODO: when we add snapshots we will have to monitor record num in snapshots
-	if idx < 0 || idx >= len(a.records) {
-		return nil, ErrNoSuchRecord
-	}
-	return a.records[idx], nil
-}
-
 func (a *aclList) Iterate(iterFunc IterFunc) {
 	for _, rec := range a.records {
 		if !iterFunc(rec) {
@@ -291,39 +212,6 @@ func (a *aclList) Iterate(iterFunc IterFunc) {
 	}
 }
 
-func (a *aclList) RecordsAfter(ctx context.Context, id string) (records []*consensusproto.RawRecordWithId, err error) {
-	recIdx, ok := a.indexes[id]
-	if !ok {
-		return nil, ErrNoSuchRecord
-	}
-	for i := recIdx + 1; i < len(a.records); i++ {
-		rawRec, err := a.storage.GetRawRecord(ctx, a.records[i].Id)
-		if err != nil {
-			return nil, err
-		}
-		records = append(records, rawRec)
-	}
-	return
-}
-
-func (a *aclList) RecordsBefore(ctx context.Context, headId string) (records []*consensusproto.RawRecordWithId, err error) {
-	if headId == "" {
-		headId = a.Head().Id
-	}
-	recIdx, ok := a.indexes[headId]
-	if !ok {
-		return nil, ErrNoSuchRecord
-	}
-	for i := 0; i <= recIdx; i++ {
-		rawRec, err := a.storage.GetRawRecord(ctx, a.records[i].Id)
-		if err != nil {
-			return nil, err
-		}
-		records = append(records, rawRec)
-	}
-	return
-}
-
 func (a *aclList) IterateFrom(startId string, iterFunc IterFunc) {
 	recIdx, ok := a.indexes[startId]
 	if !ok {
@@ -336,21 +224,6 @@ func (a *aclList) IterateFrom(startId string, iterFunc IterFunc) {
 	}
 }
 
-func (a *aclList) Close(ctx context.Context) (err error) {
+func (a *aclList) Close() (err error) {
 	return nil
 }
-
-func WrapAclRecord(rawRec *consensusproto.RawRecord) *consensusproto.RawRecordWithId {
-	payload, err := rawRec.Marshal()
-	if err != nil {
-		panic(err)
-	}
-	id, err := cidutil.NewCidFromBytes(payload)
-	if err != nil {
-		panic(err)
-	}
-	return &consensusproto.RawRecordWithId{
-		Payload: payload,
-		Id:      id,
-	}
-}

commonspace/object/acl/list/list_test.go

@@ -2,98 +2,11 @@ package list
 
 import (
 	"fmt"
-	"testing"
-
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
-	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/anyproto/any-sync/util/crypto"
 	"github.com/stretchr/testify/require"
+	"testing"
 )
 
-type aclFixture struct {
-	ownerKeys   *accountdata.AccountKeys
-	accountKeys *accountdata.AccountKeys
-	ownerAcl    *aclList
-	accountAcl  *aclList
-	spaceId     string
-}
-
-func newFixture(t *testing.T) *aclFixture {
-	ownerKeys, err := accountdata.NewRandom()
-	require.NoError(t, err)
-	accountKeys, err := accountdata.NewRandom()
-	require.NoError(t, err)
-	spaceId := "spaceId"
-	ownerAcl, err := NewTestDerivedAcl(spaceId, ownerKeys)
-	require.NoError(t, err)
-	accountAcl, err := NewTestAclWithRoot(accountKeys, ownerAcl.Root())
-	require.NoError(t, err)
-	return &aclFixture{
-		ownerKeys:   ownerKeys,
-		accountKeys: accountKeys,
-		ownerAcl:    ownerAcl.(*aclList),
-		accountAcl:  accountAcl.(*aclList),
-		spaceId:     spaceId,
-	}
-}
-
-func (fx *aclFixture) addRec(t *testing.T, rec *consensusproto.RawRecordWithId) {
-	err := fx.ownerAcl.AddRawRecord(rec)
-	require.NoError(t, err)
-	err = fx.accountAcl.AddRawRecord(rec)
-	require.NoError(t, err)
-}
-
-func (fx *aclFixture) inviteAccount(t *testing.T, perms AclPermissions) {
-	var (
-		ownerAcl     = fx.ownerAcl
-		ownerState   = fx.ownerAcl.aclState
-		accountAcl   = fx.accountAcl
-		accountState = fx.accountAcl.aclState
-	)
-	// building invite
-	inv, err := ownerAcl.RecordBuilder().BuildInvite()
-	require.NoError(t, err)
-	inviteRec := WrapAclRecord(inv.InviteRec)
-	fx.addRec(t, inviteRec)
-
-	// building request join
-	requestJoin, err := accountAcl.RecordBuilder().BuildRequestJoin(RequestJoinPayload{
-		InviteRecordId: inviteRec.Id,
-		InviteKey:      inv.InviteKey,
-	})
-	require.NoError(t, err)
-	requestJoinRec := WrapAclRecord(requestJoin)
-	fx.addRec(t, requestJoinRec)
-
-	// building request accept
-	requestAccept, err := ownerAcl.RecordBuilder().BuildRequestAccept(RequestAcceptPayload{
-		RequestRecordId: requestJoinRec.Id,
-		Permissions:     perms,
-	})
-	require.NoError(t, err)
-	// validate
-	err = ownerAcl.ValidateRawRecord(requestAccept)
-	require.NoError(t, err)
-	requestAcceptRec := WrapAclRecord(requestAccept)
-	fx.addRec(t, requestAcceptRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey).CanWrite())
-	require.Equal(t, 0, len(ownerState.pendingRequests))
-	require.Equal(t, 0, len(accountState.pendingRequests))
-	require.True(t, accountState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, accountState.Permissions(accountState.pubKey).CanWrite())
-
-	_, err = ownerState.StateAtRecord(requestJoinRec.Id, accountState.pubKey)
-	require.Equal(t, ErrNoSuchAccount, err)
-	stateAtRec, err := ownerState.StateAtRecord(requestAcceptRec.Id, accountState.pubKey)
-	require.NoError(t, err)
-	require.True(t, stateAtRec.Permissions == perms)
-}
-
 func TestAclList_BuildRoot(t *testing.T) {
 	randomKeys, err := accountdata.NewRandom()
 	require.NoError(t, err)
@@ -101,193 +14,3 @@ func TestAclList_BuildRoot(t *testing.T) {
 	require.NoError(t, err)
 	fmt.Println(randomAcl.Id())
 }
-
-func TestAclList_InvitePipeline(t *testing.T) {
-	fx := newFixture(t)
-	fx.inviteAccount(t, AclPermissions(aclrecordproto.AclUserPermissions_Writer))
-}
-
-func TestAclList_InviteRevoke(t *testing.T) {
-	fx := newFixture(t)
-	var (
-		ownerState   = fx.ownerAcl.aclState
-		accountState = fx.accountAcl.aclState
-	)
-	// building invite
-	inv, err := fx.ownerAcl.RecordBuilder().BuildInvite()
-	require.NoError(t, err)
-	inviteRec := WrapAclRecord(inv.InviteRec)
-	fx.addRec(t, inviteRec)
-
-	// building invite revoke
-	inviteRevoke, err := fx.ownerAcl.RecordBuilder().BuildInviteRevoke(ownerState.lastRecordId)
-	require.NoError(t, err)
-	inviteRevokeRec := WrapAclRecord(inviteRevoke)
-	fx.addRec(t, inviteRevokeRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey).NoPermissions())
-	require.Empty(t, ownerState.inviteKeys)
-	require.Empty(t, accountState.inviteKeys)
-}
-
-func TestAclList_RequestDecline(t *testing.T) {
-	fx := newFixture(t)
-	var (
-		ownerAcl     = fx.ownerAcl
-		ownerState   = fx.ownerAcl.aclState
-		accountAcl   = fx.accountAcl
-		accountState = fx.accountAcl.aclState
-	)
-	// building invite
-	inv, err := ownerAcl.RecordBuilder().BuildInvite()
-	require.NoError(t, err)
-	inviteRec := WrapAclRecord(inv.InviteRec)
-	fx.addRec(t, inviteRec)
-
-	// building request join
-	requestJoin, err := accountAcl.RecordBuilder().BuildRequestJoin(RequestJoinPayload{
-		InviteRecordId: inviteRec.Id,
-		InviteKey:      inv.InviteKey,
-	})
-	require.NoError(t, err)
-	requestJoinRec := WrapAclRecord(requestJoin)
-	fx.addRec(t, requestJoinRec)
-
-	// building request decline
-	requestDecline, err := ownerAcl.RecordBuilder().BuildRequestDecline(ownerState.lastRecordId)
-	require.NoError(t, err)
-	requestDeclineRec := WrapAclRecord(requestDecline)
-	fx.addRec(t, requestDeclineRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey).NoPermissions())
-	require.Empty(t, ownerState.pendingRequests)
-	require.Empty(t, accountState.pendingRequests)
-}
-
-func TestAclList_Remove(t *testing.T) {
-	fx := newFixture(t)
-	var (
-		ownerState   = fx.ownerAcl.aclState
-		accountState = fx.accountAcl.aclState
-	)
-	fx.inviteAccount(t, AclPermissions(aclrecordproto.AclUserPermissions_Writer))
-
-	newReadKey := crypto.NewAES()
-	remove, err := fx.ownerAcl.RecordBuilder().BuildAccountRemove(AccountRemovePayload{
-		Identities: []crypto.PubKey{fx.accountKeys.SignKey.GetPublic()},
-		ReadKey:    newReadKey,
-	})
-	require.NoError(t, err)
-	removeRec := WrapAclRecord(remove)
-	fx.addRec(t, removeRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey).NoPermissions())
-	require.True(t, ownerState.userReadKeys[removeRec.Id].Equals(newReadKey))
-	require.NotNil(t, ownerState.userReadKeys[fx.ownerAcl.Id()])
-	require.Equal(t, 0, len(ownerState.pendingRequests))
-	require.Equal(t, 0, len(accountState.pendingRequests))
-	require.True(t, accountState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, accountState.Permissions(accountState.pubKey).NoPermissions())
-	require.Nil(t, accountState.userReadKeys[removeRec.Id])
-	require.NotNil(t, accountState.userReadKeys[fx.ownerAcl.Id()])
-}
-
-func TestAclList_ReadKeyChange(t *testing.T) {
-	fx := newFixture(t)
-	var (
-		ownerState   = fx.ownerAcl.aclState
-		accountState = fx.accountAcl.aclState
-	)
-	fx.inviteAccount(t, AclPermissions(aclrecordproto.AclUserPermissions_Admin))
-
-	newReadKey := crypto.NewAES()
-	readKeyChange, err := fx.ownerAcl.RecordBuilder().BuildReadKeyChange(newReadKey)
-	require.NoError(t, err)
-	readKeyRec := WrapAclRecord(readKeyChange)
-	fx.addRec(t, readKeyRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey).CanManageAccounts())
-	require.True(t, ownerState.userReadKeys[readKeyRec.Id].Equals(newReadKey))
-	require.True(t, accountState.userReadKeys[readKeyRec.Id].Equals(newReadKey))
-	require.NotNil(t, ownerState.userReadKeys[fx.ownerAcl.Id()])
-	require.NotNil(t, accountState.userReadKeys[fx.ownerAcl.Id()])
-	readKey, err := ownerState.CurrentReadKey()
-	require.NoError(t, err)
-	require.True(t, newReadKey.Equals(readKey))
-	require.Equal(t, 0, len(ownerState.pendingRequests))
-	require.Equal(t, 0, len(accountState.pendingRequests))
-}
-
-func TestAclList_PermissionChange(t *testing.T) {
-	fx := newFixture(t)
-	var (
-		ownerState   = fx.ownerAcl.aclState
-		accountState = fx.accountAcl.aclState
-	)
-	fx.inviteAccount(t, AclPermissions(aclrecordproto.AclUserPermissions_Admin))
-
-	permissionChange, err := fx.ownerAcl.RecordBuilder().BuildPermissionChange(PermissionChangePayload{
-		Identity:    fx.accountKeys.SignKey.GetPublic(),
-		Permissions: AclPermissions(aclrecordproto.AclUserPermissions_Writer),
-	})
-	require.NoError(t, err)
-	permissionChangeRec := WrapAclRecord(permissionChange)
-	fx.addRec(t, permissionChangeRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey) == AclPermissions(aclrecordproto.AclUserPermissions_Writer))
-	require.True(t, accountState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, accountState.Permissions(accountState.pubKey) == AclPermissions(aclrecordproto.AclUserPermissions_Writer))
-	require.NotNil(t, ownerState.userReadKeys[fx.ownerAcl.Id()])
-	require.NotNil(t, accountState.userReadKeys[fx.ownerAcl.Id()])
-	require.Equal(t, 0, len(ownerState.pendingRequests))
-	require.Equal(t, 0, len(accountState.pendingRequests))
-}
-
-func TestAclList_RequestRemove(t *testing.T) {
-	fx := newFixture(t)
-	var (
-		ownerState   = fx.ownerAcl.aclState
-		accountState = fx.accountAcl.aclState
-	)
-	fx.inviteAccount(t, AclPermissions(aclrecordproto.AclUserPermissions_Writer))
-
-	removeRequest, err := fx.accountAcl.RecordBuilder().BuildRequestRemove()
-	require.NoError(t, err)
-	removeRequestRec := WrapAclRecord(removeRequest)
-	fx.addRec(t, removeRequestRec)
-
-	recs := fx.accountAcl.AclState().RemoveRecords()
-	require.Len(t, recs, 1)
-	require.True(t, accountState.pubKey.Equals(recs[0].RequestIdentity))
-
-	newReadKey := crypto.NewAES()
-	remove, err := fx.ownerAcl.RecordBuilder().BuildAccountRemove(AccountRemovePayload{
-		Identities: []crypto.PubKey{recs[0].RequestIdentity},
-		ReadKey:    newReadKey,
-	})
-	require.NoError(t, err)
-	removeRec := WrapAclRecord(remove)
-	fx.addRec(t, removeRec)
-
-	// checking acl state
-	require.True(t, ownerState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, ownerState.Permissions(accountState.pubKey).NoPermissions())
-	require.True(t, ownerState.userReadKeys[removeRec.Id].Equals(newReadKey))
-	require.NotNil(t, ownerState.userReadKeys[fx.ownerAcl.Id()])
-	require.Equal(t, 0, len(ownerState.pendingRequests))
-	require.Equal(t, 0, len(accountState.pendingRequests))
-	require.True(t, accountState.Permissions(ownerState.pubKey).IsOwner())
-	require.True(t, accountState.Permissions(accountState.pubKey).NoPermissions())
-	require.Nil(t, accountState.userReadKeys[removeRec.Id])
-	require.NotNil(t, accountState.userReadKeys[fx.ownerAcl.Id()])
-}

commonspace/object/acl/list/listutils.go

@@ -2,13 +2,13 @@ package list
 
 import (
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/liststorage"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/util/crypto"
 )
 
 func NewTestDerivedAcl(spaceId string, keys *accountdata.AccountKeys) (AclList, error) {
-	builder := NewAclRecordBuilder("", crypto.NewKeyStorage(), keys, NoOpAcceptorVerifier{})
+	builder := NewAclRecordBuilder("", crypto.NewKeyStorage())
 	masterKey, _, err := crypto.GenerateRandomEd25519KeyPair()
 	if err != nil {
 		return nil, err
@@ -21,21 +21,11 @@ func NewTestDerivedAcl(spaceId string, keys *accountdata.AccountKeys) (AclList,
 	if err != nil {
 		return nil, err
 	}
-	st, err := liststorage.NewInMemoryAclListStorage(root.Id, []*consensusproto.RawRecordWithId{
+	st, err := liststorage.NewInMemoryAclListStorage(root.Id, []*aclrecordproto.RawAclRecordWithId{
 		root,
 	})
 	if err != nil {
 		return nil, err
 	}
-	return BuildAclListWithIdentity(keys, st, NoOpAcceptorVerifier{})
-}
-
-func NewTestAclWithRoot(keys *accountdata.AccountKeys, root *consensusproto.RawRecordWithId) (AclList, error) {
-	st, err := liststorage.NewInMemoryAclListStorage(root.Id, []*consensusproto.RawRecordWithId{
-		root,
-	})
-	if err != nil {
-		return nil, err
-	}
-	return BuildAclListWithIdentity(keys, st, NoOpAcceptorVerifier{})
+	return BuildAclListWithIdentity(keys, st)
 }

commonspace/object/acl/list/mock_list/mock_list.go

@@ -5,13 +5,12 @@
 package mock_list
 
 import (
-	context "context"
 	reflect "reflect"
 
+	aclrecordproto "github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	list "github.com/anyproto/any-sync/commonspace/object/acl/list"
-	consensusproto "github.com/anyproto/any-sync/consensus/consensusproto"
 	crypto "github.com/anyproto/any-sync/util/crypto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockAclList is a mock of AclList interface.
@@ -52,11 +51,12 @@ func (mr *MockAclListMockRecorder) AclState() *gomock.Call {
 }
 
 // AddRawRecord mocks base method.
-func (m *MockAclList) AddRawRecord(arg0 *consensusproto.RawRecordWithId) error {
+func (m *MockAclList) AddRawRecord(arg0 *aclrecordproto.RawAclRecordWithId) (bool, error) {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "AddRawRecord", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
+	ret0, _ := ret[0].(bool)
+	ret1, _ := ret[1].(error)
+	return ret0, ret1
 }
 
 // AddRawRecord indicates an expected call of AddRawRecord.
@@ -65,32 +65,18 @@ func (mr *MockAclListMockRecorder) AddRawRecord(arg0 interface{}) *gomock.Call {
 	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddRawRecord", reflect.TypeOf((*MockAclList)(nil).AddRawRecord), arg0)
 }
 
-// AddRawRecords mocks base method.
-func (m *MockAclList) AddRawRecords(arg0 []*consensusproto.RawRecordWithId) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AddRawRecords", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// AddRawRecords indicates an expected call of AddRawRecords.
-func (mr *MockAclListMockRecorder) AddRawRecords(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddRawRecords", reflect.TypeOf((*MockAclList)(nil).AddRawRecords), arg0)
-}
-
 // Close mocks base method.
-func (m *MockAclList) Close(arg0 context.Context) error {
+func (m *MockAclList) Close() error {
 	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Close", arg0)
+	ret := m.ctrl.Call(m, "Close")
 	ret0, _ := ret[0].(error)
 	return ret0
 }
 
 // Close indicates an expected call of Close.
-func (mr *MockAclListMockRecorder) Close(arg0 interface{}) *gomock.Call {
+func (mr *MockAclListMockRecorder) Close() *gomock.Call {
 	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Close", reflect.TypeOf((*MockAclList)(nil).Close), arg0)
+	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Close", reflect.TypeOf((*MockAclList)(nil).Close))
 }
 
 // Get mocks base method.
@@ -108,35 +94,6 @@ func (mr *MockAclListMockRecorder) Get(arg0 interface{}) *gomock.Call {
 	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Get", reflect.TypeOf((*MockAclList)(nil).Get), arg0)
 }
 
-// GetIndex mocks base method.
-func (m *MockAclList) GetIndex(arg0 int) (*list.AclRecord, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "GetIndex", arg0)
-	ret0, _ := ret[0].(*list.AclRecord)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// GetIndex indicates an expected call of GetIndex.
-func (mr *MockAclListMockRecorder) GetIndex(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "GetIndex", reflect.TypeOf((*MockAclList)(nil).GetIndex), arg0)
-}
-
-// HasHead mocks base method.
-func (m *MockAclList) HasHead(arg0 string) bool {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "HasHead", arg0)
-	ret0, _ := ret[0].(bool)
-	return ret0
-}
-
-// HasHead indicates an expected call of HasHead.
-func (mr *MockAclListMockRecorder) HasHead(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "HasHead", reflect.TypeOf((*MockAclList)(nil).HasHead), arg0)
-}
-
 // Head mocks base method.
 func (m *MockAclList) Head() *list.AclRecord {
 	m.ctrl.T.Helper()
@@ -254,20 +211,6 @@ func (mr *MockAclListMockRecorder) RUnlock() *gomock.Call {
 	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RUnlock", reflect.TypeOf((*MockAclList)(nil).RUnlock))
 }
 
-// RecordBuilder mocks base method.
-func (m *MockAclList) RecordBuilder() list.AclRecordBuilder {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "RecordBuilder")
-	ret0, _ := ret[0].(list.AclRecordBuilder)
-	return ret0
-}
-
-// RecordBuilder indicates an expected call of RecordBuilder.
-func (mr *MockAclListMockRecorder) RecordBuilder() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RecordBuilder", reflect.TypeOf((*MockAclList)(nil).RecordBuilder))
-}
-
 // Records mocks base method.
 func (m *MockAclList) Records() []*list.AclRecord {
 	m.ctrl.T.Helper()
@@ -282,41 +225,11 @@ func (mr *MockAclListMockRecorder) Records() *gomock.Call {
 	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Records", reflect.TypeOf((*MockAclList)(nil).Records))
 }
 
-// RecordsAfter mocks base method.
-func (m *MockAclList) RecordsAfter(arg0 context.Context, arg1 string) ([]*consensusproto.RawRecordWithId, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "RecordsAfter", arg0, arg1)
-	ret0, _ := ret[0].([]*consensusproto.RawRecordWithId)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// RecordsAfter indicates an expected call of RecordsAfter.
-func (mr *MockAclListMockRecorder) RecordsAfter(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RecordsAfter", reflect.TypeOf((*MockAclList)(nil).RecordsAfter), arg0, arg1)
-}
-
-// RecordsBefore mocks base method.
-func (m *MockAclList) RecordsBefore(arg0 context.Context, arg1 string) ([]*consensusproto.RawRecordWithId, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "RecordsBefore", arg0, arg1)
-	ret0, _ := ret[0].([]*consensusproto.RawRecordWithId)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// RecordsBefore indicates an expected call of RecordsBefore.
-func (mr *MockAclListMockRecorder) RecordsBefore(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RecordsBefore", reflect.TypeOf((*MockAclList)(nil).RecordsBefore), arg0, arg1)
-}
-
 // Root mocks base method.
-func (m *MockAclList) Root() *consensusproto.RawRecordWithId {
+func (m *MockAclList) Root() *aclrecordproto.RawAclRecordWithId {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "Root")
-	ret0, _ := ret[0].(*consensusproto.RawRecordWithId)
+	ret0, _ := ret[0].(*aclrecordproto.RawAclRecordWithId)
 	return ret0
 }
 
@@ -337,17 +250,3 @@ func (mr *MockAclListMockRecorder) Unlock() *gomock.Call {
 	mr.mock.ctrl.T.Helper()
 	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Unlock", reflect.TypeOf((*MockAclList)(nil).Unlock))
 }
-
-// ValidateRawRecord mocks base method.
-func (m *MockAclList) ValidateRawRecord(arg0 *consensusproto.RawRecord) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "ValidateRawRecord", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// ValidateRawRecord indicates an expected call of ValidateRawRecord.
-func (mr *MockAclListMockRecorder) ValidateRawRecord(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ValidateRawRecord", reflect.TypeOf((*MockAclList)(nil).ValidateRawRecord), arg0)
-}

commonspace/object/acl/list/models.go

@@ -8,6 +8,7 @@ import (
 type AclRecord struct {
 	Id        string
 	PrevId    string
+	ReadKeyId string
 	Timestamp int64
 	Data      []byte
 	Identity  crypto.PubKey
@@ -15,55 +16,7 @@ type AclRecord struct {
 	Signature []byte
 }
 
-type RequestRecord struct {
-	RequestIdentity crypto.PubKey
-	RequestMetadata []byte
-	Type            RequestType
-}
-
 type AclUserState struct {
-	PubKey          crypto.PubKey
-	Permissions     AclPermissions
-	RequestMetadata []byte
-}
-
-type RequestType int
-
-const (
-	RequestTypeRemove RequestType = iota
-	RequestTypeJoin
-)
-
-type AclPermissions aclrecordproto.AclUserPermissions
-
-func (p AclPermissions) NoPermissions() bool {
-	return aclrecordproto.AclUserPermissions(p) == aclrecordproto.AclUserPermissions_None
-}
-
-func (p AclPermissions) IsOwner() bool {
-	return aclrecordproto.AclUserPermissions(p) == aclrecordproto.AclUserPermissions_Owner
-}
-
-func (p AclPermissions) CanWrite() bool {
-	switch aclrecordproto.AclUserPermissions(p) {
-	case aclrecordproto.AclUserPermissions_Admin:
-		return true
-	case aclrecordproto.AclUserPermissions_Writer:
-		return true
-	case aclrecordproto.AclUserPermissions_Owner:
-		return true
-	default:
-		return false
-	}
-}
-
-func (p AclPermissions) CanManageAccounts() bool {
-	switch aclrecordproto.AclUserPermissions(p) {
-	case aclrecordproto.AclUserPermissions_Admin:
-		return true
-	case aclrecordproto.AclUserPermissions_Owner:
-		return true
-	default:
-		return false
-	}
+	PubKey      crypto.PubKey
+	Permissions aclrecordproto.AclUserPermissions
 }

commonspace/object/acl/list/validator.go

@@ -1,218 +0,0 @@
-package list
-
-import (
-	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
-	"github.com/anyproto/any-sync/util/crypto"
-)
-
-type ContentValidator interface {
-	ValidateAclRecordContents(ch *AclRecord) (err error)
-	ValidatePermissionChange(ch *aclrecordproto.AclAccountPermissionChange, authorIdentity crypto.PubKey) (err error)
-	ValidateInvite(ch *aclrecordproto.AclAccountInvite, authorIdentity crypto.PubKey) (err error)
-	ValidateInviteRevoke(ch *aclrecordproto.AclAccountInviteRevoke, authorIdentity crypto.PubKey) (err error)
-	ValidateRequestJoin(ch *aclrecordproto.AclAccountRequestJoin, authorIdentity crypto.PubKey) (err error)
-	ValidateRequestAccept(ch *aclrecordproto.AclAccountRequestAccept, authorIdentity crypto.PubKey) (err error)
-	ValidateRequestDecline(ch *aclrecordproto.AclAccountRequestDecline, authorIdentity crypto.PubKey) (err error)
-	ValidateAccountRemove(ch *aclrecordproto.AclAccountRemove, authorIdentity crypto.PubKey) (err error)
-	ValidateRequestRemove(ch *aclrecordproto.AclAccountRequestRemove, authorIdentity crypto.PubKey) (err error)
-	ValidateReadKeyChange(ch *aclrecordproto.AclReadKeyChange, authorIdentity crypto.PubKey) (err error)
-}
-
-type contentValidator struct {
-	keyStore crypto.KeyStorage
-	aclState *AclState
-}
-
-func (c *contentValidator) ValidateAclRecordContents(ch *AclRecord) (err error) {
-	if ch.PrevId != c.aclState.lastRecordId {
-		return ErrIncorrectRecordSequence
-	}
-	aclData := ch.Model.(*aclrecordproto.AclData)
-	for _, content := range aclData.AclContent {
-		err = c.validateAclRecordContent(content, ch.Identity)
-		if err != nil {
-			return
-		}
-	}
-	return
-}
-
-func (c *contentValidator) validateAclRecordContent(ch *aclrecordproto.AclContentValue, authorIdentity crypto.PubKey) (err error) {
-	switch {
-	case ch.GetPermissionChange() != nil:
-		return c.ValidatePermissionChange(ch.GetPermissionChange(), authorIdentity)
-	case ch.GetInvite() != nil:
-		return c.ValidateInvite(ch.GetInvite(), authorIdentity)
-	case ch.GetInviteRevoke() != nil:
-		return c.ValidateInviteRevoke(ch.GetInviteRevoke(), authorIdentity)
-	case ch.GetRequestJoin() != nil:
-		return c.ValidateRequestJoin(ch.GetRequestJoin(), authorIdentity)
-	case ch.GetRequestAccept() != nil:
-		return c.ValidateRequestAccept(ch.GetRequestAccept(), authorIdentity)
-	case ch.GetRequestDecline() != nil:
-		return c.ValidateRequestDecline(ch.GetRequestDecline(), authorIdentity)
-	case ch.GetAccountRemove() != nil:
-		return c.ValidateAccountRemove(ch.GetAccountRemove(), authorIdentity)
-	case ch.GetAccountRequestRemove() != nil:
-		return c.ValidateRequestRemove(ch.GetAccountRequestRemove(), authorIdentity)
-	case ch.GetReadKeyChange() != nil:
-		return c.ValidateReadKeyChange(ch.GetReadKeyChange(), authorIdentity)
-	default:
-		return ErrUnexpectedContentType
-	}
-}
-
-func (c *contentValidator) ValidatePermissionChange(ch *aclrecordproto.AclAccountPermissionChange, authorIdentity crypto.PubKey) (err error) {
-	if !c.aclState.Permissions(authorIdentity).CanManageAccounts() {
-		return ErrInsufficientPermissions
-	}
-	chIdentity, err := c.keyStore.PubKeyFromProto(ch.Identity)
-	if err != nil {
-		return err
-	}
-	_, exists := c.aclState.userStates[mapKeyFromPubKey(chIdentity)]
-	if !exists {
-		return ErrNoSuchAccount
-	}
-	return
-}
-
-func (c *contentValidator) ValidateInvite(ch *aclrecordproto.AclAccountInvite, authorIdentity crypto.PubKey) (err error) {
-	if !c.aclState.Permissions(authorIdentity).CanManageAccounts() {
-		return ErrInsufficientPermissions
-	}
-	_, err = c.keyStore.PubKeyFromProto(ch.InviteKey)
-	return
-}
-
-func (c *contentValidator) ValidateInviteRevoke(ch *aclrecordproto.AclAccountInviteRevoke, authorIdentity crypto.PubKey) (err error) {
-	if !c.aclState.Permissions(authorIdentity).CanManageAccounts() {
-		return ErrInsufficientPermissions
-	}
-	_, exists := c.aclState.inviteKeys[ch.InviteRecordId]
-	if !exists {
-		return ErrNoSuchInvite
-	}
-	return
-}
-
-func (c *contentValidator) ValidateRequestJoin(ch *aclrecordproto.AclAccountRequestJoin, authorIdentity crypto.PubKey) (err error) {
-	inviteKey, exists := c.aclState.inviteKeys[ch.InviteRecordId]
-	if !exists {
-		return ErrNoSuchInvite
-	}
-	inviteIdentity, err := c.keyStore.PubKeyFromProto(ch.InviteIdentity)
-	if err != nil {
-		return
-	}
-	if _, exists := c.aclState.pendingRequests[mapKeyFromPubKey(inviteIdentity)]; exists {
-		return ErrPendingRequest
-	}
-	if !authorIdentity.Equals(inviteIdentity) {
-		return ErrIncorrectIdentity
-	}
-	rawInviteIdentity, err := inviteIdentity.Raw()
-	if err != nil {
-		return err
-	}
-	ok, err := inviteKey.Verify(rawInviteIdentity, ch.InviteIdentitySignature)
-	if err != nil {
-		return ErrInvalidSignature
-	}
-	if !ok {
-		return ErrInvalidSignature
-	}
-	return
-}
-
-func (c *contentValidator) ValidateRequestAccept(ch *aclrecordproto.AclAccountRequestAccept, authorIdentity crypto.PubKey) (err error) {
-	if !c.aclState.Permissions(authorIdentity).CanManageAccounts() {
-		return ErrInsufficientPermissions
-	}
-	record, exists := c.aclState.requestRecords[ch.RequestRecordId]
-	if !exists {
-		return ErrNoSuchRequest
-	}
-	acceptIdentity, err := c.keyStore.PubKeyFromProto(ch.Identity)
-	if err != nil {
-		return
-	}
-	if !acceptIdentity.Equals(record.RequestIdentity) {
-		return ErrIncorrectIdentity
-	}
-	if ch.Permissions == aclrecordproto.AclUserPermissions_Owner {
-		return ErrInsufficientPermissions
-	}
-	return
-}
-
-func (c *contentValidator) ValidateRequestDecline(ch *aclrecordproto.AclAccountRequestDecline, authorIdentity crypto.PubKey) (err error) {
-	if !c.aclState.Permissions(authorIdentity).CanManageAccounts() {
-		return ErrInsufficientPermissions
-	}
-	_, exists := c.aclState.requestRecords[ch.RequestRecordId]
-	if !exists {
-		return ErrNoSuchRequest
-	}
-	return
-}
-
-func (c *contentValidator) ValidateAccountRemove(ch *aclrecordproto.AclAccountRemove, authorIdentity crypto.PubKey) (err error) {
-	if !c.aclState.Permissions(authorIdentity).CanManageAccounts() {
-		return ErrInsufficientPermissions
-	}
-	seenIdentities := map[string]struct{}{}
-	for _, rawIdentity := range ch.Identities {
-		identity, err := c.keyStore.PubKeyFromProto(rawIdentity)
-		if err != nil {
-			return err
-		}
-		if identity.Equals(authorIdentity) {
-			return ErrInsufficientPermissions
-		}
-		permissions := c.aclState.Permissions(identity)
-		if permissions.NoPermissions() {
-			return ErrNoSuchAccount
-		}
-		if permissions.IsOwner() {
-			return ErrInsufficientPermissions
-		}
-		idKey := mapKeyFromPubKey(identity)
-		if _, exists := seenIdentities[idKey]; exists {
-			return ErrDuplicateAccounts
-		}
-		seenIdentities[mapKeyFromPubKey(identity)] = struct{}{}
-	}
-	return c.validateAccountReadKeys(ch.AccountKeys, len(c.aclState.userStates)-len(ch.Identities))
-}
-
-func (c *contentValidator) ValidateRequestRemove(ch *aclrecordproto.AclAccountRequestRemove, authorIdentity crypto.PubKey) (err error) {
-	if c.aclState.Permissions(authorIdentity).NoPermissions() {
-		return ErrInsufficientPermissions
-	}
-	if _, exists := c.aclState.pendingRequests[mapKeyFromPubKey(authorIdentity)]; exists {
-		return ErrPendingRequest
-	}
-	return
-}
-
-func (c *contentValidator) ValidateReadKeyChange(ch *aclrecordproto.AclReadKeyChange, authorIdentity crypto.PubKey) (err error) {
-	return c.validateAccountReadKeys(ch.AccountKeys, len(c.aclState.userStates))
-}
-
-func (c *contentValidator) validateAccountReadKeys(accountKeys []*aclrecordproto.AclEncryptedReadKey, usersNum int) (err error) {
-	if len(accountKeys) != usersNum {
-		return ErrIncorrectNumberOfAccounts
-	}
-	for _, encKeys := range accountKeys {
-		identity, err := c.keyStore.PubKeyFromProto(encKeys.Identity)
-		if err != nil {
-			return err
-		}
-		_, exists := c.aclState.userStates[mapKeyFromPubKey(identity)]
-		if !exists {
-			return ErrNoSuchAccount
-		}
-	}
-	return
-}

commonspace/object/acl/liststorage/inmemory.go

@@ -3,26 +3,24 @@ package liststorage
 import (
 	"context"
 	"fmt"
-
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"sync"
 )
 
 type inMemoryAclListStorage struct {
 	id      string
-	root    *consensusproto.RawRecordWithId
+	root    *aclrecordproto.RawAclRecordWithId
 	head    string
-	records map[string]*consensusproto.RawRecordWithId
+	records map[string]*aclrecordproto.RawAclRecordWithId
 
 	sync.RWMutex
 }
 
 func NewInMemoryAclListStorage(
 	id string,
-	records []*consensusproto.RawRecordWithId) (ListStorage, error) {
+	records []*aclrecordproto.RawAclRecordWithId) (ListStorage, error) {
 
-	allRecords := make(map[string]*consensusproto.RawRecordWithId)
+	allRecords := make(map[string]*aclrecordproto.RawAclRecordWithId)
 	for _, ch := range records {
 		allRecords[ch.Id] = ch
 	}
@@ -43,7 +41,7 @@ func (t *inMemoryAclListStorage) Id() string {
 	return t.id
 }
 
-func (t *inMemoryAclListStorage) Root() (*consensusproto.RawRecordWithId, error) {
+func (t *inMemoryAclListStorage) Root() (*aclrecordproto.RawAclRecordWithId, error) {
 	t.RLock()
 	defer t.RUnlock()
 	return t.root, nil
@@ -62,7 +60,7 @@ func (t *inMemoryAclListStorage) SetHead(head string) error {
 	return nil
 }
 
-func (t *inMemoryAclListStorage) AddRawRecord(ctx context.Context, record *consensusproto.RawRecordWithId) error {
+func (t *inMemoryAclListStorage) AddRawRecord(ctx context.Context, record *aclrecordproto.RawAclRecordWithId) error {
 	t.Lock()
 	defer t.Unlock()
 	// TODO: better to do deep copy
@@ -70,7 +68,7 @@ func (t *inMemoryAclListStorage) AddRawRecord(ctx context.Context, record *conse
 	return nil
 }
 
-func (t *inMemoryAclListStorage) GetRawRecord(ctx context.Context, recordId string) (*consensusproto.RawRecordWithId, error) {
+func (t *inMemoryAclListStorage) GetRawRecord(ctx context.Context, recordId string) (*aclrecordproto.RawAclRecordWithId, error) {
 	t.RLock()
 	defer t.RUnlock()
 	if res, exists := t.records[recordId]; exists {

commonspace/object/acl/liststorage/liststorage.go

@@ -4,8 +4,7 @@ package liststorage
 import (
 	"context"
 	"errors"
-
-	"github.com/anyproto/any-sync/consensus/consensusproto"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 )
 
 var (
@@ -15,15 +14,15 @@ var (
 )
 
 type Exporter interface {
-	ListStorage(root *consensusproto.RawRecordWithId) (ListStorage, error)
+	ListStorage(root *aclrecordproto.RawAclRecordWithId) (ListStorage, error)
 }
 
 type ListStorage interface {
 	Id() string
-	Root() (*consensusproto.RawRecordWithId, error)
+	Root() (*aclrecordproto.RawAclRecordWithId, error)
 	Head() (string, error)
 	SetHead(headId string) error
 
-	GetRawRecord(ctx context.Context, id string) (*consensusproto.RawRecordWithId, error)
-	AddRawRecord(ctx context.Context, rec *consensusproto.RawRecordWithId) error
+	GetRawRecord(ctx context.Context, id string) (*aclrecordproto.RawAclRecordWithId, error)
+	AddRawRecord(ctx context.Context, rec *aclrecordproto.RawAclRecordWithId) error
 }

commonspace/object/acl/liststorage/mock_liststorage/mock_liststorage.go

@@ -8,8 +8,8 @@ import (
 	context "context"
 	reflect "reflect"
 
-	consensusproto "github.com/anyproto/any-sync/consensus/consensusproto"
-	gomock "go.uber.org/mock/gomock"
+	aclrecordproto "github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockListStorage is a mock of ListStorage interface.
@@ -36,7 +36,7 @@ func (m *MockListStorage) EXPECT() *MockListStorageMockRecorder {
 }
 
 // AddRawRecord mocks base method.
-func (m *MockListStorage) AddRawRecord(arg0 context.Context, arg1 *consensusproto.RawRecordWithId) error {
+func (m *MockListStorage) AddRawRecord(arg0 context.Context, arg1 *aclrecordproto.RawAclRecordWithId) error {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "AddRawRecord", arg0, arg1)
 	ret0, _ := ret[0].(error)
@@ -50,10 +50,10 @@ func (mr *MockListStorageMockRecorder) AddRawRecord(arg0, arg1 interface{}) *gom
 }
 
 // GetRawRecord mocks base method.
-func (m *MockListStorage) GetRawRecord(arg0 context.Context, arg1 string) (*consensusproto.RawRecordWithId, error) {
+func (m *MockListStorage) GetRawRecord(arg0 context.Context, arg1 string) (*aclrecordproto.RawAclRecordWithId, error) {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "GetRawRecord", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.RawRecordWithId)
+	ret0, _ := ret[0].(*aclrecordproto.RawAclRecordWithId)
 	ret1, _ := ret[1].(error)
 	return ret0, ret1
 }
@@ -94,10 +94,10 @@ func (mr *MockListStorageMockRecorder) Id() *gomock.Call {
 }
 
 // Root mocks base method.
-func (m *MockListStorage) Root() (*consensusproto.RawRecordWithId, error) {
+func (m *MockListStorage) Root() (*aclrecordproto.RawAclRecordWithId, error) {
 	m.ctrl.T.Helper()
 	ret := m.ctrl.Call(m, "Root")
-	ret0, _ := ret[0].(*consensusproto.RawRecordWithId)
+	ret0, _ := ret[0].(*aclrecordproto.RawAclRecordWithId)
 	ret1, _ := ret[1].(error)
 	return ret0, ret1
 }

commonspace/object/acl/syncacl/aclsyncprotocol.go

@@ -1,120 +0,0 @@
-//go:generate mockgen -destination mock_syncacl/mock_syncacl.go github.com/anyproto/any-sync/commonspace/object/acl/syncacl SyncAcl,SyncClient,RequestFactory,AclSyncProtocol
-package syncacl
-
-import (
-	"context"
-
-	"github.com/anyproto/any-sync/app/logger"
-	"github.com/anyproto/any-sync/commonspace/object/acl/list"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"go.uber.org/zap"
-)
-
-type AclSyncProtocol interface {
-	HeadUpdate(ctx context.Context, senderId string, update *consensusproto.LogHeadUpdate) (request *consensusproto.LogSyncMessage, err error)
-	FullSyncRequest(ctx context.Context, senderId string, request *consensusproto.LogFullSyncRequest) (response *consensusproto.LogSyncMessage, err error)
-	FullSyncResponse(ctx context.Context, senderId string, response *consensusproto.LogFullSyncResponse) (err error)
-}
-
-type aclSyncProtocol struct {
-	log        logger.CtxLogger
-	spaceId    string
-	aclList    list.AclList
-	reqFactory RequestFactory
-}
-
-func (a *aclSyncProtocol) HeadUpdate(ctx context.Context, senderId string, update *consensusproto.LogHeadUpdate) (request *consensusproto.LogSyncMessage, err error) {
-	isEmptyUpdate := len(update.Records) == 0
-	log := a.log.With(
-		zap.String("senderId", senderId),
-		zap.String("update head", update.Head),
-		zap.Int("len(update records)", len(update.Records)))
-	log.DebugCtx(ctx, "received acl head update message")
-
-	defer func() {
-		if err != nil {
-			log.ErrorCtx(ctx, "acl head update finished with error", zap.Error(err))
-		} else if request != nil {
-			cnt := request.Content.GetFullSyncRequest()
-			log.DebugCtx(ctx, "returning acl full sync request", zap.String("request head", cnt.Head))
-		} else {
-			if !isEmptyUpdate {
-				log.DebugCtx(ctx, "acl head update finished correctly")
-			}
-		}
-	}()
-	if isEmptyUpdate {
-		headEquals := a.aclList.Head().Id == update.Head
-		log.DebugCtx(ctx, "is empty acl head update", zap.Bool("headEquals", headEquals))
-		if headEquals {
-			return
-		}
-		return a.reqFactory.CreateFullSyncRequest(a.aclList, update.Head)
-	}
-	if a.aclList.HasHead(update.Head) {
-		return
-	}
-	err = a.aclList.AddRawRecords(update.Records)
-	if err == list.ErrIncorrectRecordSequence {
-		return a.reqFactory.CreateFullSyncRequest(a.aclList, update.Head)
-	}
-	return
-}
-
-func (a *aclSyncProtocol) FullSyncRequest(ctx context.Context, senderId string, request *consensusproto.LogFullSyncRequest) (response *consensusproto.LogSyncMessage, err error) {
-	log := a.log.With(
-		zap.String("senderId", senderId),
-		zap.String("request head", request.Head),
-		zap.Int("len(request records)", len(request.Records)))
-	log.DebugCtx(ctx, "received acl full sync request message")
-
-	defer func() {
-		if err != nil {
-			log.ErrorCtx(ctx, "acl full sync request finished with error", zap.Error(err))
-		} else if response != nil {
-			cnt := response.Content.GetFullSyncResponse()
-			log.DebugCtx(ctx, "acl full sync response sent", zap.String("response head", cnt.Head), zap.Int("len(response records)", len(cnt.Records)))
-		}
-	}()
-	if !a.aclList.HasHead(request.Head) {
-		if len(request.Records) > 0 {
-			// in this case we can try to add some records
-			err = a.aclList.AddRawRecords(request.Records)
-			if err != nil {
-				return
-			}
-		} else {
-			// here it is impossible for us to do anything, we can't return records after head as defined in request, because we don't have it
-			return nil, list.ErrIncorrectRecordSequence
-		}
-	}
-	return a.reqFactory.CreateFullSyncResponse(a.aclList, request.Head)
-}
-
-func (a *aclSyncProtocol) FullSyncResponse(ctx context.Context, senderId string, response *consensusproto.LogFullSyncResponse) (err error) {
-	log := a.log.With(
-		zap.String("senderId", senderId),
-		zap.String("response head", response.Head),
-		zap.Int("len(response records)", len(response.Records)))
-	log.DebugCtx(ctx, "received acl full sync response message")
-	defer func() {
-		if err != nil {
-			log.ErrorCtx(ctx, "acl full sync response failed", zap.Error(err))
-		} else {
-			log.DebugCtx(ctx, "acl full sync response succeeded")
-		}
-	}()
-	if a.aclList.HasHead(response.Head) {
-		return
-	}
-	return a.aclList.AddRawRecords(response.Records)
-}
-
-func newAclSyncProtocol(spaceId string, aclList list.AclList, reqFactory RequestFactory) *aclSyncProtocol {
-	return &aclSyncProtocol{
-		log:        log.With(zap.String("spaceId", spaceId), zap.String("aclId", aclList.Id())),
-		spaceId:    spaceId,
-		aclList:    aclList,
-		reqFactory: reqFactory,
-	}
-}

commonspace/object/acl/syncacl/aclsyncprotocol_test.go

@@ -1,213 +0,0 @@
-package syncacl
-
-import (
-	"context"
-	"github.com/anyproto/any-sync/app/logger"
-	"github.com/anyproto/any-sync/commonspace/object/acl/list"
-	"github.com/anyproto/any-sync/commonspace/object/acl/list/mock_list"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl/mock_syncacl"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
-	"testing"
-)
-
-type aclSyncProtocolFixture struct {
-	log          logger.CtxLogger
-	spaceId      string
-	senderId     string
-	aclId        string
-	aclMock      *mock_list.MockAclList
-	reqFactory   *mock_syncacl.MockRequestFactory
-	ctrl         *gomock.Controller
-	syncProtocol AclSyncProtocol
-}
-
-func newSyncProtocolFixture(t *testing.T) *aclSyncProtocolFixture {
-	ctrl := gomock.NewController(t)
-	aclList := mock_list.NewMockAclList(ctrl)
-	spaceId := "spaceId"
-	reqFactory := mock_syncacl.NewMockRequestFactory(ctrl)
-	aclList.EXPECT().Id().Return("aclId")
-	syncProtocol := newAclSyncProtocol(spaceId, aclList, reqFactory)
-	return &aclSyncProtocolFixture{
-		log:          log,
-		spaceId:      spaceId,
-		senderId:     "senderId",
-		aclId:        "aclId",
-		aclMock:      aclList,
-		reqFactory:   reqFactory,
-		ctrl:         ctrl,
-		syncProtocol: syncProtocol,
-	}
-}
-
-func (fx *aclSyncProtocolFixture) stop() {
-	fx.ctrl.Finish()
-}
-
-func TestHeadUpdate(t *testing.T) {
-	ctx := context.Background()
-	fullRequest := &consensusproto.LogSyncMessage{
-		Content: &consensusproto.LogSyncContentValue{
-			Value: &consensusproto.LogSyncContentValue_FullSyncRequest{
-				FullSyncRequest: &consensusproto.LogFullSyncRequest{},
-			},
-		},
-	}
-	t.Run("head update non empty all heads added", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(false)
-		fx.aclMock.EXPECT().AddRawRecords(headUpdate.Records).Return(nil)
-		req, err := fx.syncProtocol.HeadUpdate(ctx, fx.senderId, headUpdate)
-		require.Nil(t, req)
-		require.NoError(t, err)
-	})
-	t.Run("head update results in full request", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(false)
-		fx.aclMock.EXPECT().AddRawRecords(headUpdate.Records).Return(list.ErrIncorrectRecordSequence)
-		fx.reqFactory.EXPECT().CreateFullSyncRequest(fx.aclMock, headUpdate.Head).Return(fullRequest, nil)
-		req, err := fx.syncProtocol.HeadUpdate(ctx, fx.senderId, headUpdate)
-		require.Equal(t, fullRequest, req)
-		require.NoError(t, err)
-	})
-	t.Run("head update old heads", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(true)
-		req, err := fx.syncProtocol.HeadUpdate(ctx, fx.senderId, headUpdate)
-		require.Nil(t, req)
-		require.NoError(t, err)
-	})
-	t.Run("head update empty equals", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head: "h1",
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().Head().Return(&list.AclRecord{Id: "h1"})
-		req, err := fx.syncProtocol.HeadUpdate(ctx, fx.senderId, headUpdate)
-		require.Nil(t, req)
-		require.NoError(t, err)
-	})
-	t.Run("head update empty results in full request", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head: "h1",
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().Head().Return(&list.AclRecord{Id: "h2"})
-		fx.reqFactory.EXPECT().CreateFullSyncRequest(fx.aclMock, headUpdate.Head).Return(fullRequest, nil)
-		req, err := fx.syncProtocol.HeadUpdate(ctx, fx.senderId, headUpdate)
-		require.Equal(t, fullRequest, req)
-		require.NoError(t, err)
-	})
-}
-
-func TestFullSyncRequest(t *testing.T) {
-	ctx := context.Background()
-	fullResponse := &consensusproto.LogSyncMessage{
-		Content: &consensusproto.LogSyncContentValue{
-			Value: &consensusproto.LogSyncContentValue_FullSyncResponse{
-				FullSyncResponse: &consensusproto.LogFullSyncResponse{},
-			},
-		},
-	}
-	t.Run("full sync request non empty all heads added", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullRequest := &consensusproto.LogFullSyncRequest{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(false)
-		fx.aclMock.EXPECT().AddRawRecords(fullRequest.Records).Return(nil)
-		fx.reqFactory.EXPECT().CreateFullSyncResponse(fx.aclMock, fullRequest.Head).Return(fullResponse, nil)
-		resp, err := fx.syncProtocol.FullSyncRequest(ctx, fx.senderId, fullRequest)
-		require.Equal(t, fullResponse, resp)
-		require.NoError(t, err)
-	})
-	t.Run("full sync request non empty head exists", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullRequest := &consensusproto.LogFullSyncRequest{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(true)
-		fx.reqFactory.EXPECT().CreateFullSyncResponse(fx.aclMock, fullRequest.Head).Return(fullResponse, nil)
-		resp, err := fx.syncProtocol.FullSyncRequest(ctx, fx.senderId, fullRequest)
-		require.Equal(t, fullResponse, resp)
-		require.NoError(t, err)
-	})
-	t.Run("full sync request empty head not exists", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		fullRequest := &consensusproto.LogFullSyncRequest{
-			Head: "h1",
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(false)
-		resp, err := fx.syncProtocol.FullSyncRequest(ctx, fx.senderId, fullRequest)
-		require.Nil(t, resp)
-		require.Error(t, list.ErrIncorrectRecordSequence, err)
-	})
-}
-
-func TestFullSyncResponse(t *testing.T) {
-	ctx := context.Background()
-	t.Run("full sync response no heads", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullResponse := &consensusproto.LogFullSyncResponse{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(false)
-		fx.aclMock.EXPECT().AddRawRecords(fullResponse.Records).Return(nil)
-		err := fx.syncProtocol.FullSyncResponse(ctx, fx.senderId, fullResponse)
-		require.NoError(t, err)
-	})
-	t.Run("full sync response has heads", func(t *testing.T) {
-		fx := newSyncProtocolFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullResponse := &consensusproto.LogFullSyncResponse{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.aclMock.EXPECT().HasHead("h1").Return(true)
-		err := fx.syncProtocol.FullSyncResponse(ctx, fx.senderId, fullResponse)
-		require.NoError(t, err)
-	})
-}

commonspace/object/acl/syncacl/headupdater/headupdater.go

@@ -1,5 +0,0 @@
-package headupdater
-
-type HeadUpdater interface {
-	UpdateHeads(id string, heads []string)
-}

commonspace/object/acl/syncacl/mock_syncacl/mock_syncacl.go

@@ -1,709 +0,0 @@
-// Code generated by MockGen. DO NOT EDIT.
-// Source: github.com/anyproto/any-sync/commonspace/object/acl/syncacl (interfaces: SyncAcl,SyncClient,RequestFactory,AclSyncProtocol)
-
-// Package mock_syncacl is a generated GoMock package.
-package mock_syncacl
-
-import (
-	context "context"
-	reflect "reflect"
-
-	app "github.com/anyproto/any-sync/app"
-	list "github.com/anyproto/any-sync/commonspace/object/acl/list"
-	headupdater "github.com/anyproto/any-sync/commonspace/object/acl/syncacl/headupdater"
-	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	consensusproto "github.com/anyproto/any-sync/consensus/consensusproto"
-	crypto "github.com/anyproto/any-sync/util/crypto"
-	gomock "go.uber.org/mock/gomock"
-)
-
-// MockSyncAcl is a mock of SyncAcl interface.
-type MockSyncAcl struct {
-	ctrl     *gomock.Controller
-	recorder *MockSyncAclMockRecorder
-}
-
-// MockSyncAclMockRecorder is the mock recorder for MockSyncAcl.
-type MockSyncAclMockRecorder struct {
-	mock *MockSyncAcl
-}
-
-// NewMockSyncAcl creates a new mock instance.
-func NewMockSyncAcl(ctrl *gomock.Controller) *MockSyncAcl {
-	mock := &MockSyncAcl{ctrl: ctrl}
-	mock.recorder = &MockSyncAclMockRecorder{mock}
-	return mock
-}
-
-// EXPECT returns an object that allows the caller to indicate expected use.
-func (m *MockSyncAcl) EXPECT() *MockSyncAclMockRecorder {
-	return m.recorder
-}
-
-// AclState mocks base method.
-func (m *MockSyncAcl) AclState() *list.AclState {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AclState")
-	ret0, _ := ret[0].(*list.AclState)
-	return ret0
-}
-
-// AclState indicates an expected call of AclState.
-func (mr *MockSyncAclMockRecorder) AclState() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AclState", reflect.TypeOf((*MockSyncAcl)(nil).AclState))
-}
-
-// AddRawRecord mocks base method.
-func (m *MockSyncAcl) AddRawRecord(arg0 *consensusproto.RawRecordWithId) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AddRawRecord", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// AddRawRecord indicates an expected call of AddRawRecord.
-func (mr *MockSyncAclMockRecorder) AddRawRecord(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddRawRecord", reflect.TypeOf((*MockSyncAcl)(nil).AddRawRecord), arg0)
-}
-
-// AddRawRecords mocks base method.
-func (m *MockSyncAcl) AddRawRecords(arg0 []*consensusproto.RawRecordWithId) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AddRawRecords", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// AddRawRecords indicates an expected call of AddRawRecords.
-func (mr *MockSyncAclMockRecorder) AddRawRecords(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddRawRecords", reflect.TypeOf((*MockSyncAcl)(nil).AddRawRecords), arg0)
-}
-
-// Close mocks base method.
-func (m *MockSyncAcl) Close(arg0 context.Context) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Close", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Close indicates an expected call of Close.
-func (mr *MockSyncAclMockRecorder) Close(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Close", reflect.TypeOf((*MockSyncAcl)(nil).Close), arg0)
-}
-
-// Get mocks base method.
-func (m *MockSyncAcl) Get(arg0 string) (*list.AclRecord, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Get", arg0)
-	ret0, _ := ret[0].(*list.AclRecord)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// Get indicates an expected call of Get.
-func (mr *MockSyncAclMockRecorder) Get(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Get", reflect.TypeOf((*MockSyncAcl)(nil).Get), arg0)
-}
-
-// GetIndex mocks base method.
-func (m *MockSyncAcl) GetIndex(arg0 int) (*list.AclRecord, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "GetIndex", arg0)
-	ret0, _ := ret[0].(*list.AclRecord)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// GetIndex indicates an expected call of GetIndex.
-func (mr *MockSyncAclMockRecorder) GetIndex(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "GetIndex", reflect.TypeOf((*MockSyncAcl)(nil).GetIndex), arg0)
-}
-
-// HandleMessage mocks base method.
-func (m *MockSyncAcl) HandleMessage(arg0 context.Context, arg1 string, arg2 *spacesyncproto.ObjectSyncMessage) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "HandleMessage", arg0, arg1, arg2)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// HandleMessage indicates an expected call of HandleMessage.
-func (mr *MockSyncAclMockRecorder) HandleMessage(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "HandleMessage", reflect.TypeOf((*MockSyncAcl)(nil).HandleMessage), arg0, arg1, arg2)
-}
-
-// HandleRequest mocks base method.
-func (m *MockSyncAcl) HandleRequest(arg0 context.Context, arg1 string, arg2 *spacesyncproto.ObjectSyncMessage) (*spacesyncproto.ObjectSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "HandleRequest", arg0, arg1, arg2)
-	ret0, _ := ret[0].(*spacesyncproto.ObjectSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// HandleRequest indicates an expected call of HandleRequest.
-func (mr *MockSyncAclMockRecorder) HandleRequest(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "HandleRequest", reflect.TypeOf((*MockSyncAcl)(nil).HandleRequest), arg0, arg1, arg2)
-}
-
-// HasHead mocks base method.
-func (m *MockSyncAcl) HasHead(arg0 string) bool {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "HasHead", arg0)
-	ret0, _ := ret[0].(bool)
-	return ret0
-}
-
-// HasHead indicates an expected call of HasHead.
-func (mr *MockSyncAclMockRecorder) HasHead(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "HasHead", reflect.TypeOf((*MockSyncAcl)(nil).HasHead), arg0)
-}
-
-// Head mocks base method.
-func (m *MockSyncAcl) Head() *list.AclRecord {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Head")
-	ret0, _ := ret[0].(*list.AclRecord)
-	return ret0
-}
-
-// Head indicates an expected call of Head.
-func (mr *MockSyncAclMockRecorder) Head() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Head", reflect.TypeOf((*MockSyncAcl)(nil).Head))
-}
-
-// Id mocks base method.
-func (m *MockSyncAcl) Id() string {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Id")
-	ret0, _ := ret[0].(string)
-	return ret0
-}
-
-// Id indicates an expected call of Id.
-func (mr *MockSyncAclMockRecorder) Id() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Id", reflect.TypeOf((*MockSyncAcl)(nil).Id))
-}
-
-// Init mocks base method.
-func (m *MockSyncAcl) Init(arg0 *app.App) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Init", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Init indicates an expected call of Init.
-func (mr *MockSyncAclMockRecorder) Init(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Init", reflect.TypeOf((*MockSyncAcl)(nil).Init), arg0)
-}
-
-// IsAfter mocks base method.
-func (m *MockSyncAcl) IsAfter(arg0, arg1 string) (bool, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "IsAfter", arg0, arg1)
-	ret0, _ := ret[0].(bool)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// IsAfter indicates an expected call of IsAfter.
-func (mr *MockSyncAclMockRecorder) IsAfter(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "IsAfter", reflect.TypeOf((*MockSyncAcl)(nil).IsAfter), arg0, arg1)
-}
-
-// Iterate mocks base method.
-func (m *MockSyncAcl) Iterate(arg0 func(*list.AclRecord) bool) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "Iterate", arg0)
-}
-
-// Iterate indicates an expected call of Iterate.
-func (mr *MockSyncAclMockRecorder) Iterate(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Iterate", reflect.TypeOf((*MockSyncAcl)(nil).Iterate), arg0)
-}
-
-// IterateFrom mocks base method.
-func (m *MockSyncAcl) IterateFrom(arg0 string, arg1 func(*list.AclRecord) bool) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "IterateFrom", arg0, arg1)
-}
-
-// IterateFrom indicates an expected call of IterateFrom.
-func (mr *MockSyncAclMockRecorder) IterateFrom(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "IterateFrom", reflect.TypeOf((*MockSyncAcl)(nil).IterateFrom), arg0, arg1)
-}
-
-// KeyStorage mocks base method.
-func (m *MockSyncAcl) KeyStorage() crypto.KeyStorage {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "KeyStorage")
-	ret0, _ := ret[0].(crypto.KeyStorage)
-	return ret0
-}
-
-// KeyStorage indicates an expected call of KeyStorage.
-func (mr *MockSyncAclMockRecorder) KeyStorage() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "KeyStorage", reflect.TypeOf((*MockSyncAcl)(nil).KeyStorage))
-}
-
-// Lock mocks base method.
-func (m *MockSyncAcl) Lock() {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "Lock")
-}
-
-// Lock indicates an expected call of Lock.
-func (mr *MockSyncAclMockRecorder) Lock() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Lock", reflect.TypeOf((*MockSyncAcl)(nil).Lock))
-}
-
-// Name mocks base method.
-func (m *MockSyncAcl) Name() string {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Name")
-	ret0, _ := ret[0].(string)
-	return ret0
-}
-
-// Name indicates an expected call of Name.
-func (mr *MockSyncAclMockRecorder) Name() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Name", reflect.TypeOf((*MockSyncAcl)(nil).Name))
-}
-
-// RLock mocks base method.
-func (m *MockSyncAcl) RLock() {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "RLock")
-}
-
-// RLock indicates an expected call of RLock.
-func (mr *MockSyncAclMockRecorder) RLock() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RLock", reflect.TypeOf((*MockSyncAcl)(nil).RLock))
-}
-
-// RUnlock mocks base method.
-func (m *MockSyncAcl) RUnlock() {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "RUnlock")
-}
-
-// RUnlock indicates an expected call of RUnlock.
-func (mr *MockSyncAclMockRecorder) RUnlock() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RUnlock", reflect.TypeOf((*MockSyncAcl)(nil).RUnlock))
-}
-
-// RecordBuilder mocks base method.
-func (m *MockSyncAcl) RecordBuilder() list.AclRecordBuilder {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "RecordBuilder")
-	ret0, _ := ret[0].(list.AclRecordBuilder)
-	return ret0
-}
-
-// RecordBuilder indicates an expected call of RecordBuilder.
-func (mr *MockSyncAclMockRecorder) RecordBuilder() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RecordBuilder", reflect.TypeOf((*MockSyncAcl)(nil).RecordBuilder))
-}
-
-// Records mocks base method.
-func (m *MockSyncAcl) Records() []*list.AclRecord {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Records")
-	ret0, _ := ret[0].([]*list.AclRecord)
-	return ret0
-}
-
-// Records indicates an expected call of Records.
-func (mr *MockSyncAclMockRecorder) Records() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Records", reflect.TypeOf((*MockSyncAcl)(nil).Records))
-}
-
-// RecordsAfter mocks base method.
-func (m *MockSyncAcl) RecordsAfter(arg0 context.Context, arg1 string) ([]*consensusproto.RawRecordWithId, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "RecordsAfter", arg0, arg1)
-	ret0, _ := ret[0].([]*consensusproto.RawRecordWithId)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// RecordsAfter indicates an expected call of RecordsAfter.
-func (mr *MockSyncAclMockRecorder) RecordsAfter(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RecordsAfter", reflect.TypeOf((*MockSyncAcl)(nil).RecordsAfter), arg0, arg1)
-}
-
-// RecordsBefore mocks base method.
-func (m *MockSyncAcl) RecordsBefore(arg0 context.Context, arg1 string) ([]*consensusproto.RawRecordWithId, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "RecordsBefore", arg0, arg1)
-	ret0, _ := ret[0].([]*consensusproto.RawRecordWithId)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// RecordsBefore indicates an expected call of RecordsBefore.
-func (mr *MockSyncAclMockRecorder) RecordsBefore(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "RecordsBefore", reflect.TypeOf((*MockSyncAcl)(nil).RecordsBefore), arg0, arg1)
-}
-
-// Root mocks base method.
-func (m *MockSyncAcl) Root() *consensusproto.RawRecordWithId {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Root")
-	ret0, _ := ret[0].(*consensusproto.RawRecordWithId)
-	return ret0
-}
-
-// Root indicates an expected call of Root.
-func (mr *MockSyncAclMockRecorder) Root() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Root", reflect.TypeOf((*MockSyncAcl)(nil).Root))
-}
-
-// Run mocks base method.
-func (m *MockSyncAcl) Run(arg0 context.Context) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Run", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Run indicates an expected call of Run.
-func (mr *MockSyncAclMockRecorder) Run(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Run", reflect.TypeOf((*MockSyncAcl)(nil).Run), arg0)
-}
-
-// SetHeadUpdater mocks base method.
-func (m *MockSyncAcl) SetHeadUpdater(arg0 headupdater.HeadUpdater) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "SetHeadUpdater", arg0)
-}
-
-// SetHeadUpdater indicates an expected call of SetHeadUpdater.
-func (mr *MockSyncAclMockRecorder) SetHeadUpdater(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "SetHeadUpdater", reflect.TypeOf((*MockSyncAcl)(nil).SetHeadUpdater), arg0)
-}
-
-// SyncWithPeer mocks base method.
-func (m *MockSyncAcl) SyncWithPeer(arg0 context.Context, arg1 string) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "SyncWithPeer", arg0, arg1)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// SyncWithPeer indicates an expected call of SyncWithPeer.
-func (mr *MockSyncAclMockRecorder) SyncWithPeer(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "SyncWithPeer", reflect.TypeOf((*MockSyncAcl)(nil).SyncWithPeer), arg0, arg1)
-}
-
-// Unlock mocks base method.
-func (m *MockSyncAcl) Unlock() {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "Unlock")
-}
-
-// Unlock indicates an expected call of Unlock.
-func (mr *MockSyncAclMockRecorder) Unlock() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Unlock", reflect.TypeOf((*MockSyncAcl)(nil).Unlock))
-}
-
-// ValidateRawRecord mocks base method.
-func (m *MockSyncAcl) ValidateRawRecord(arg0 *consensusproto.RawRecord) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "ValidateRawRecord", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// ValidateRawRecord indicates an expected call of ValidateRawRecord.
-func (mr *MockSyncAclMockRecorder) ValidateRawRecord(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "ValidateRawRecord", reflect.TypeOf((*MockSyncAcl)(nil).ValidateRawRecord), arg0)
-}
-
-// MockSyncClient is a mock of SyncClient interface.
-type MockSyncClient struct {
-	ctrl     *gomock.Controller
-	recorder *MockSyncClientMockRecorder
-}
-
-// MockSyncClientMockRecorder is the mock recorder for MockSyncClient.
-type MockSyncClientMockRecorder struct {
-	mock *MockSyncClient
-}
-
-// NewMockSyncClient creates a new mock instance.
-func NewMockSyncClient(ctrl *gomock.Controller) *MockSyncClient {
-	mock := &MockSyncClient{ctrl: ctrl}
-	mock.recorder = &MockSyncClientMockRecorder{mock}
-	return mock
-}
-
-// EXPECT returns an object that allows the caller to indicate expected use.
-func (m *MockSyncClient) EXPECT() *MockSyncClientMockRecorder {
-	return m.recorder
-}
-
-// Broadcast mocks base method.
-func (m *MockSyncClient) Broadcast(arg0 *consensusproto.LogSyncMessage) {
-	m.ctrl.T.Helper()
-	m.ctrl.Call(m, "Broadcast", arg0)
-}
-
-// Broadcast indicates an expected call of Broadcast.
-func (mr *MockSyncClientMockRecorder) Broadcast(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Broadcast", reflect.TypeOf((*MockSyncClient)(nil).Broadcast), arg0)
-}
-
-// CreateFullSyncRequest mocks base method.
-func (m *MockSyncClient) CreateFullSyncRequest(arg0 list.AclList, arg1 string) (*consensusproto.LogSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "CreateFullSyncRequest", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// CreateFullSyncRequest indicates an expected call of CreateFullSyncRequest.
-func (mr *MockSyncClientMockRecorder) CreateFullSyncRequest(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "CreateFullSyncRequest", reflect.TypeOf((*MockSyncClient)(nil).CreateFullSyncRequest), arg0, arg1)
-}
-
-// CreateFullSyncResponse mocks base method.
-func (m *MockSyncClient) CreateFullSyncResponse(arg0 list.AclList, arg1 string) (*consensusproto.LogSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "CreateFullSyncResponse", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// CreateFullSyncResponse indicates an expected call of CreateFullSyncResponse.
-func (mr *MockSyncClientMockRecorder) CreateFullSyncResponse(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "CreateFullSyncResponse", reflect.TypeOf((*MockSyncClient)(nil).CreateFullSyncResponse), arg0, arg1)
-}
-
-// CreateHeadUpdate mocks base method.
-func (m *MockSyncClient) CreateHeadUpdate(arg0 list.AclList, arg1 []*consensusproto.RawRecordWithId) *consensusproto.LogSyncMessage {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "CreateHeadUpdate", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	return ret0
-}
-
-// CreateHeadUpdate indicates an expected call of CreateHeadUpdate.
-func (mr *MockSyncClientMockRecorder) CreateHeadUpdate(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "CreateHeadUpdate", reflect.TypeOf((*MockSyncClient)(nil).CreateHeadUpdate), arg0, arg1)
-}
-
-// QueueRequest mocks base method.
-func (m *MockSyncClient) QueueRequest(arg0 string, arg1 *consensusproto.LogSyncMessage) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "QueueRequest", arg0, arg1)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// QueueRequest indicates an expected call of QueueRequest.
-func (mr *MockSyncClientMockRecorder) QueueRequest(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "QueueRequest", reflect.TypeOf((*MockSyncClient)(nil).QueueRequest), arg0, arg1)
-}
-
-// SendRequest mocks base method.
-func (m *MockSyncClient) SendRequest(arg0 context.Context, arg1 string, arg2 *consensusproto.LogSyncMessage) (*spacesyncproto.ObjectSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "SendRequest", arg0, arg1, arg2)
-	ret0, _ := ret[0].(*spacesyncproto.ObjectSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// SendRequest indicates an expected call of SendRequest.
-func (mr *MockSyncClientMockRecorder) SendRequest(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "SendRequest", reflect.TypeOf((*MockSyncClient)(nil).SendRequest), arg0, arg1, arg2)
-}
-
-// SendUpdate mocks base method.
-func (m *MockSyncClient) SendUpdate(arg0 string, arg1 *consensusproto.LogSyncMessage) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "SendUpdate", arg0, arg1)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// SendUpdate indicates an expected call of SendUpdate.
-func (mr *MockSyncClientMockRecorder) SendUpdate(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "SendUpdate", reflect.TypeOf((*MockSyncClient)(nil).SendUpdate), arg0, arg1)
-}
-
-// MockRequestFactory is a mock of RequestFactory interface.
-type MockRequestFactory struct {
-	ctrl     *gomock.Controller
-	recorder *MockRequestFactoryMockRecorder
-}
-
-// MockRequestFactoryMockRecorder is the mock recorder for MockRequestFactory.
-type MockRequestFactoryMockRecorder struct {
-	mock *MockRequestFactory
-}
-
-// NewMockRequestFactory creates a new mock instance.
-func NewMockRequestFactory(ctrl *gomock.Controller) *MockRequestFactory {
-	mock := &MockRequestFactory{ctrl: ctrl}
-	mock.recorder = &MockRequestFactoryMockRecorder{mock}
-	return mock
-}
-
-// EXPECT returns an object that allows the caller to indicate expected use.
-func (m *MockRequestFactory) EXPECT() *MockRequestFactoryMockRecorder {
-	return m.recorder
-}
-
-// CreateFullSyncRequest mocks base method.
-func (m *MockRequestFactory) CreateFullSyncRequest(arg0 list.AclList, arg1 string) (*consensusproto.LogSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "CreateFullSyncRequest", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// CreateFullSyncRequest indicates an expected call of CreateFullSyncRequest.
-func (mr *MockRequestFactoryMockRecorder) CreateFullSyncRequest(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "CreateFullSyncRequest", reflect.TypeOf((*MockRequestFactory)(nil).CreateFullSyncRequest), arg0, arg1)
-}
-
-// CreateFullSyncResponse mocks base method.
-func (m *MockRequestFactory) CreateFullSyncResponse(arg0 list.AclList, arg1 string) (*consensusproto.LogSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "CreateFullSyncResponse", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// CreateFullSyncResponse indicates an expected call of CreateFullSyncResponse.
-func (mr *MockRequestFactoryMockRecorder) CreateFullSyncResponse(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "CreateFullSyncResponse", reflect.TypeOf((*MockRequestFactory)(nil).CreateFullSyncResponse), arg0, arg1)
-}
-
-// CreateHeadUpdate mocks base method.
-func (m *MockRequestFactory) CreateHeadUpdate(arg0 list.AclList, arg1 []*consensusproto.RawRecordWithId) *consensusproto.LogSyncMessage {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "CreateHeadUpdate", arg0, arg1)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	return ret0
-}
-
-// CreateHeadUpdate indicates an expected call of CreateHeadUpdate.
-func (mr *MockRequestFactoryMockRecorder) CreateHeadUpdate(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "CreateHeadUpdate", reflect.TypeOf((*MockRequestFactory)(nil).CreateHeadUpdate), arg0, arg1)
-}
-
-// MockAclSyncProtocol is a mock of AclSyncProtocol interface.
-type MockAclSyncProtocol struct {
-	ctrl     *gomock.Controller
-	recorder *MockAclSyncProtocolMockRecorder
-}
-
-// MockAclSyncProtocolMockRecorder is the mock recorder for MockAclSyncProtocol.
-type MockAclSyncProtocolMockRecorder struct {
-	mock *MockAclSyncProtocol
-}
-
-// NewMockAclSyncProtocol creates a new mock instance.
-func NewMockAclSyncProtocol(ctrl *gomock.Controller) *MockAclSyncProtocol {
-	mock := &MockAclSyncProtocol{ctrl: ctrl}
-	mock.recorder = &MockAclSyncProtocolMockRecorder{mock}
-	return mock
-}
-
-// EXPECT returns an object that allows the caller to indicate expected use.
-func (m *MockAclSyncProtocol) EXPECT() *MockAclSyncProtocolMockRecorder {
-	return m.recorder
-}
-
-// FullSyncRequest mocks base method.
-func (m *MockAclSyncProtocol) FullSyncRequest(arg0 context.Context, arg1 string, arg2 *consensusproto.LogFullSyncRequest) (*consensusproto.LogSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "FullSyncRequest", arg0, arg1, arg2)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// FullSyncRequest indicates an expected call of FullSyncRequest.
-func (mr *MockAclSyncProtocolMockRecorder) FullSyncRequest(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "FullSyncRequest", reflect.TypeOf((*MockAclSyncProtocol)(nil).FullSyncRequest), arg0, arg1, arg2)
-}
-
-// FullSyncResponse mocks base method.
-func (m *MockAclSyncProtocol) FullSyncResponse(arg0 context.Context, arg1 string, arg2 *consensusproto.LogFullSyncResponse) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "FullSyncResponse", arg0, arg1, arg2)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// FullSyncResponse indicates an expected call of FullSyncResponse.
-func (mr *MockAclSyncProtocolMockRecorder) FullSyncResponse(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "FullSyncResponse", reflect.TypeOf((*MockAclSyncProtocol)(nil).FullSyncResponse), arg0, arg1, arg2)
-}
-
-// HeadUpdate mocks base method.
-func (m *MockAclSyncProtocol) HeadUpdate(arg0 context.Context, arg1 string, arg2 *consensusproto.LogHeadUpdate) (*consensusproto.LogSyncMessage, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "HeadUpdate", arg0, arg1, arg2)
-	ret0, _ := ret[0].(*consensusproto.LogSyncMessage)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// HeadUpdate indicates an expected call of HeadUpdate.
-func (mr *MockAclSyncProtocolMockRecorder) HeadUpdate(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "HeadUpdate", reflect.TypeOf((*MockAclSyncProtocol)(nil).HeadUpdate), arg0, arg1, arg2)
-}

commonspace/object/acl/syncacl/requestfactory.go

@@ -1,54 +0,0 @@
-package syncacl
-
-import (
-	"context"
-
-	"github.com/anyproto/any-sync/commonspace/object/acl/list"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-)
-
-type RequestFactory interface {
-	CreateHeadUpdate(l list.AclList, added []*consensusproto.RawRecordWithId) (msg *consensusproto.LogSyncMessage)
-	CreateFullSyncRequest(l list.AclList, theirHead string) (req *consensusproto.LogSyncMessage, err error)
-	CreateFullSyncResponse(l list.AclList, theirHead string) (*consensusproto.LogSyncMessage, error)
-}
-
-type requestFactory struct{}
-
-func NewRequestFactory() RequestFactory {
-	return &requestFactory{}
-}
-
-func (r *requestFactory) CreateHeadUpdate(l list.AclList, added []*consensusproto.RawRecordWithId) (msg *consensusproto.LogSyncMessage) {
-	return consensusproto.WrapHeadUpdate(&consensusproto.LogHeadUpdate{
-		Head:    l.Head().Id,
-		Records: added,
-	}, l.Root())
-}
-
-func (r *requestFactory) CreateFullSyncRequest(l list.AclList, theirHead string) (req *consensusproto.LogSyncMessage, err error) {
-	if !l.HasHead(theirHead) {
-		return consensusproto.WrapFullRequest(&consensusproto.LogFullSyncRequest{
-			Head: l.Head().Id,
-		}, l.Root()), nil
-	}
-	records, err := l.RecordsAfter(context.Background(), theirHead)
-	if err != nil {
-		return
-	}
-	return consensusproto.WrapFullRequest(&consensusproto.LogFullSyncRequest{
-		Head:    l.Head().Id,
-		Records: records,
-	}, l.Root()), nil
-}
-
-func (r *requestFactory) CreateFullSyncResponse(l list.AclList, theirHead string) (resp *consensusproto.LogSyncMessage, err error) {
-	records, err := l.RecordsAfter(context.Background(), theirHead)
-	if err != nil {
-		return
-	}
-	return consensusproto.WrapFullResponse(&consensusproto.LogFullSyncResponse{
-		Head:    l.Head().Id,
-		Records: records,
-	}, l.Root()), nil
-}

commonspace/object/acl/syncacl/syncacl.go

@@ -2,129 +2,42 @@ package syncacl
 
 import (
 	"context"
-	"errors"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl/headupdater"
-	"github.com/anyproto/any-sync/commonspace/object/syncobjectgetter"
-
 	"github.com/anyproto/any-sync/accountservice"
 	"github.com/anyproto/any-sync/app"
-	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
-	"github.com/anyproto/any-sync/commonspace/objectsync/synchandler"
-	"github.com/anyproto/any-sync/commonspace/peermanager"
-	"github.com/anyproto/any-sync/commonspace/requestmanager"
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 )
 
 const CName = "common.acl.syncacl"
 
-var (
-	log = logger.NewNamed(CName)
+func New() *SyncAcl {
+	return &SyncAcl{}
+}
 
-	ErrSyncAclClosed = errors.New("sync acl is closed")
-)
-
-type SyncAcl interface {
-	app.ComponentRunnable
+type SyncAcl struct {
 	list.AclList
-	syncobjectgetter.SyncObject
-	SetHeadUpdater(updater headupdater.HeadUpdater)
-	SyncWithPeer(ctx context.Context, peerId string) (err error)
 }
 
-func New() SyncAcl {
-	return &syncAcl{}
+func (s *SyncAcl) HandleRequest(ctx context.Context, senderId string, request *spacesyncproto.ObjectSyncMessage) (response *spacesyncproto.ObjectSyncMessage, err error) {
+	return nil, nil
 }
 
-type syncAcl struct {
-	list.AclList
-	syncClient  SyncClient
-	syncHandler synchandler.SyncHandler
-	headUpdater headupdater.HeadUpdater
-	isClosed    bool
+func (s *SyncAcl) HandleMessage(ctx context.Context, senderId string, request *spacesyncproto.ObjectSyncMessage) (err error) {
+	return nil
 }
 
-func (s *syncAcl) Run(ctx context.Context) (err error) {
-	return
-}
-
-func (s *syncAcl) HandleRequest(ctx context.Context, senderId string, request *spacesyncproto.ObjectSyncMessage) (response *spacesyncproto.ObjectSyncMessage, err error) {
-	return s.syncHandler.HandleRequest(ctx, senderId, request)
-}
-
-func (s *syncAcl) SetHeadUpdater(updater headupdater.HeadUpdater) {
-	s.headUpdater = updater
-}
-
-func (s *syncAcl) HandleMessage(ctx context.Context, senderId string, request *spacesyncproto.ObjectSyncMessage) (err error) {
-	return s.syncHandler.HandleMessage(ctx, senderId, request)
-}
-
-func (s *syncAcl) Init(a *app.App) (err error) {
+func (s *SyncAcl) Init(a *app.App) (err error) {
 	storage := a.MustComponent(spacestorage.CName).(spacestorage.SpaceStorage)
 	aclStorage, err := storage.AclStorage()
 	if err != nil {
 		return err
 	}
 	acc := a.MustComponent(accountservice.CName).(accountservice.Service)
-	s.AclList, err = list.BuildAclListWithIdentity(acc.Account(), aclStorage, list.NoOpAcceptorVerifier{})
-	if err != nil {
-		return
-	}
-	spaceId := storage.Id()
-	requestManager := a.MustComponent(requestmanager.CName).(requestmanager.RequestManager)
-	peerManager := a.MustComponent(peermanager.CName).(peermanager.PeerManager)
-	syncStatus := a.MustComponent(syncstatus.CName).(syncstatus.StatusService)
-	s.syncClient = NewSyncClient(spaceId, requestManager, peerManager)
-	s.syncHandler = newSyncAclHandler(storage.Id(), s, s.syncClient, syncStatus)
+	s.AclList, err = list.BuildAclListWithIdentity(acc.Account(), aclStorage)
 	return err
 }
 
-func (s *syncAcl) AddRawRecord(rawRec *consensusproto.RawRecordWithId) (err error) {
-	if s.isClosed {
-		return ErrSyncAclClosed
-	}
-	err = s.AclList.AddRawRecord(rawRec)
-	if err != nil {
-		return
-	}
-	headUpdate := s.syncClient.CreateHeadUpdate(s, []*consensusproto.RawRecordWithId{rawRec})
-	s.headUpdater.UpdateHeads(s.Id(), []string{rawRec.Id})
-	s.syncClient.Broadcast(headUpdate)
-	return
-}
-
-func (s *syncAcl) AddRawRecords(rawRecords []*consensusproto.RawRecordWithId) (err error) {
-	if s.isClosed {
-		return ErrSyncAclClosed
-	}
-	err = s.AclList.AddRawRecords(rawRecords)
-	if err != nil {
-		return
-	}
-	headUpdate := s.syncClient.CreateHeadUpdate(s, rawRecords)
-	s.headUpdater.UpdateHeads(s.Id(), []string{rawRecords[len(rawRecords)-1].Id})
-	s.syncClient.Broadcast(headUpdate)
-	return
-}
-
-func (s *syncAcl) SyncWithPeer(ctx context.Context, peerId string) (err error) {
-	s.Lock()
-	defer s.Unlock()
-	headUpdate := s.syncClient.CreateHeadUpdate(s, nil)
-	return s.syncClient.SendUpdate(peerId, headUpdate)
-}
-
-func (s *syncAcl) Close(ctx context.Context) (err error) {
-	s.Lock()
-	defer s.Unlock()
-	s.isClosed = true
-	return
-}
-
-func (s *syncAcl) Name() (name string) {
+func (s *SyncAcl) Name() (name string) {
 	return CName
 }

commonspace/object/acl/syncacl/syncaclhandler.go

@@ -2,81 +2,30 @@ package syncacl
 
 import (
 	"context"
-	"errors"
-
+	"fmt"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
-	"github.com/anyproto/any-sync/commonspace/objectsync/synchandler"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/gogo/protobuf/proto"
-)
-
-var (
-	ErrMessageIsRequest    = errors.New("message is request")
-	ErrMessageIsNotRequest = errors.New("message is not request")
 )
 
 type syncAclHandler struct {
-	aclList      list.AclList
-	syncClient   SyncClient
-	syncProtocol AclSyncProtocol
-	syncStatus   syncstatus.StatusUpdater
-	spaceId      string
+	acl list.AclList
 }
 
-func newSyncAclHandler(spaceId string, aclList list.AclList, syncClient SyncClient, syncStatus syncstatus.StatusUpdater) synchandler.SyncHandler {
-	return &syncAclHandler{
-		aclList:      aclList,
-		syncClient:   syncClient,
-		syncProtocol: newAclSyncProtocol(spaceId, aclList, syncClient),
-		syncStatus:   syncStatus,
-		spaceId:      spaceId,
-	}
-}
-
-func (s *syncAclHandler) HandleMessage(ctx context.Context, senderId string, message *spacesyncproto.ObjectSyncMessage) (err error) {
-	unmarshalled := &consensusproto.LogSyncMessage{}
-	err = proto.Unmarshal(message.Payload, unmarshalled)
-	if err != nil {
+func (s *syncAclHandler) HandleMessage(ctx context.Context, senderId string, req *spacesyncproto.ObjectSyncMessage) (err error) {
+	aclMsg := &aclrecordproto.AclSyncMessage{}
+	if err = aclMsg.Unmarshal(req.Payload); err != nil {
 		return
 	}
-	content := unmarshalled.GetContent()
-	head := consensusproto.GetHead(unmarshalled)
-	s.syncStatus.HeadsReceive(senderId, s.aclList.Id(), []string{head})
-	s.aclList.Lock()
-	defer s.aclList.Unlock()
+	content := aclMsg.GetContent()
 	switch {
-	case content.GetHeadUpdate() != nil:
-		var syncReq *consensusproto.LogSyncMessage
-		syncReq, err = s.syncProtocol.HeadUpdate(ctx, senderId, content.GetHeadUpdate())
-		if err != nil || syncReq == nil {
-			return
-		}
-		return s.syncClient.QueueRequest(senderId, syncReq)
-	case content.GetFullSyncRequest() != nil:
-		return ErrMessageIsRequest
-	case content.GetFullSyncResponse() != nil:
-		return s.syncProtocol.FullSyncResponse(ctx, senderId, content.GetFullSyncResponse())
+	case content.GetAddRecords() != nil:
+		return s.handleAddRecords(ctx, senderId, content.GetAddRecords())
+	default:
+		return fmt.Errorf("unexpected aclSync message: %T", content.Value)
 	}
+}
+
+func (s *syncAclHandler) handleAddRecords(ctx context.Context, senderId string, addRecord *aclrecordproto.AclAddRecords) (err error) {
 	return
 }
-
-func (s *syncAclHandler) HandleRequest(ctx context.Context, senderId string, request *spacesyncproto.ObjectSyncMessage) (response *spacesyncproto.ObjectSyncMessage, err error) {
-	unmarshalled := &consensusproto.LogSyncMessage{}
-	err = proto.Unmarshal(request.Payload, unmarshalled)
-	if err != nil {
-		return
-	}
-	fullSyncRequest := unmarshalled.GetContent().GetFullSyncRequest()
-	if fullSyncRequest == nil {
-		return nil, ErrMessageIsNotRequest
-	}
-	s.aclList.Lock()
-	defer s.aclList.Unlock()
-	aclResp, err := s.syncProtocol.FullSyncRequest(ctx, senderId, fullSyncRequest)
-	if err != nil {
-		return
-	}
-	return spacesyncproto.MarshallSyncMessage(aclResp, s.spaceId, s.aclList.Id())
-}

commonspace/object/acl/syncacl/syncaclhandler_test.go

@@ -1,233 +0,0 @@
-package syncacl
-
-import (
-	"context"
-	"fmt"
-	"github.com/anyproto/any-sync/commonspace/object/acl/list/mock_list"
-	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl/mock_syncacl"
-	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/gogo/protobuf/proto"
-	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
-	"sync"
-	"testing"
-)
-
-type testAclMock struct {
-	*mock_list.MockAclList
-	m sync.RWMutex
-}
-
-func newTestAclMock(mockAcl *mock_list.MockAclList) *testAclMock {
-	return &testAclMock{
-		MockAclList: mockAcl,
-	}
-}
-
-func (t *testAclMock) Lock() {
-	t.m.Lock()
-}
-
-func (t *testAclMock) RLock() {
-	t.m.RLock()
-}
-
-func (t *testAclMock) Unlock() {
-	t.m.Unlock()
-}
-
-func (t *testAclMock) RUnlock() {
-	t.m.RUnlock()
-}
-
-func (t *testAclMock) TryLock() bool {
-	return t.m.TryLock()
-}
-
-func (t *testAclMock) TryRLock() bool {
-	return t.m.TryRLock()
-}
-
-type syncHandlerFixture struct {
-	ctrl             *gomock.Controller
-	syncClientMock   *mock_syncacl.MockSyncClient
-	aclMock          *testAclMock
-	syncProtocolMock *mock_syncacl.MockAclSyncProtocol
-	spaceId          string
-	senderId         string
-	aclId            string
-
-	syncHandler *syncAclHandler
-}
-
-func newSyncHandlerFixture(t *testing.T) *syncHandlerFixture {
-	ctrl := gomock.NewController(t)
-	aclMock := newTestAclMock(mock_list.NewMockAclList(ctrl))
-	syncClientMock := mock_syncacl.NewMockSyncClient(ctrl)
-	syncProtocolMock := mock_syncacl.NewMockAclSyncProtocol(ctrl)
-	spaceId := "spaceId"
-
-	syncHandler := &syncAclHandler{
-		aclList:      aclMock,
-		syncClient:   syncClientMock,
-		syncProtocol: syncProtocolMock,
-		syncStatus:   syncstatus.NewNoOpSyncStatus(),
-		spaceId:      spaceId,
-	}
-	return &syncHandlerFixture{
-		ctrl:             ctrl,
-		syncClientMock:   syncClientMock,
-		aclMock:          aclMock,
-		syncProtocolMock: syncProtocolMock,
-		spaceId:          spaceId,
-		senderId:         "senderId",
-		aclId:            "aclId",
-		syncHandler:      syncHandler,
-	}
-}
-
-func (fx *syncHandlerFixture) stop() {
-	fx.ctrl.Finish()
-}
-
-func TestSyncAclHandler_HandleMessage(t *testing.T) {
-	ctx := context.Background()
-	t.Run("handle head update, request returned", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-
-		syncReq := &consensusproto.LogSyncMessage{}
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.syncProtocolMock.EXPECT().HeadUpdate(ctx, fx.senderId, gomock.Any()).Return(syncReq, nil)
-		fx.syncClientMock.EXPECT().QueueRequest(fx.senderId, syncReq).Return(nil)
-
-		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
-		require.NoError(t, err)
-	})
-	t.Run("handle head update, no request", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.syncProtocolMock.EXPECT().HeadUpdate(ctx, fx.senderId, gomock.Any()).Return(nil, nil)
-
-		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
-		require.NoError(t, err)
-	})
-	t.Run("handle head update, returned error", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		expectedErr := fmt.Errorf("some error")
-		fx.syncProtocolMock.EXPECT().HeadUpdate(ctx, fx.senderId, gomock.Any()).Return(nil, expectedErr)
-
-		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
-		require.Error(t, expectedErr, err)
-	})
-	t.Run("handle full sync request is forbidden", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullRequest := &consensusproto.LogFullSyncRequest{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapFullRequest(fullRequest, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
-		require.Error(t, ErrMessageIsRequest, err)
-	})
-	t.Run("handle full sync response, no error", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullResponse := &consensusproto.LogFullSyncResponse{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapFullResponse(fullResponse, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.syncProtocolMock.EXPECT().FullSyncResponse(ctx, fx.senderId, gomock.Any()).Return(nil)
-
-		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
-		require.NoError(t, err)
-	})
-}
-
-func TestSyncAclHandler_HandleRequest(t *testing.T) {
-	ctx := context.Background()
-	t.Run("handle full sync request, no error", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		fullRequest := &consensusproto.LogFullSyncRequest{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapFullRequest(fullRequest, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-		fullResp := &consensusproto.LogSyncMessage{
-			Content: &consensusproto.LogSyncContentValue{
-				Value: &consensusproto.LogSyncContentValue_FullSyncResponse{
-					FullSyncResponse: &consensusproto.LogFullSyncResponse{
-						Head: "returnedHead",
-					},
-				},
-			},
-		}
-
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		fx.syncProtocolMock.EXPECT().FullSyncRequest(ctx, fx.senderId, gomock.Any()).Return(fullResp, nil)
-		res, err := fx.syncHandler.HandleRequest(ctx, fx.senderId, objectMsg)
-		require.NoError(t, err)
-		unmarshalled := &consensusproto.LogSyncMessage{}
-		err = proto.Unmarshal(res.Payload, unmarshalled)
-		if err != nil {
-			return
-		}
-		require.Equal(t, "returnedHead", consensusproto.GetHead(unmarshalled))
-	})
-	t.Run("handle other message returns error", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		chWithId := &consensusproto.RawRecordWithId{}
-		headUpdate := &consensusproto.LogHeadUpdate{
-			Head:    "h1",
-			Records: []*consensusproto.RawRecordWithId{chWithId},
-		}
-		logMessage := consensusproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(logMessage, fx.spaceId, fx.aclId)
-
-		fx.aclMock.EXPECT().Id().AnyTimes().Return(fx.aclId)
-		_, err := fx.syncHandler.HandleRequest(ctx, fx.senderId, objectMsg)
-		require.Error(t, ErrMessageIsNotRequest, err)
-	})
-}

commonspace/object/acl/syncacl/syncclient.go

@@ -1,70 +0,0 @@
-package syncacl
-
-import (
-	"context"
-
-	"github.com/anyproto/any-sync/commonspace/peermanager"
-	"github.com/anyproto/any-sync/commonspace/requestmanager"
-	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"go.uber.org/zap"
-)
-
-type SyncClient interface {
-	RequestFactory
-	Broadcast(msg *consensusproto.LogSyncMessage)
-	SendUpdate(peerId string, msg *consensusproto.LogSyncMessage) (err error)
-	QueueRequest(peerId string, msg *consensusproto.LogSyncMessage) (err error)
-	SendRequest(ctx context.Context, peerId string, msg *consensusproto.LogSyncMessage) (reply *spacesyncproto.ObjectSyncMessage, err error)
-}
-
-type syncClient struct {
-	RequestFactory
-	spaceId        string
-	requestManager requestmanager.RequestManager
-	peerManager    peermanager.PeerManager
-}
-
-func NewSyncClient(spaceId string, requestManager requestmanager.RequestManager, peerManager peermanager.PeerManager) SyncClient {
-	return &syncClient{
-		RequestFactory: &requestFactory{},
-		spaceId:        spaceId,
-		requestManager: requestManager,
-		peerManager:    peerManager,
-	}
-}
-
-func (s *syncClient) Broadcast(msg *consensusproto.LogSyncMessage) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, msg.Id)
-	if err != nil {
-		return
-	}
-	err = s.peerManager.Broadcast(context.Background(), objMsg)
-	if err != nil {
-		log.Debug("broadcast error", zap.Error(err))
-	}
-}
-
-func (s *syncClient) SendUpdate(peerId string, msg *consensusproto.LogSyncMessage) (err error) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, msg.Id)
-	if err != nil {
-		return
-	}
-	return s.peerManager.SendPeer(context.Background(), peerId, objMsg)
-}
-
-func (s *syncClient) SendRequest(ctx context.Context, peerId string, msg *consensusproto.LogSyncMessage) (reply *spacesyncproto.ObjectSyncMessage, err error) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, msg.Id)
-	if err != nil {
-		return
-	}
-	return s.requestManager.SendRequest(ctx, peerId, objMsg)
-}
-
-func (s *syncClient) QueueRequest(peerId string, msg *consensusproto.LogSyncMessage) (err error) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, msg.Id)
-	if err != nil {
-		return
-	}
-	return s.requestManager.QueueRequest(peerId, objMsg)
-}

commonspace/object/tree/exporter/treeimport.go

@@ -15,7 +15,7 @@ type TreeImportParams struct {
 }
 
 func ImportHistoryTree(params TreeImportParams) (tree objecttree.ReadableObjectTree, err error) {
-	aclList, err := list.BuildAclList(params.ListStorage, list.NoOpAcceptorVerifier{})
+	aclList, err := list.BuildAclList(params.ListStorage)
 	if err != nil {
 		return
 	}

commonspace/object/tree/objecttree/mock_objecttree/mock_objecttree.go

@@ -13,7 +13,7 @@ import (
 	objecttree "github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	treechangeproto "github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	treestorage "github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockObjectTree is a mock of ObjectTree interface.

commonspace/object/tree/objecttree/objecttree.go

@@ -4,11 +4,11 @@ package objecttree
 import (
 	"context"
 	"errors"
+	"github.com/anyproto/any-sync/util/crypto"
 	"sync"
 	"time"
 
-	"github.com/anyproto/any-sync/util/crypto"
-
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
@@ -248,7 +248,9 @@ func (ot *objectTree) prepareBuilderContent(content SignableChangeContent) (cnt
 		pubKey    = content.Key.GetPublic()
 		readKeyId string
 	)
-	if !state.Permissions(pubKey).CanWrite() {
+	canWrite := state.HasPermission(pubKey, aclrecordproto.AclUserPermissions_Writer) ||
+		state.HasPermission(pubKey, aclrecordproto.AclUserPermissions_Admin)
+	if !canWrite {
 		err = list.ErrInsufficientPermissions
 		return
 	}

commonspace/object/tree/objecttree/objecttree_test.go

@@ -3,9 +3,6 @@ package objecttree
 import (
 	"context"
 	"fmt"
-	"testing"
-	"time"
-
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
@@ -13,6 +10,8 @@ import (
 	"github.com/gogo/protobuf/proto"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"testing"
+	"time"
 )
 
 type testTreeContext struct {
@@ -124,7 +123,6 @@ func TestObjectTree(t *testing.T) {
 			require.NoError(t, err)
 			require.GreaterOrEqual(t, start.Unix(), ch.Timestamp)
 			require.LessOrEqual(t, end.Unix(), ch.Timestamp)
-			require.Equal(t, res.Added[0].Id, oTree.(*objectTree).tree.lastIteratedHeadId)
 		})
 		t.Run("timestamp is set correctly", func(t *testing.T) {
 			someTs := time.Now().Add(time.Hour).Unix()
@@ -141,7 +139,6 @@ func TestObjectTree(t *testing.T) {
 			ch, err := oTree.(*objectTree).changeBuilder.Unmarshall(res.Added[0], true)
 			require.NoError(t, err)
 			require.Equal(t, ch.Timestamp, someTs)
-			require.Equal(t, res.Added[0].Id, oTree.(*objectTree).tree.lastIteratedHeadId)
 		})
 	})
 

commonspace/object/tree/objecttree/objecttreevalidator.go

@@ -3,7 +3,7 @@ package objecttree
 import (
 	"context"
 	"fmt"
-
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	"github.com/anyproto/any-sync/util/slice"
@@ -52,18 +52,20 @@ func (v *objectTreeValidator) ValidateNewChanges(tree *Tree, aclList list.AclLis
 
 func (v *objectTreeValidator) validateChange(tree *Tree, aclList list.AclList, c *Change) (err error) {
 	var (
-		userState list.AclUserState
-		state     = aclList.AclState()
+		perm  list.AclUserState
+		state = aclList.AclState()
 	)
 	// checking if the user could write
-	userState, err = state.StateAtRecord(c.AclHeadId, c.Identity)
+	perm, err = state.StateAtRecord(c.AclHeadId, c.Identity)
 	if err != nil {
 		return
 	}
-	if !userState.Permissions.CanWrite() {
+
+	if perm.Permissions != aclrecordproto.AclUserPermissions_Writer && perm.Permissions != aclrecordproto.AclUserPermissions_Admin {
 		err = list.ErrInsufficientPermissions
 		return
 	}
+
 	if c.Id == tree.RootId() {
 		return
 	}

commonspace/object/tree/objecttree/rawloader.go

@@ -2,11 +2,10 @@ package objecttree
 
 import (
 	"context"
-	"time"
-
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	"github.com/anyproto/any-sync/util/slice"
+	"time"
 )
 
 type rawChangeLoader struct {
@@ -23,7 +22,6 @@ type rawCacheEntry struct {
 	change    *Change
 	rawChange *treechangeproto.RawTreeChangeWithId
 	position  int
-	removed   bool
 }
 
 func newStorageLoader(treeStorage treestorage.TreeStorage, changeBuilder ChangeBuilder) *rawChangeLoader {
@@ -128,6 +126,7 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 		if err != nil {
 			continue
 		}
+		entry.position = -1
 		r.cache[b] = entry
 		existingBreakpoints = append(existingBreakpoints, b)
 	}
@@ -136,7 +135,8 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 	dfs := func(
 		commonSnapshot string,
 		heads []string,
-		shouldVisit func(entry rawCacheEntry, mapExists bool) bool,
+		startCounter int,
+		shouldVisit func(counter int, mapExists bool) bool,
 		visit func(entry rawCacheEntry) rawCacheEntry) bool {
 
 		// resetting stack
@@ -150,7 +150,7 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 			r.idStack = r.idStack[:len(r.idStack)-1]
 
 			entry, exists := r.cache[id]
-			if !shouldVisit(entry, exists) {
+			if !shouldVisit(entry.position, exists) {
 				continue
 			}
 			if id == commonSnapshot {
@@ -159,6 +159,7 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 			}
 			if !exists {
 				entry, err = r.loadEntry(id)
+				entry.position = -1
 				if err != nil {
 					continue
 				}
@@ -173,7 +174,7 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 					break
 				}
 				prevEntry, exists := r.cache[prev]
-				if !shouldVisit(prevEntry, exists) {
+				if !shouldVisit(prevEntry.position, exists) {
 					continue
 				}
 				r.idStack = append(r.idStack, prev)
@@ -186,8 +187,8 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 	r.idStack = append(r.idStack, heads...)
 	var buffer []*treechangeproto.RawTreeChangeWithId
 
-	rootVisited := dfs(commonSnapshot, heads,
-		func(_ rawCacheEntry, mapExists bool) bool {
+	rootVisited := dfs(commonSnapshot, heads, 0,
+		func(counter int, mapExists bool) bool {
 			return !mapExists
 		},
 		func(entry rawCacheEntry) rawCacheEntry {
@@ -212,13 +213,11 @@ func (r *rawChangeLoader) loadFromStorage(commonSnapshot string, heads, breakpoi
 	}
 
 	// marking all visited as nil
-	dfs(commonSnapshot, existingBreakpoints,
-		func(entry rawCacheEntry, mapExists bool) bool {
-			// only going through already loaded changes
-			return mapExists && !entry.removed
+	dfs(commonSnapshot, existingBreakpoints, len(buffer),
+		func(counter int, mapExists bool) bool {
+			return !mapExists || counter < len(buffer)
 		},
 		func(entry rawCacheEntry) rawCacheEntry {
-			entry.removed = true
 			if entry.position != -1 {
 				buffer[entry.position] = nil
 			}
@@ -249,7 +248,6 @@ func (r *rawChangeLoader) loadEntry(id string) (entry rawCacheEntry, err error)
 	entry = rawCacheEntry{
 		change:    change,
 		rawChange: rawChange,
-		position:  -1,
 	}
 	return
 }

commonspace/object/tree/objecttree/tree.go

@@ -82,7 +82,6 @@ func (t *Tree) AddMergedHead(c *Change) error {
 		}
 	}
 	t.headIds = []string{c.Id}
-	t.lastIteratedHeadId = c.Id
 	return nil
 }
 

commonspace/object/tree/objecttree/tree_test.go

@@ -2,12 +2,10 @@ package objecttree
 
 import (
 	"fmt"
+	"github.com/stretchr/testify/assert"
 	"math/rand"
 	"testing"
 	"time"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func newChange(id string, snapshotId string, prevIds ...string) *Change {
@@ -28,17 +26,6 @@ func newSnapshot(id, snapshotId string, prevIds ...string) *Change {
 	}
 }
 
-func TestTree_AddMergedHead(t *testing.T) {
-	tr := new(Tree)
-	_, _ = tr.Add(
-		newSnapshot("root", ""),
-		newChange("one", "root", "root"),
-	)
-	require.Equal(t, tr.lastIteratedHeadId, "one")
-	tr.AddMergedHead(newChange("two", "root", "one"))
-	require.Equal(t, tr.lastIteratedHeadId, "two")
-}
-
 func TestTree_Add(t *testing.T) {
 	t.Run("add first el", func(t *testing.T) {
 		tr := new(Tree)

commonspace/object/tree/synctree/mock_synctree/mock_synctree.go

@@ -15,7 +15,7 @@ import (
 	treechangeproto "github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	treestorage "github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockSyncTree is a mock of SyncTree interface.

commonspace/object/tree/synctree/protocolintegration_test.go

@@ -2,10 +2,6 @@ package synctree
 
 import (
 	"context"
-	"math/rand"
-	"testing"
-	"time"
-
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
@@ -14,6 +10,9 @@ import (
 	"github.com/anyproto/any-sync/util/slice"
 	"github.com/gogo/protobuf/proto"
 	"github.com/stretchr/testify/require"
+	"math/rand"
+	"testing"
+	"time"
 )
 
 func TestEmptyClientGetsFullHistory(t *testing.T) {

commonspace/object/tree/synctree/syncclient.go

@@ -2,7 +2,6 @@ package synctree
 
 import (
 	"context"
-
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/peermanager"
 	"github.com/anyproto/any-sync/commonspace/requestmanager"
@@ -33,9 +32,8 @@ func NewSyncClient(spaceId string, requestManager requestmanager.RequestManager,
 		peerManager:    peerManager,
 	}
 }
-
 func (s *syncClient) Broadcast(msg *treechangeproto.TreeSyncMessage) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, msg.RootChange.Id)
+	objMsg, err := MarshallTreeMessage(msg, s.spaceId, msg.RootChange.Id, "")
 	if err != nil {
 		return
 	}
@@ -46,7 +44,7 @@ func (s *syncClient) Broadcast(msg *treechangeproto.TreeSyncMessage) {
 }
 
 func (s *syncClient) SendUpdate(peerId, objectId string, msg *treechangeproto.TreeSyncMessage) (err error) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, objectId)
+	objMsg, err := MarshallTreeMessage(msg, s.spaceId, objectId, "")
 	if err != nil {
 		return
 	}
@@ -54,7 +52,7 @@ func (s *syncClient) SendUpdate(peerId, objectId string, msg *treechangeproto.Tr
 }
 
 func (s *syncClient) SendRequest(ctx context.Context, peerId, objectId string, msg *treechangeproto.TreeSyncMessage) (reply *spacesyncproto.ObjectSyncMessage, err error) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, objectId)
+	objMsg, err := MarshallTreeMessage(msg, s.spaceId, objectId, "")
 	if err != nil {
 		return
 	}
@@ -62,9 +60,23 @@ func (s *syncClient) SendRequest(ctx context.Context, peerId, objectId string, m
 }
 
 func (s *syncClient) QueueRequest(peerId, objectId string, msg *treechangeproto.TreeSyncMessage) (err error) {
-	objMsg, err := spacesyncproto.MarshallSyncMessage(msg, s.spaceId, objectId)
+	objMsg, err := MarshallTreeMessage(msg, s.spaceId, objectId, "")
 	if err != nil {
 		return
 	}
 	return s.requestManager.QueueRequest(peerId, objMsg)
 }
+
+func MarshallTreeMessage(message *treechangeproto.TreeSyncMessage, spaceId, objectId, replyId string) (objMsg *spacesyncproto.ObjectSyncMessage, err error) {
+	payload, err := message.Marshal()
+	if err != nil {
+		return
+	}
+	objMsg = &spacesyncproto.ObjectSyncMessage{
+		ReplyId:  replyId,
+		Payload:  payload,
+		ObjectId: objectId,
+		SpaceId:  spaceId,
+	}
+	return
+}

commonspace/object/tree/synctree/synctree.go

@@ -59,18 +59,19 @@ type ResponsiblePeersGetter interface {
 }
 
 type BuildDeps struct {
-	SpaceId         string
-	SyncClient      SyncClient
-	Configuration   nodeconf.NodeConf
-	HeadNotifiable  HeadNotifiable
-	Listener        updatelistener.UpdateListener
-	AclList         list.AclList
-	SpaceStorage    spacestorage.SpaceStorage
-	TreeStorage     treestorage.TreeStorage
-	OnClose         func(id string)
-	SyncStatus      syncstatus.StatusUpdater
-	PeerGetter      ResponsiblePeersGetter
-	BuildObjectTree objecttree.BuildObjectTreeFunc
+	SpaceId            string
+	SyncClient         SyncClient
+	Configuration      nodeconf.NodeConf
+	HeadNotifiable     HeadNotifiable
+	Listener           updatelistener.UpdateListener
+	AclList            list.AclList
+	SpaceStorage       spacestorage.SpaceStorage
+	TreeStorage        treestorage.TreeStorage
+	OnClose            func(id string)
+	SyncStatus         syncstatus.StatusUpdater
+	PeerGetter         ResponsiblePeersGetter
+	BuildObjectTree    objecttree.BuildObjectTreeFunc
+	WaitTreeRemoteSync bool
 }
 
 func BuildSyncTreeOrGetRemote(ctx context.Context, id string, deps BuildDeps) (t SyncTree, err error) {
@@ -205,27 +206,18 @@ func (s *syncTree) Delete() (err error) {
 }
 
 func (s *syncTree) TryClose(objectTTL time.Duration) (bool, error) {
-	if !s.TryLock() {
-		return false, nil
-	}
-	log.Debug("closing sync tree", zap.String("id", s.Id()))
-	return true, s.close()
+	return true, s.Close()
 }
 
 func (s *syncTree) Close() (err error) {
 	log.Debug("closing sync tree", zap.String("id", s.Id()))
-	s.Lock()
-	return s.close()
-}
-
-func (s *syncTree) close() (err error) {
-	defer s.Unlock()
 	defer func() {
 		log.Debug("closed sync tree", zap.Error(err), zap.String("id", s.Id()))
 	}()
+	s.Lock()
+	defer s.Unlock()
 	if s.isClosed {
-		err = ErrSyncTreeClosed
-		return
+		return ErrSyncTreeClosed
 	}
 	s.onClose(s.Id())
 	s.isClosed = true

commonspace/object/tree/synctree/synctree_test.go

@@ -11,8 +11,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/objectsync"
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
 	"github.com/anyproto/any-sync/nodeconf"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"testing"
 )
 

commonspace/object/tree/synctree/synctreehandler.go

@@ -3,21 +3,18 @@ package synctree
 import (
 	"context"
 	"errors"
-	"sync"
-
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/objectsync/synchandler"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/anyproto/any-sync/util/slice"
 	"github.com/gogo/protobuf/proto"
+	"sync"
 )
 
 var (
 	ErrMessageIsRequest    = errors.New("message is request")
 	ErrMessageIsNotRequest = errors.New("message is not request")
-	ErrMoreThanOneRequest  = errors.New("more than one request for same peer")
 )
 
 type syncTreeHandler struct {
@@ -25,23 +22,21 @@ type syncTreeHandler struct {
 	syncClient   SyncClient
 	syncProtocol TreeSyncProtocol
 	syncStatus   syncstatus.StatusUpdater
+	handlerLock  sync.Mutex
 	spaceId      string
-
-	handlerLock     sync.Mutex
-	pendingRequests map[string]struct{}
-	heads           []string
+	queue        ReceiveQueue
 }
 
 const maxQueueSize = 5
 
 func newSyncTreeHandler(spaceId string, objTree objecttree.ObjectTree, syncClient SyncClient, syncStatus syncstatus.StatusUpdater) synchandler.SyncHandler {
 	return &syncTreeHandler{
-		objTree:         objTree,
-		syncProtocol:    newTreeSyncProtocol(spaceId, objTree, syncClient),
-		syncClient:      syncClient,
-		syncStatus:      syncStatus,
-		spaceId:         spaceId,
-		pendingRequests: make(map[string]struct{}),
+		objTree:      objTree,
+		syncProtocol: newTreeSyncProtocol(spaceId, objTree, syncClient),
+		syncClient:   syncClient,
+		syncStatus:   syncStatus,
+		spaceId:      spaceId,
+		queue:        newReceiveQueue(maxQueueSize),
 	}
 }
 
@@ -53,35 +48,17 @@ func (s *syncTreeHandler) HandleRequest(ctx context.Context, senderId string, re
 	}
 	fullSyncRequest := unmarshalled.GetContent().GetFullSyncRequest()
 	if fullSyncRequest == nil {
-		return nil, ErrMessageIsNotRequest
+		err = ErrMessageIsNotRequest
+		return
 	}
-	// setting pending requests
-	s.handlerLock.Lock()
-	_, exists := s.pendingRequests[senderId]
-	if exists {
-		s.handlerLock.Unlock()
-		return nil, ErrMoreThanOneRequest
-	}
-	s.pendingRequests[senderId] = struct{}{}
-	s.handlerLock.Unlock()
-
-	response, err = s.handleRequest(ctx, senderId, fullSyncRequest)
-
-	// removing pending requests
-	s.handlerLock.Lock()
-	delete(s.pendingRequests, senderId)
-	s.handlerLock.Unlock()
-	return
-}
-
-func (s *syncTreeHandler) handleRequest(ctx context.Context, senderId string, fullSyncRequest *treechangeproto.TreeFullSyncRequest) (response *spacesyncproto.ObjectSyncMessage, err error) {
+	s.syncStatus.HeadsReceive(senderId, request.ObjectId, treechangeproto.GetHeads(unmarshalled))
 	s.objTree.Lock()
 	defer s.objTree.Unlock()
 	treeResp, err := s.syncProtocol.FullSyncRequest(ctx, senderId, fullSyncRequest)
 	if err != nil {
 		return
 	}
-	response, err = spacesyncproto.MarshallSyncMessage(treeResp, s.spaceId, s.objTree.Id())
+	response, err = MarshallTreeMessage(treeResp, s.spaceId, request.ObjectId, "")
 	return
 }
 
@@ -91,41 +68,28 @@ func (s *syncTreeHandler) HandleMessage(ctx context.Context, senderId string, ms
 	if err != nil {
 		return
 	}
-	heads := treechangeproto.GetHeads(unmarshalled)
-	s.syncStatus.HeadsReceive(senderId, msg.ObjectId, heads)
-	s.handlerLock.Lock()
-	// if the update has same heads then returning not to hang on a lock
-	if unmarshalled.GetContent().GetHeadUpdate() != nil && slice.UnsortedEquals(heads, s.heads) {
-		s.handlerLock.Unlock()
+	s.syncStatus.HeadsReceive(senderId, msg.ObjectId, treechangeproto.GetHeads(unmarshalled))
+
+	queueFull := s.queue.AddMessage(senderId, unmarshalled, msg.RequestId)
+	if queueFull {
 		return
 	}
-	s.handlerLock.Unlock()
-	return s.handleMessage(ctx, unmarshalled, senderId)
+
+	return s.handleMessage(ctx, senderId)
 }
 
-func (s *syncTreeHandler) handleMessage(ctx context.Context, msg *treechangeproto.TreeSyncMessage, senderId string) (err error) {
+func (s *syncTreeHandler) handleMessage(ctx context.Context, senderId string) (err error) {
 	s.objTree.Lock()
 	defer s.objTree.Unlock()
-	var (
-		copyHeads = make([]string, 0, len(s.objTree.Heads()))
-		treeId    = s.objTree.Id()
-		content   = msg.GetContent()
-	)
+	msg, _, err := s.queue.GetMessage(senderId)
+	if err != nil {
+		return
+	}
 
-	// getting old heads
-	copyHeads = append(copyHeads, s.objTree.Heads()...)
-	defer func() {
-		// checking if something changed
-		if !slice.UnsortedEquals(copyHeads, s.objTree.Heads()) {
-			s.handlerLock.Lock()
-			defer s.handlerLock.Unlock()
-			s.heads = s.heads[:0]
-			for _, h := range s.objTree.Heads() {
-				s.heads = append(s.heads, h)
-			}
-		}
-	}()
+	defer s.queue.ClearQueue(senderId)
 
+	treeId := s.objTree.Id()
+	content := msg.GetContent()
 	switch {
 	case content.GetHeadUpdate() != nil:
 		var syncReq *treechangeproto.TreeSyncMessage

commonspace/object/tree/synctree/synctreehandler_test.go

@@ -2,16 +2,15 @@ package synctree
 
 import (
 	"context"
+	"github.com/anyproto/any-sync/commonspace/object/tree/synctree/mock_synctree"
+	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
+	"github.com/stretchr/testify/require"
 	"sync"
 	"testing"
 
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree/mock_objecttree"
-	"github.com/anyproto/any-sync/commonspace/object/tree/synctree/mock_synctree"
-	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
-	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
+	"github.com/golang/mock/gomock"
 )
 
 type testObjTreeMock struct {
@@ -53,6 +52,7 @@ type syncHandlerFixture struct {
 	ctrl             *gomock.Controller
 	syncClientMock   *mock_synctree.MockSyncClient
 	objectTreeMock   *testObjTreeMock
+	receiveQueueMock ReceiveQueue
 	syncProtocolMock *mock_synctree.MockTreeSyncProtocol
 	spaceId          string
 	senderId         string
@@ -67,18 +67,20 @@ func newSyncHandlerFixture(t *testing.T) *syncHandlerFixture {
 	syncClientMock := mock_synctree.NewMockSyncClient(ctrl)
 	syncProtocolMock := mock_synctree.NewMockTreeSyncProtocol(ctrl)
 	spaceId := "spaceId"
+	receiveQueue := newReceiveQueue(5)
 
 	syncHandler := &syncTreeHandler{
-		objTree:         objectTreeMock,
-		syncClient:      syncClientMock,
-		syncProtocol:    syncProtocolMock,
-		spaceId:         spaceId,
-		syncStatus:      syncstatus.NewNoOpSyncStatus(),
-		pendingRequests: map[string]struct{}{},
+		objTree:      objectTreeMock,
+		syncClient:   syncClientMock,
+		syncProtocol: syncProtocolMock,
+		spaceId:      spaceId,
+		queue:        receiveQueue,
+		syncStatus:   syncstatus.NewNoOpSyncStatus(),
 	}
 	return &syncHandlerFixture{
 		ctrl:             ctrl,
 		objectTreeMock:   objectTreeMock,
+		receiveQueueMock: receiveQueue,
 		syncProtocolMock: syncProtocolMock,
 		syncClientMock:   syncClientMock,
 		syncHandler:      syncHandler,
@@ -95,68 +97,38 @@ func (fx *syncHandlerFixture) stop() {
 func TestSyncTreeHandler_HandleMessage(t *testing.T) {
 	ctx := context.Background()
 
-	t.Run("handle head update message, heads not equal, request returned", func(t *testing.T) {
+	t.Run("handle head update message", func(t *testing.T) {
 		fx := newSyncHandlerFixture(t)
 		defer fx.stop()
 		treeId := "treeId"
 		chWithId := &treechangeproto.RawTreeChangeWithId{}
-		headUpdate := &treechangeproto.TreeHeadUpdate{
-			Heads: []string{"h3"},
-		}
+		headUpdate := &treechangeproto.TreeHeadUpdate{}
 		treeMsg := treechangeproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(treeMsg, "spaceId", treeId)
+		objectMsg, _ := MarshallTreeMessage(treeMsg, "spaceId", treeId, "")
 
 		syncReq := &treechangeproto.TreeSyncMessage{}
-		fx.syncHandler.heads = []string{"h2"}
 		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
-		fx.objectTreeMock.EXPECT().Heads().Times(2).Return([]string{"h2"})
-		fx.objectTreeMock.EXPECT().Heads().Times(2).Return([]string{"h3"})
 		fx.syncProtocolMock.EXPECT().HeadUpdate(ctx, fx.senderId, gomock.Any()).Return(syncReq, nil)
 		fx.syncClientMock.EXPECT().QueueRequest(fx.senderId, fx.treeId, syncReq).Return(nil)
 
 		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
 		require.NoError(t, err)
-		require.Equal(t, []string{"h3"}, fx.syncHandler.heads)
 	})
 
-	t.Run("handle head update message, heads equal", func(t *testing.T) {
+	t.Run("handle head update message, empty sync request", func(t *testing.T) {
 		fx := newSyncHandlerFixture(t)
 		defer fx.stop()
 		treeId := "treeId"
 		chWithId := &treechangeproto.RawTreeChangeWithId{}
-		headUpdate := &treechangeproto.TreeHeadUpdate{
-			Heads: []string{"h1"},
-		}
+		headUpdate := &treechangeproto.TreeHeadUpdate{}
 		treeMsg := treechangeproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(treeMsg, "spaceId", treeId)
+		objectMsg, _ := MarshallTreeMessage(treeMsg, "spaceId", treeId, "")
 
-		fx.syncHandler.heads = []string{"h1"}
 		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
-
-		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
-		require.NoError(t, err)
-	})
-
-	t.Run("handle head update message, no sync request returned", func(t *testing.T) {
-		fx := newSyncHandlerFixture(t)
-		defer fx.stop()
-		treeId := "treeId"
-		chWithId := &treechangeproto.RawTreeChangeWithId{}
-		headUpdate := &treechangeproto.TreeHeadUpdate{
-			Heads: []string{"h3"},
-		}
-		treeMsg := treechangeproto.WrapHeadUpdate(headUpdate, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(treeMsg, "spaceId", treeId)
-
-		fx.syncHandler.heads = []string{"h2"}
-		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
-		fx.objectTreeMock.EXPECT().Heads().Times(2).Return([]string{"h2"})
-		fx.objectTreeMock.EXPECT().Heads().Times(2).Return([]string{"h3"})
 		fx.syncProtocolMock.EXPECT().HeadUpdate(ctx, fx.senderId, gomock.Any()).Return(nil, nil)
 
 		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
 		require.NoError(t, err)
-		require.Equal(t, []string{"h3"}, fx.syncHandler.heads)
 	})
 
 	t.Run("handle full sync request returns error", func(t *testing.T) {
@@ -164,15 +136,11 @@ func TestSyncTreeHandler_HandleMessage(t *testing.T) {
 		defer fx.stop()
 		treeId := "treeId"
 		chWithId := &treechangeproto.RawTreeChangeWithId{}
-		fullRequest := &treechangeproto.TreeFullSyncRequest{
-			Heads: []string{"h3"},
-		}
+		fullRequest := &treechangeproto.TreeFullSyncRequest{}
 		treeMsg := treechangeproto.WrapFullRequest(fullRequest, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(treeMsg, "spaceId", treeId)
+		objectMsg, _ := MarshallTreeMessage(treeMsg, "spaceId", treeId, "")
 
-		fx.syncHandler.heads = []string{"h2"}
 		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
-		fx.objectTreeMock.EXPECT().Heads().Times(3).Return([]string{"h2"})
 
 		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
 		require.Equal(t, err, ErrMessageIsRequest)
@@ -183,16 +151,11 @@ func TestSyncTreeHandler_HandleMessage(t *testing.T) {
 		defer fx.stop()
 		treeId := "treeId"
 		chWithId := &treechangeproto.RawTreeChangeWithId{}
-		fullSyncResponse := &treechangeproto.TreeFullSyncResponse{
-			Heads: []string{"h3"},
-		}
+		fullSyncResponse := &treechangeproto.TreeFullSyncResponse{}
 		treeMsg := treechangeproto.WrapFullResponse(fullSyncResponse, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(treeMsg, "spaceId", treeId)
+		objectMsg, _ := MarshallTreeMessage(treeMsg, "spaceId", treeId, "")
 
-		fx.syncHandler.heads = []string{"h2"}
 		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
-		fx.objectTreeMock.EXPECT().Heads().Times(2).Return([]string{"h2"})
-		fx.objectTreeMock.EXPECT().Heads().Times(2).Return([]string{"h3"})
 		fx.syncProtocolMock.EXPECT().FullSyncResponse(ctx, fx.senderId, gomock.Any()).Return(nil)
 
 		err := fx.syncHandler.HandleMessage(ctx, fx.senderId, objectMsg)
@@ -210,7 +173,25 @@ func TestSyncTreeHandler_HandleRequest(t *testing.T) {
 		chWithId := &treechangeproto.RawTreeChangeWithId{}
 		fullRequest := &treechangeproto.TreeFullSyncRequest{}
 		treeMsg := treechangeproto.WrapFullRequest(fullRequest, chWithId)
-		objectMsg, _ := spacesyncproto.MarshallSyncMessage(treeMsg, "spaceId", treeId)
+		objectMsg, _ := MarshallTreeMessage(treeMsg, "spaceId", treeId, "")
+
+		syncResp := &treechangeproto.TreeSyncMessage{}
+		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
+		fx.syncProtocolMock.EXPECT().FullSyncRequest(ctx, fx.senderId, gomock.Any()).Return(syncResp, nil)
+
+		res, err := fx.syncHandler.HandleRequest(ctx, fx.senderId, objectMsg)
+		require.NoError(t, err)
+		require.NotNil(t, res)
+	})
+
+	t.Run("handle request", func(t *testing.T) {
+		fx := newSyncHandlerFixture(t)
+		defer fx.stop()
+		treeId := "treeId"
+		chWithId := &treechangeproto.RawTreeChangeWithId{}
+		fullRequest := &treechangeproto.TreeFullSyncRequest{}
+		treeMsg := treechangeproto.WrapFullRequest(fullRequest, chWithId)
+		objectMsg, _ := MarshallTreeMessage(treeMsg, "spaceId", treeId, "")
 
 		syncResp := &treechangeproto.TreeSyncMessage{}
 		fx.objectTreeMock.EXPECT().Id().AnyTimes().Return(fx.treeId)
@@ -231,7 +212,7 @@ func TestSyncTreeHandler_HandleRequest(t *testing.T) {
 		headUpdate := &treechangeproto.TreeHeadUpdate{}
 		headUpdateMsg := treechangeproto.WrapHeadUpdate(headUpdate, chWithId)
 		for _, msg := range []*treechangeproto.TreeSyncMessage{responseMsg, headUpdateMsg} {
-			objectMsg, _ := spacesyncproto.MarshallSyncMessage(msg, "spaceId", treeId)
+			objectMsg, _ := MarshallTreeMessage(msg, "spaceId", treeId, "")
 
 			_, err := fx.syncHandler.HandleRequest(ctx, fx.senderId, objectMsg)
 			require.Equal(t, err, ErrMessageIsNotRequest)

commonspace/object/tree/synctree/treeremotegetter.go

@@ -2,19 +2,16 @@ package synctree
 
 import (
 	"context"
-	"errors"
-
+	"fmt"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/net/peer"
+	"github.com/anyproto/any-sync/net/rpc/rpcerr"
 	"github.com/gogo/protobuf/proto"
 	"go.uber.org/zap"
-)
-
-var (
-	ErrNoResponsiblePeers = errors.New("no responsible peers")
+	"time"
 )
 
 type treeRemoteGetter struct {
@@ -39,7 +36,7 @@ func (t treeRemoteGetter) getPeers(ctx context.Context) (peerIds []string, err e
 		return
 	}
 	if len(respPeers) == 0 {
-		err = ErrNoResponsiblePeers
+		err = fmt.Errorf("no responsible peers")
 		return
 	}
 	for _, p := range respPeers {
@@ -60,13 +57,37 @@ func (t treeRemoteGetter) treeRequest(ctx context.Context, peerId string) (msg *
 	return
 }
 
-func (t treeRemoteGetter) treeRequestLoop(ctx context.Context) (msg *treechangeproto.TreeSyncMessage, err error) {
-	availablePeers, err := t.getPeers(ctx)
-	if err != nil {
-		return
+func (t treeRemoteGetter) treeRequestLoop(ctx context.Context, wait bool) (msg *treechangeproto.TreeSyncMessage, err error) {
+	peerIdx := 0
+Loop:
+	for {
+		select {
+		case <-ctx.Done():
+			return nil, fmt.Errorf("waiting for object %s interrupted, context closed", t.treeId)
+		default:
+			break
+		}
+		availablePeers, err := t.getPeers(ctx)
+		if err != nil {
+			if !wait {
+				return nil, err
+			}
+			select {
+			// wait for peers to connect
+			case <-time.After(1 * time.Second):
+				continue Loop
+			case <-ctx.Done():
+				return nil, fmt.Errorf("waiting for object %s interrupted, context closed", t.treeId)
+			}
+		}
+
+		peerIdx = peerIdx % len(availablePeers)
+		msg, err = t.treeRequest(ctx, availablePeers[peerIdx])
+		if err == nil || !wait {
+			return msg, err
+		}
+		peerIdx++
 	}
-	// in future we will try to load from different peers
-	return t.treeRequest(ctx, availablePeers[0])
 }
 
 func (t treeRemoteGetter) getTree(ctx context.Context) (treeStorage treestorage.TreeStorage, isRemote bool, err error) {
@@ -88,15 +109,22 @@ func (t treeRemoteGetter) getTree(ctx context.Context) (treeStorage treestorage.
 	}
 
 	isRemote = true
-	resp, err := t.treeRequestLoop(ctx)
+	resp, err := t.treeRequestLoop(ctx, t.deps.WaitTreeRemoteSync)
 	if err != nil {
 		return
 	}
-	fullSyncResp := resp.GetContent().GetFullSyncResponse()
-	if fullSyncResp == nil {
+	switch {
+	case resp.GetContent().GetErrorResponse() != nil:
+		errResp := resp.GetContent().GetErrorResponse()
+		err = rpcerr.Err(errResp.ErrCode)
+		return
+	case resp.GetContent().GetFullSyncResponse() == nil:
 		err = treechangeproto.ErrUnexpected
 		return
+	default:
+		break
 	}
+	fullSyncResp := resp.GetContent().GetFullSyncResponse()
 
 	payload := treestorage.TreeStorageCreatePayload{
 		RootRawChange: resp.RootChange,

commonspace/object/tree/synctree/treeremotegetter_test.go

@@ -1,87 +0,0 @@
-package synctree
-
-import (
-	"context"
-	"fmt"
-	"testing"
-
-	"github.com/anyproto/any-sync/commonspace/object/tree/synctree/mock_synctree"
-	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
-	"github.com/anyproto/any-sync/commonspace/peermanager/mock_peermanager"
-	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/net/peer"
-	"github.com/anyproto/any-sync/net/peer/mock_peer"
-	"github.com/gogo/protobuf/proto"
-	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
-)
-
-type treeRemoteGetterFixture struct {
-	ctrl *gomock.Controller
-
-	treeGetter     treeRemoteGetter
-	syncClientMock *mock_synctree.MockSyncClient
-	peerGetterMock *mock_peermanager.MockPeerManager
-}
-
-func newTreeRemoteGetterFixture(t *testing.T) *treeRemoteGetterFixture {
-	ctrl := gomock.NewController(t)
-	syncClientMock := mock_synctree.NewMockSyncClient(ctrl)
-	peerGetterMock := mock_peermanager.NewMockPeerManager(ctrl)
-	treeGetter := treeRemoteGetter{
-		deps: BuildDeps{
-			SyncClient: syncClientMock,
-			PeerGetter: peerGetterMock,
-		},
-		treeId: "treeId",
-	}
-	return &treeRemoteGetterFixture{
-		ctrl:           ctrl,
-		treeGetter:     treeGetter,
-		syncClientMock: syncClientMock,
-		peerGetterMock: peerGetterMock,
-	}
-}
-
-func (fx *treeRemoteGetterFixture) stop() {
-	fx.ctrl.Finish()
-}
-
-func TestTreeRemoteGetter(t *testing.T) {
-	ctx := context.Background()
-	peerId := "peerId"
-	treeRequest := &treechangeproto.TreeSyncMessage{}
-	treeResponse := &treechangeproto.TreeSyncMessage{
-		RootChange: &treechangeproto.RawTreeChangeWithId{Id: "id"},
-	}
-	marshalled, _ := proto.Marshal(treeResponse)
-	objectResponse := &spacesyncproto.ObjectSyncMessage{
-		Payload: marshalled,
-	}
-
-	t.Run("request works", func(t *testing.T) {
-		fx := newTreeRemoteGetterFixture(t)
-		defer fx.stop()
-		mockPeer := mock_peer.NewMockPeer(fx.ctrl)
-		mockPeer.EXPECT().Id().AnyTimes().Return(peerId)
-		fx.peerGetterMock.EXPECT().GetResponsiblePeers(ctx).Return([]peer.Peer{mockPeer}, nil)
-		fx.syncClientMock.EXPECT().CreateNewTreeRequest().Return(treeRequest)
-		fx.syncClientMock.EXPECT().SendRequest(ctx, peerId, fx.treeGetter.treeId, treeRequest).Return(objectResponse, nil)
-		resp, err := fx.treeGetter.treeRequestLoop(ctx)
-		require.NoError(t, err)
-		require.Equal(t, "id", resp.RootChange.Id)
-	})
-
-	t.Run("request fails", func(t *testing.T) {
-		fx := newTreeRemoteGetterFixture(t)
-		defer fx.stop()
-		treeRequest := &treechangeproto.TreeSyncMessage{}
-		mockPeer := mock_peer.NewMockPeer(fx.ctrl)
-		mockPeer.EXPECT().Id().AnyTimes().Return(peerId)
-		fx.peerGetterMock.EXPECT().GetResponsiblePeers(ctx).Return([]peer.Peer{mockPeer}, nil)
-		fx.syncClientMock.EXPECT().CreateNewTreeRequest().Return(treeRequest)
-		fx.syncClientMock.EXPECT().SendRequest(ctx, peerId, fx.treeGetter.treeId, treeRequest).AnyTimes().Return(nil, fmt.Errorf("some"))
-		_, err := fx.treeGetter.treeRequestLoop(ctx)
-		require.Error(t, err)
-	})
-}

commonspace/object/tree/synctree/treesyncprotocol.go

@@ -2,7 +2,6 @@ package synctree
 
 import (
 	"context"
-
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
@@ -60,7 +59,7 @@ func (t *treeSyncProtocol) HeadUpdate(ctx context.Context, senderId string, upda
 	// isEmptyUpdate is sent when the tree is brought up from cache
 	if isEmptyUpdate {
 		headEquals := slice.UnsortedEquals(objTree.Heads(), update.Heads)
-		log.DebugCtx(ctx, "is empty update", zap.Bool("headEquals", headEquals))
+		log.DebugCtx(ctx, "is empty update", zap.String("treeId", objTree.Id()), zap.Bool("headEquals", headEquals))
 		if headEquals {
 			return
 		}
@@ -70,7 +69,7 @@ func (t *treeSyncProtocol) HeadUpdate(ctx context.Context, senderId string, upda
 		return
 	}
 
-	if t.hasHeads(objTree, update.Heads) {
+	if t.alreadyHasHeads(objTree, update.Heads) {
 		return
 	}
 
@@ -82,7 +81,7 @@ func (t *treeSyncProtocol) HeadUpdate(ctx context.Context, senderId string, upda
 		return
 	}
 
-	if t.hasHeads(objTree, update.Heads) {
+	if t.alreadyHasHeads(objTree, update.Heads) {
 		return
 	}
 
@@ -109,7 +108,7 @@ func (t *treeSyncProtocol) FullSyncRequest(ctx context.Context, senderId string,
 		}
 	}()
 
-	if len(request.Changes) != 0 && !t.hasHeads(objTree, request.Heads) {
+	if len(request.Changes) != 0 && !t.alreadyHasHeads(objTree, request.Heads) {
 		_, err = objTree.AddRawChanges(ctx, objecttree.RawChangesPayload{
 			NewHeads:   request.Heads,
 			RawChanges: request.Changes,
@@ -137,7 +136,7 @@ func (t *treeSyncProtocol) FullSyncResponse(ctx context.Context, senderId string
 			log.DebugCtx(ctx, "full sync response succeeded")
 		}
 	}()
-	if t.hasHeads(objTree, response.Heads) {
+	if t.alreadyHasHeads(objTree, response.Heads) {
 		return
 	}
 
@@ -148,6 +147,6 @@ func (t *treeSyncProtocol) FullSyncResponse(ctx context.Context, senderId string
 	return
 }
 
-func (t *treeSyncProtocol) hasHeads(ot objecttree.ObjectTree, heads []string) bool {
+func (t *treeSyncProtocol) alreadyHasHeads(ot objecttree.ObjectTree, heads []string) bool {
 	return slice.UnsortedEquals(ot.Heads(), heads) || ot.HasChanges(heads...)
 }

commonspace/object/tree/synctree/treesyncprotocol_test.go

@@ -8,8 +8,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree/mock_objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/synctree/mock_synctree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"testing"
 )
 

commonspace/object/tree/synctree/updatelistener/mock_updatelistener/mock_updatelistener.go

@@ -8,7 +8,7 @@ import (
 	reflect "reflect"
 
 	objecttree "github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockUpdateListener is a mock of UpdateListener interface.

commonspace/object/tree/synctree/utils_test.go

@@ -157,10 +157,6 @@ func (r *requestPeerManager) GetResponsiblePeers(ctx context.Context) (peers []p
 	return nil, nil
 }
 
-func (r *requestPeerManager) GetNodePeers(ctx context.Context) (peers []peer.Peer, err error) {
-	return nil, nil
-}
-
 // testSyncHandler is the wrapper around individual tree to test sync protocol
 type testSyncHandler struct {
 	synchandler.SyncHandler

commonspace/object/tree/treestorage/mock_treestorage/mock_treestorage.go

@@ -9,7 +9,7 @@ import (
 	reflect "reflect"
 
 	treechangeproto "github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockTreeStorage is a mock of TreeStorage interface.

commonspace/object/treemanager/mock_treemanager/mock_treemanager.go

@@ -11,7 +11,7 @@ import (
 	app "github.com/anyproto/any-sync/app"
 	objecttree "github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	treemanager "github.com/anyproto/any-sync/commonspace/object/treemanager"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockTreeManager is a mock of TreeManager interface.

commonspace/objectmanager/objectmanager.go

@@ -41,7 +41,7 @@ func (o *objectManager) Init(a *app.App) (err error) {
 	o.spaceId = state.SpaceId
 	o.spaceIsClosed = state.SpaceIsClosed
 	settingsObject := a.MustComponent(settings.CName).(settings.Settings).SettingsObject()
-	acl := a.MustComponent(syncacl.CName).(syncacl.SyncAcl)
+	acl := a.MustComponent(syncacl.CName).(*syncacl.SyncAcl)
 	o.AddObject(settingsObject)
 	o.AddObject(acl)
 	return nil

commonspace/objectsync/mock_objectsync/mock_objectsync.go

@@ -12,7 +12,7 @@ import (
 	app "github.com/anyproto/any-sync/app"
 	objectsync "github.com/anyproto/any-sync/commonspace/objectsync"
 	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockObjectSync is a mock of ObjectSync interface.

commonspace/objectsync/objectsync.go

@@ -4,9 +4,6 @@ package objectsync
 import (
 	"context"
 	"fmt"
-	"sync/atomic"
-	"time"
-
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/treemanager"
@@ -16,6 +13,8 @@ import (
 	"github.com/anyproto/any-sync/util/multiqueue"
 	"github.com/cheggaaa/mb/v3"
 	"github.com/gogo/protobuf/proto"
+	"sync/atomic"
+	"time"
 
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/object/syncobjectgetter"
@@ -80,7 +79,7 @@ func (s *objectSync) Init(a *app.App) (err error) {
 	}
 	s.spaceIsDeleted = sharedData.SpaceIsDeleted
 	s.spaceId = sharedData.SpaceId
-	s.handleQueue = multiqueue.New[HandleMessage](s.processHandleMessage, 30)
+	s.handleQueue = multiqueue.New[HandleMessage](s.processHandleMessage, 100)
 	return nil
 }
 
@@ -149,6 +148,9 @@ func (s *objectSync) processHandleMessage(msg HandleMessage) {
 			err = context.DeadlineExceeded
 			return
 		}
+		var cancel context.CancelFunc
+		ctx, cancel = context.WithDeadline(ctx, msg.Deadline)
+		defer cancel()
 	}
 	if err = s.handleMessage(ctx, msg.SenderId, msg.Message); err != nil {
 		if msg.Message.ObjectId != "" {

commonspace/objecttreebuilder/mock_objecttreebuilder/mock_objecttreebuilder.go

@@ -12,7 +12,7 @@ import (
 	updatelistener "github.com/anyproto/any-sync/commonspace/object/tree/synctree/updatelistener"
 	treestorage "github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	objecttreebuilder "github.com/anyproto/any-sync/commonspace/objecttreebuilder"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockTreeBuilder is a mock of TreeBuilder interface.

commonspace/objecttreebuilder/treebuilder.go

@@ -4,8 +4,6 @@ package objecttreebuilder
 import (
 	"context"
 	"errors"
-	"sync/atomic"
-
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/headsync"
@@ -24,11 +22,13 @@ import (
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
 	"github.com/anyproto/any-sync/nodeconf"
 	"go.uber.org/zap"
+	"sync/atomic"
 )
 
 type BuildTreeOpts struct {
-	Listener    updatelistener.UpdateListener
-	TreeBuilder objecttree.BuildObjectTreeFunc
+	Listener           updatelistener.UpdateListener
+	WaitTreeRemoteSync bool
+	TreeBuilder        objecttree.BuildObjectTreeFunc
 }
 
 const CName = "common.commonspace.objecttreebuilder"
@@ -82,7 +82,7 @@ func (t *treeBuilder) Init(a *app.App) (err error) {
 	t.isClosed = state.SpaceIsClosed
 	t.treesUsed = state.TreesUsed
 	t.builder = state.TreeBuilderFunc
-	t.aclList = a.MustComponent(syncacl.CName).(syncacl.SyncAcl)
+	t.aclList = a.MustComponent(syncacl.CName).(*syncacl.SyncAcl)
 	t.spaceStorage = a.MustComponent(spacestorage.CName).(spacestorage.SpaceStorage)
 	t.configuration = a.MustComponent(nodeconf.CName).(nodeconf.NodeConf)
 	t.headsNotifiable = a.MustComponent(headsync.CName).(headsync.HeadSync)
@@ -110,17 +110,18 @@ func (t *treeBuilder) BuildTree(ctx context.Context, id string, opts BuildTreeOp
 		treeBuilder = t.builder
 	}
 	deps := synctree.BuildDeps{
-		SpaceId:         t.spaceId,
-		SyncClient:      t.syncClient,
-		Configuration:   t.configuration,
-		HeadNotifiable:  t.headsNotifiable,
-		Listener:        opts.Listener,
-		AclList:         t.aclList,
-		SpaceStorage:    t.spaceStorage,
-		OnClose:         t.onClose,
-		SyncStatus:      t.syncStatus,
-		PeerGetter:      t.peerManager,
-		BuildObjectTree: treeBuilder,
+		SpaceId:            t.spaceId,
+		SyncClient:         t.syncClient,
+		Configuration:      t.configuration,
+		HeadNotifiable:     t.headsNotifiable,
+		Listener:           opts.Listener,
+		AclList:            t.aclList,
+		SpaceStorage:       t.spaceStorage,
+		OnClose:            t.onClose,
+		SyncStatus:         t.syncStatus,
+		WaitTreeRemoteSync: opts.WaitTreeRemoteSync,
+		PeerGetter:         t.peerManager,
+		BuildObjectTree:    treeBuilder,
 	}
 	t.treesUsed.Add(1)
 	t.log.Debug("incrementing counter", zap.String("id", id), zap.Int32("trees", t.treesUsed.Load()))

commonspace/payloads.go

@@ -2,22 +2,20 @@ package commonspace
 
 import (
 	"errors"
-	"hash/fnv"
-	"math/rand"
-	"strconv"
-	"strings"
-	"time"
-
 	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/list"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/util/cidutil"
 	"github.com/anyproto/any-sync/util/crypto"
 	"github.com/gogo/protobuf/proto"
+	"hash/fnv"
+	"math/rand"
+	"strconv"
+	"strings"
+	"time"
 )
 
 const (
@@ -73,7 +71,7 @@ func storagePayloadForSpaceCreate(payload SpaceCreatePayload) (storagePayload sp
 
 	// building acl root
 	keyStorage := crypto.NewKeyStorage()
-	aclBuilder := list.NewAclRecordBuilder("", keyStorage, nil, list.NoOpAcceptorVerifier{})
+	aclBuilder := list.NewAclRecordBuilder("", keyStorage)
 	aclRoot, err := aclBuilder.BuildRoot(list.RootContent{
 		PrivKey:          payload.SigningKey,
 		MasterKey:        payload.MasterKey,
@@ -160,7 +158,7 @@ func storagePayloadForSpaceDerive(payload SpaceDerivePayload) (storagePayload sp
 
 	// building acl root
 	keyStorage := crypto.NewKeyStorage()
-	aclBuilder := list.NewAclRecordBuilder("", keyStorage, nil, list.NoOpAcceptorVerifier{})
+	aclBuilder := list.NewAclRecordBuilder("", keyStorage)
 	aclRoot, err := aclBuilder.BuildRoot(list.RootContent{
 		PrivKey:   payload.SigningKey,
 		MasterKey: payload.MasterKey,
@@ -256,12 +254,12 @@ func ValidateSpaceHeader(rawHeaderWithId *spacesyncproto.RawSpaceHeaderWithId, i
 	return
 }
 
-func validateCreateSpaceAclPayload(rawWithId *consensusproto.RawRecordWithId) (spaceId string, err error) {
+func validateCreateSpaceAclPayload(rawWithId *aclrecordproto.RawAclRecordWithId) (spaceId string, err error) {
 	if !cidutil.VerifyCid(rawWithId.Payload, rawWithId.Id) {
 		err = objecttree.ErrIncorrectCid
 		return
 	}
-	var rawAcl consensusproto.RawRecord
+	var rawAcl aclrecordproto.RawAclRecord
 	err = proto.Unmarshal(rawWithId.Payload, &rawAcl)
 	if err != nil {
 		return

commonspace/payloads_test.go

@@ -2,22 +2,20 @@ package commonspace
 
 import (
 	"fmt"
-	"math/rand"
-	"strconv"
-	"testing"
-	"time"
-
 	"github.com/anyproto/any-sync/commonspace/object/accountdata"
 	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/util/cidutil"
 	"github.com/anyproto/any-sync/util/crypto"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+	"math/rand"
+	"strconv"
+	"testing"
+	"time"
 )
 
 func TestSuccessHeaderPayloadForSpaceCreate(t *testing.T) {
@@ -190,14 +188,14 @@ func TestFailAclPayloadSpace_IncorrectCid(t *testing.T) {
 	marshalled, err := aclRoot.Marshal()
 	require.NoError(t, err)
 	signature, err := accountKeys.SignKey.Sign(marshalled)
-	rawAclRecord := &consensusproto.RawRecord{
+	rawAclRecord := &aclrecordproto.RawAclRecord{
 		Payload:   marshalled,
 		Signature: signature,
 	}
 	marshalledRaw, err := rawAclRecord.Marshal()
 	require.NoError(t, err)
 	aclHeadId := "rand"
-	rawWithId := &consensusproto.RawRecordWithId{
+	rawWithId := &aclrecordproto.RawAclRecordWithId{
 		Payload: marshalledRaw,
 		Id:      aclHeadId,
 	}
@@ -232,7 +230,7 @@ func TestFailedAclPayloadSpace_IncorrectSignature(t *testing.T) {
 	}
 	marshalled, err := aclRoot.Marshal()
 	require.NoError(t, err)
-	rawAclRecord := &consensusproto.RawRecord{
+	rawAclRecord := &aclrecordproto.RawAclRecord{
 		Payload:   marshalled,
 		Signature: marshalled,
 	}
@@ -240,7 +238,7 @@ func TestFailedAclPayloadSpace_IncorrectSignature(t *testing.T) {
 	require.NoError(t, err)
 	aclHeadId, err := cidutil.NewCidFromBytes(marshalledRaw)
 	require.NoError(t, err)
-	rawWithId := &consensusproto.RawRecordWithId{
+	rawWithId := &aclrecordproto.RawAclRecordWithId{
 		Payload: marshalledRaw,
 		Id:      aclHeadId,
 	}
@@ -288,7 +286,7 @@ func TestFailedAclPayloadSpace_IncorrectIdentitySignature(t *testing.T) {
 		return
 	}
 	signature, err := accountKeys.SignKey.Sign(marshalled)
-	rawAclRecord := &consensusproto.RawRecord{
+	rawAclRecord := &aclrecordproto.RawAclRecord{
 		Payload:   marshalled,
 		Signature: signature,
 	}
@@ -300,7 +298,7 @@ func TestFailedAclPayloadSpace_IncorrectIdentitySignature(t *testing.T) {
 	if err != nil {
 		return
 	}
-	rawWithId := &consensusproto.RawRecordWithId{
+	rawWithId := &aclrecordproto.RawAclRecordWithId{
 		Payload: marshalledRaw,
 		Id:      aclHeadId,
 	}
@@ -542,7 +540,7 @@ func rawSettingsPayload(accountKeys *accountdata.AccountKeys, spaceId, aclHeadId
 	return
 }
 
-func rawAclWithId(accountKeys *accountdata.AccountKeys, spaceId string) (aclHeadId string, rawWithId *consensusproto.RawRecordWithId, err error) {
+func rawAclWithId(accountKeys *accountdata.AccountKeys, spaceId string) (aclHeadId string, rawWithId *aclrecordproto.RawAclRecordWithId, err error) {
 	// TODO: use same storage creation methods as we use in spaces
 	readKeyBytes := make([]byte, 32)
 	_, err = rand.Read(readKeyBytes)
@@ -584,7 +582,7 @@ func rawAclWithId(accountKeys *accountdata.AccountKeys, spaceId string) (aclHead
 		return
 	}
 	signature, err := accountKeys.SignKey.Sign(marshalled)
-	rawAclRecord := &consensusproto.RawRecord{
+	rawAclRecord := &aclrecordproto.RawAclRecord{
 		Payload:   marshalled,
 		Signature: signature,
 	}
@@ -596,7 +594,7 @@ func rawAclWithId(accountKeys *accountdata.AccountKeys, spaceId string) (aclHead
 	if err != nil {
 		return
 	}
-	rawWithId = &consensusproto.RawRecordWithId{
+	rawWithId = &aclrecordproto.RawAclRecordWithId{
 		Payload: marshalledRaw,
 		Id:      aclHeadId,
 	}

commonspace/peermanager/mock_peermanager/mock_peermanager.go

@@ -11,7 +11,7 @@ import (
 	app "github.com/anyproto/any-sync/app"
 	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	peer "github.com/anyproto/any-sync/net/peer"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockPeerManager is a mock of PeerManager interface.
@@ -51,21 +51,6 @@ func (mr *MockPeerManagerMockRecorder) Broadcast(arg0, arg1 interface{}) *gomock
 	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Broadcast", reflect.TypeOf((*MockPeerManager)(nil).Broadcast), arg0, arg1)
 }
 
-// GetNodePeers mocks base method.
-func (m *MockPeerManager) GetNodePeers(arg0 context.Context) ([]peer.Peer, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "GetNodePeers", arg0)
-	ret0, _ := ret[0].([]peer.Peer)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// GetNodePeers indicates an expected call of GetNodePeers.
-func (mr *MockPeerManagerMockRecorder) GetNodePeers(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "GetNodePeers", reflect.TypeOf((*MockPeerManager)(nil).GetNodePeers), arg0)
-}
-
 // GetResponsiblePeers mocks base method.
 func (m *MockPeerManager) GetResponsiblePeers(arg0 context.Context) ([]peer.Peer, error) {
 	m.ctrl.T.Helper()

commonspace/peermanager/peermanager.go

@@ -18,10 +18,8 @@ type PeerManager interface {
 	SendPeer(ctx context.Context, peerId string, msg *spacesyncproto.ObjectSyncMessage) (err error)
 	// Broadcast sends a message to all subscribed peers
 	Broadcast(ctx context.Context, msg *spacesyncproto.ObjectSyncMessage) (err error)
-	// GetResponsiblePeers dials or gets from cache responsible peers
+	// GetResponsiblePeers dials or gets from cache responsible peers to unary operations
 	GetResponsiblePeers(ctx context.Context) (peers []peer.Peer, err error)
-	// GetNodePeers dials or gets from cache node peers
-	GetNodePeers(ctx context.Context) (peers []peer.Peer, err error)
 }
 
 type PeerManagerProvider interface {

commonspace/requestmanager/requestmanager.go

@@ -2,18 +2,16 @@ package requestmanager
 
 import (
 	"context"
-	"sync"
-
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/objectsync"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	"github.com/anyproto/any-sync/net/peer"
 	"github.com/anyproto/any-sync/net/pool"
-	"github.com/anyproto/any-sync/net/rpc/rpcerr"
 	"github.com/anyproto/any-sync/net/streampool"
 	"go.uber.org/zap"
 	"storj.io/drpc"
+	"sync"
 )
 
 const CName = "common.commonspace.requestmanager"
@@ -124,6 +122,5 @@ func (r *requestManager) doRequest(ctx context.Context, peerId string, msg *spac
 		resp, err = cl.ObjectSync(ctx, msg)
 		return err
 	})
-	err = rpcerr.Unwrap(err)
 	return
 }

commonspace/requestmanager/requestmanager_test.go

@@ -2,9 +2,6 @@ package requestmanager
 
 import (
 	"context"
-	"sync"
-	"testing"
-
 	"github.com/anyproto/any-sync/commonspace/objectsync"
 	"github.com/anyproto/any-sync/commonspace/objectsync/mock_objectsync"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
@@ -12,10 +9,13 @@ import (
 	"github.com/anyproto/any-sync/net/peer"
 	"github.com/anyproto/any-sync/net/peer/mock_peer"
 	"github.com/anyproto/any-sync/net/pool/mock_pool"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"storj.io/drpc"
 	"storj.io/drpc/drpcconn"
+	"sync"
+	"testing"
+	"time"
 )
 
 type fixture struct {
@@ -146,7 +146,6 @@ func TestRequestManager_QueueRequest(t *testing.T) {
 		_, ok = msgs.Load("otherId1")
 		require.True(t, ok)
 		close(msgRelease)
-		fx.requestManager.Close(context.Background())
 	})
 
 	t.Run("no requests after close", func(t *testing.T) {
@@ -180,7 +179,11 @@ func TestRequestManager_QueueRequest(t *testing.T) {
 
 		fx.requestManager.Close(context.Background())
 		close(msgRelease)
+		// waiting to know if the second one is not taken
+		// because the manager is now closed
+		time.Sleep(100 * time.Millisecond)
 		_, ok = msgs.Load("id2")
 		require.False(t, ok)
+
 	})
 }

commonspace/settings/deleter_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	"github.com/anyproto/any-sync/commonspace/object/treemanager/mock_treemanager"
 	"github.com/anyproto/any-sync/commonspace/spacestorage/mock_spacestorage"
-	"go.uber.org/mock/gomock"
+	"github.com/golang/mock/gomock"
 	"testing"
 )
 

commonspace/settings/deletionmanager_test.go

@@ -6,8 +6,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/object/treemanager/mock_treemanager"
 	"github.com/anyproto/any-sync/commonspace/settings/mock_settings"
 	"github.com/anyproto/any-sync/commonspace/settings/settingsstate"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"testing"
 )
 

commonspace/settings/mock_settings/mock_settings.go

@@ -9,7 +9,7 @@ import (
 	reflect "reflect"
 
 	settingsstate "github.com/anyproto/any-sync/commonspace/settings/settingsstate"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockDeletionManager is a mock of DeletionManager interface.

commonspace/settings/settings.go

@@ -2,8 +2,6 @@ package settings
 
 import (
 	"context"
-	"sync/atomic"
-
 	"github.com/anyproto/any-sync/accountservice"
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/commonspace/deletionstate"
@@ -18,6 +16,7 @@ import (
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/nodeconf"
 	"go.uber.org/zap"
+	"sync/atomic"
 )
 
 const CName = "common.commonspace.settings"
@@ -62,7 +61,8 @@ func (s *settings) Init(a *app.App) (err error) {
 	deps := Deps{
 		BuildFunc: func(ctx context.Context, id string, listener updatelistener.UpdateListener) (t synctree.SyncTree, err error) {
 			res, err := s.treeBuilder.BuildTree(ctx, id, objecttreebuilder.BuildTreeOpts{
-				Listener: listener,
+				Listener:           listener,
+				WaitTreeRemoteSync: false,
 				// space settings document should not have empty data
 				TreeBuilder: objecttree.BuildObjectTree,
 			})

commonspace/settings/settingsobject_test.go

@@ -16,8 +16,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/settings/settingsstate"
 	"github.com/anyproto/any-sync/commonspace/settings/settingsstate/mock_settingsstate"
 	"github.com/anyproto/any-sync/commonspace/spacestorage/mock_spacestorage"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"sync"
 	"testing"
 	"time"

commonspace/settings/settingsstate/mock_settingsstate/mock_settingsstate.go

@@ -9,7 +9,7 @@ import (
 
 	objecttree "github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	settingsstate "github.com/anyproto/any-sync/commonspace/settings/settingsstate"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockStateBuilder is a mock of StateBuilder interface.

commonspace/settings/settingsstate/statebuilder_test.go

@@ -4,8 +4,8 @@ import (
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree/mock_objecttree"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
 	"testing"
 )
 

commonspace/space.go

@@ -9,13 +9,11 @@ import (
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/objectsync"
 	"github.com/anyproto/any-sync/commonspace/objecttreebuilder"
-	"github.com/anyproto/any-sync/commonspace/peermanager"
 	"github.com/anyproto/any-sync/commonspace/settings"
 	"github.com/anyproto/any-sync/commonspace/spacestate"
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/anyproto/any-sync/net/peer"
 	"github.com/anyproto/any-sync/util/crypto"
 	"go.uber.org/zap"
 	"strconv"
@@ -61,7 +59,6 @@ func NewSpaceId(id string, repKey uint64) string {
 type Space interface {
 	Id() string
 	Init(ctx context.Context) error
-	Acl() list.AclList
 
 	StoredIds() []string
 	DebugAllHeads() []headsync.TreeHeads
@@ -75,8 +72,6 @@ type Space interface {
 	SpaceDeleteRawChange(ctx context.Context) (raw *treechangeproto.RawTreeChangeWithId, err error)
 	DeleteSpace(ctx context.Context, deleteChange *treechangeproto.RawTreeChangeWithId) (err error)
 
-	GetNodePeers(ctx context.Context) (peer []peer.Peer, err error)
-
 	HandleMessage(ctx context.Context, msg objectsync.HandleMessage) (err error)
 	HandleSyncRequest(ctx context.Context, req *spacesyncproto.ObjectSyncMessage) (resp *spacesyncproto.ObjectSyncMessage, err error)
 	HandleRangeRequest(ctx context.Context, req *spacesyncproto.HeadSyncRequest) (resp *spacesyncproto.HeadSyncResponse, err error)
@@ -93,7 +88,6 @@ type space struct {
 	app   *app.App
 
 	treeBuilder objecttreebuilder.TreeBuilderComponent
-	peerManager peermanager.PeerManager
 	headSync    headsync.HeadSync
 	objectSync  objectsync.ObjectSync
 	syncStatus  syncstatus.StatusService
@@ -159,14 +153,6 @@ func (s *space) TreeBuilder() objecttreebuilder.TreeBuilder {
 	return s.treeBuilder
 }
 
-func (s *space) GetNodePeers(ctx context.Context) (peer []peer.Peer, err error) {
-	return s.peerManager.GetNodePeers(ctx)
-}
-
-func (s *space) Acl() list.AclList {
-	return s.aclList
-}
-
 func (s *space) Id() string {
 	return s.state.SpaceId
 }
@@ -182,7 +168,6 @@ func (s *space) Init(ctx context.Context) (err error) {
 	s.settings = s.app.MustComponent(settings.CName).(settings.Settings)
 	s.objectSync = s.app.MustComponent(objectsync.CName).(objectsync.ObjectSync)
 	s.storage = s.app.MustComponent(spacestorage.CName).(spacestorage.SpaceStorage)
-	s.peerManager = s.app.MustComponent(peermanager.CName).(peermanager.PeerManager)
 	s.aclList = s.app.MustComponent(syncacl.CName).(list.AclList)
 	s.header, err = s.storage.SpaceHeader()
 	return

commonspace/spaceservice.go

@@ -2,8 +2,6 @@ package commonspace
 
 import (
 	"context"
-	"sync/atomic"
-
 	"github.com/anyproto/any-sync/accountservice"
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/app/logger"
@@ -11,6 +9,7 @@ import (
 	"github.com/anyproto/any-sync/commonspace/credentialprovider"
 	"github.com/anyproto/any-sync/commonspace/deletionstate"
 	"github.com/anyproto/any-sync/commonspace/headsync"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/syncacl"
 	"github.com/anyproto/any-sync/commonspace/object/tree/objecttree"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
@@ -25,13 +24,13 @@ import (
 	"github.com/anyproto/any-sync/commonspace/spacestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
 	"github.com/anyproto/any-sync/commonspace/syncstatus"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 	"github.com/anyproto/any-sync/metric"
 	"github.com/anyproto/any-sync/net/peer"
 	"github.com/anyproto/any-sync/net/pool"
 	"github.com/anyproto/any-sync/net/rpc/rpcerr"
 	"github.com/anyproto/any-sync/nodeconf"
 	"storj.io/drpc"
+	"sync/atomic"
 )
 
 const CName = "common.commonspace"
@@ -194,7 +193,7 @@ func (s *spaceService) NewSpace(ctx context.Context, id string) (Space, error) {
 
 func (s *spaceService) addSpaceStorage(ctx context.Context, spaceDescription SpaceDescription) (st spacestorage.SpaceStorage, err error) {
 	payload := spacestorage.SpaceStorageCreatePayload{
-		AclWithId: &consensusproto.RawRecordWithId{
+		AclWithId: &aclrecordproto.RawAclRecordWithId{
 			Payload: spaceDescription.AclPayload,
 			Id:      spaceDescription.AclId,
 		},
@@ -241,7 +240,7 @@ func (s *spaceService) getSpaceStorageFromRemote(ctx context.Context, id string)
 	}
 
 	st, err = s.createSpaceStorage(spacestorage.SpaceStorageCreatePayload{
-		AclWithId: &consensusproto.RawRecordWithId{
+		AclWithId: &aclrecordproto.RawAclRecordWithId{
 			Payload: res.Payload.AclPayload,
 			Id:      res.Payload.AclPayloadId,
 		},

commonspace/spacestorage/inmemorystorage.go

@@ -2,14 +2,12 @@ package spacestorage
 
 import (
 	"context"
-
 	"github.com/anyproto/any-sync/app"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/liststorage"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-
 	"sync"
 )
 
@@ -42,7 +40,7 @@ func (i *InMemorySpaceStorage) Name() (name string) {
 }
 
 func NewInMemorySpaceStorage(payload SpaceStorageCreatePayload) (SpaceStorage, error) {
-	aclStorage, err := liststorage.NewInMemoryAclListStorage(payload.AclWithId.Id, []*consensusproto.RawRecordWithId{payload.AclWithId})
+	aclStorage, err := liststorage.NewInMemoryAclListStorage(payload.AclWithId.Id, []*aclrecordproto.RawAclRecordWithId{payload.AclWithId})
 	if err != nil {
 		return nil, err
 	}

commonspace/spacestorage/mock_spacestorage/mock_spacestorage.go

@@ -13,7 +13,7 @@ import (
 	treechangeproto "github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	treestorage "github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 )
 
 // MockSpaceStorage is a mock of SpaceStorage interface.

commonspace/spacestorage/spacestorage.go

@@ -4,13 +4,12 @@ package spacestorage
 import (
 	"context"
 	"errors"
-
 	"github.com/anyproto/any-sync/app"
+	"github.com/anyproto/any-sync/commonspace/object/acl/aclrecordproto"
 	"github.com/anyproto/any-sync/commonspace/object/acl/liststorage"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treechangeproto"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
 	"github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
 )
 
 const CName = "common.commonspace.spacestorage"
@@ -48,7 +47,7 @@ type SpaceStorage interface {
 }
 
 type SpaceStorageCreatePayload struct {
-	AclWithId           *consensusproto.RawRecordWithId
+	AclWithId           *aclrecordproto.RawAclRecordWithId
 	SpaceHeaderWithId   *spacesyncproto.RawSpaceHeaderWithId
 	SpaceSettingsWithId *treechangeproto.RawTreeChangeWithId
 }

commonspace/spacesyncproto/mock_spacesyncproto/mock_spacesyncproto.go

@@ -9,7 +9,7 @@ import (
 	reflect "reflect"
 
 	spacesyncproto "github.com/anyproto/any-sync/commonspace/spacesyncproto"
-	gomock "go.uber.org/mock/gomock"
+	gomock "github.com/golang/mock/gomock"
 	drpc "storj.io/drpc"
 )
 
@@ -36,36 +36,6 @@ func (m *MockDRPCSpaceSyncClient) EXPECT() *MockDRPCSpaceSyncClientMockRecorder
 	return m.recorder
 }
 
-// AclAddRecord mocks base method.
-func (m *MockDRPCSpaceSyncClient) AclAddRecord(arg0 context.Context, arg1 *spacesyncproto.AclAddRecordRequest) (*spacesyncproto.AclAddRecordResponse, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AclAddRecord", arg0, arg1)
-	ret0, _ := ret[0].(*spacesyncproto.AclAddRecordResponse)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// AclAddRecord indicates an expected call of AclAddRecord.
-func (mr *MockDRPCSpaceSyncClientMockRecorder) AclAddRecord(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AclAddRecord", reflect.TypeOf((*MockDRPCSpaceSyncClient)(nil).AclAddRecord), arg0, arg1)
-}
-
-// AclGetRecords mocks base method.
-func (m *MockDRPCSpaceSyncClient) AclGetRecords(arg0 context.Context, arg1 *spacesyncproto.AclGetRecordsRequest) (*spacesyncproto.AclGetRecordsResponse, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AclGetRecords", arg0, arg1)
-	ret0, _ := ret[0].(*spacesyncproto.AclGetRecordsResponse)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// AclGetRecords indicates an expected call of AclGetRecords.
-func (mr *MockDRPCSpaceSyncClientMockRecorder) AclGetRecords(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AclGetRecords", reflect.TypeOf((*MockDRPCSpaceSyncClient)(nil).AclGetRecords), arg0, arg1)
-}
-
 // DRPCConn mocks base method.
 func (m *MockDRPCSpaceSyncClient) DRPCConn() drpc.Conn {
 	m.ctrl.T.Helper()

commonspace/spacesyncproto/protos/spacesync.proto

@@ -11,7 +11,6 @@ enum ErrCodes {
     SpaceIsDeleted = 4;
     PeerIsNotResponsible = 5;
     ReceiptIsInvalid = 6;
-    InvalidPayload = 7;
     ErrorOffset = 100;
 }
 
@@ -26,10 +25,6 @@ service SpaceSync {
     rpc ObjectSyncStream(stream ObjectSyncMessage) returns (stream ObjectSyncMessage);
     // ObjectSync sends object sync message and synchronously gets response message
     rpc ObjectSync(ObjectSyncMessage) returns (ObjectSyncMessage);
-    // AclAddRecord adds a new record to acl log. Works only with any-sync-node
-    rpc AclAddRecord(AclAddRecordRequest) returns (AclAddRecordResponse);
-    // AclGetRecords gets acl records
-    rpc AclGetRecords(AclGetRecordsRequest) returns (AclGetRecordsResponse);
 }
 
 // HeadSyncRange presenting a request for one range
@@ -162,27 +157,3 @@ message SpaceSubscription {
     repeated string spaceIds = 1;
     SpaceSubscriptionAction action = 2;
 }
-
-// AclAddRecordRequest contains marshaled consensusproto.RawRecord
-message AclAddRecordRequest {
-    string spaceId = 1;
-    bytes payload = 2;
-}
-
-// AclAddRecordResponse contains created record id and marshaled consensusproto.RawRecord
-message AclAddRecordResponse {
-    string recordId = 1;
-    bytes payload = 2;
-}
-
-// AclGetRecordsRequest can optionally contain the last known aclHeal, the server will return only new records or an empty list if there are no new records.
-// If aclHead is not provided the whole list will be returned.
-message AclGetRecordsRequest {
-    string spaceId = 1;
-    string aclHead = 2;
-}
-
-// AclGetRecordsResponse contains list of marshaled consensusproto.RawRecordWithId
-message AclGetRecordsResponse {
-    repeated bytes records = 1;
-}

commonspace/spacesyncproto/spacesync.go

@@ -2,7 +2,6 @@
 package spacesyncproto
 
 import (
-	"github.com/gogo/protobuf/proto"
 	"storj.io/drpc"
 )
 
@@ -17,16 +16,3 @@ func (c ClientFactoryFunc) Client(cc drpc.Conn) DRPCSpaceSyncClient {
 type ClientFactory interface {
 	Client(cc drpc.Conn) DRPCSpaceSyncClient
 }
-
-func MarshallSyncMessage(message proto.Marshaler, spaceId, objectId string) (objMsg *ObjectSyncMessage, err error) {
-	payload, err := message.Marshal()
-	if err != nil {
-		return
-	}
-	objMsg = &ObjectSyncMessage{
-		Payload:  payload,
-		ObjectId: objectId,
-		SpaceId:  spaceId,
-	}
-	return
-}

commonspace/spacesyncproto/spacesync_drpc.pb.go

@@ -45,8 +45,6 @@ type DRPCSpaceSyncClient interface {
 	SpacePull(ctx context.Context, in *SpacePullRequest) (*SpacePullResponse, error)
 	ObjectSyncStream(ctx context.Context) (DRPCSpaceSync_ObjectSyncStreamClient, error)
 	ObjectSync(ctx context.Context, in *ObjectSyncMessage) (*ObjectSyncMessage, error)
-	AclAddRecord(ctx context.Context, in *AclAddRecordRequest) (*AclAddRecordResponse, error)
-	AclGetRecords(ctx context.Context, in *AclGetRecordsRequest) (*AclGetRecordsResponse, error)
 }
 
 type drpcSpaceSyncClient struct {
@@ -134,32 +132,12 @@ func (c *drpcSpaceSyncClient) ObjectSync(ctx context.Context, in *ObjectSyncMess
 	return out, nil
 }
 
-func (c *drpcSpaceSyncClient) AclAddRecord(ctx context.Context, in *AclAddRecordRequest) (*AclAddRecordResponse, error) {
-	out := new(AclAddRecordResponse)
-	err := c.cc.Invoke(ctx, "/spacesync.SpaceSync/AclAddRecord", drpcEncoding_File_commonspace_spacesyncproto_protos_spacesync_proto{}, in, out)
-	if err != nil {
-		return nil, err
-	}
-	return out, nil
-}
-
-func (c *drpcSpaceSyncClient) AclGetRecords(ctx context.Context, in *AclGetRecordsRequest) (*AclGetRecordsResponse, error) {
-	out := new(AclGetRecordsResponse)
-	err := c.cc.Invoke(ctx, "/spacesync.SpaceSync/AclGetRecords", drpcEncoding_File_commonspace_spacesyncproto_protos_spacesync_proto{}, in, out)
-	if err != nil {
-		return nil, err
-	}
-	return out, nil
-}
-
 type DRPCSpaceSyncServer interface {
 	HeadSync(context.Context, *HeadSyncRequest) (*HeadSyncResponse, error)
 	SpacePush(context.Context, *SpacePushRequest) (*SpacePushResponse, error)
 	SpacePull(context.Context, *SpacePullRequest) (*SpacePullResponse, error)
 	ObjectSyncStream(DRPCSpaceSync_ObjectSyncStreamStream) error
 	ObjectSync(context.Context, *ObjectSyncMessage) (*ObjectSyncMessage, error)
-	AclAddRecord(context.Context, *AclAddRecordRequest) (*AclAddRecordResponse, error)
-	AclGetRecords(context.Context, *AclGetRecordsRequest) (*AclGetRecordsResponse, error)
 }
 
 type DRPCSpaceSyncUnimplementedServer struct{}
@@ -184,17 +162,9 @@ func (s *DRPCSpaceSyncUnimplementedServer) ObjectSync(context.Context, *ObjectSy
 	return nil, drpcerr.WithCode(errors.New("Unimplemented"), drpcerr.Unimplemented)
 }
 
-func (s *DRPCSpaceSyncUnimplementedServer) AclAddRecord(context.Context, *AclAddRecordRequest) (*AclAddRecordResponse, error) {
-	return nil, drpcerr.WithCode(errors.New("Unimplemented"), drpcerr.Unimplemented)
-}
-
-func (s *DRPCSpaceSyncUnimplementedServer) AclGetRecords(context.Context, *AclGetRecordsRequest) (*AclGetRecordsResponse, error) {
-	return nil, drpcerr.WithCode(errors.New("Unimplemented"), drpcerr.Unimplemented)
-}
-
 type DRPCSpaceSyncDescription struct{}
 
-func (DRPCSpaceSyncDescription) NumMethods() int { return 7 }
+func (DRPCSpaceSyncDescription) NumMethods() int { return 5 }
 
 func (DRPCSpaceSyncDescription) Method(n int) (string, drpc.Encoding, drpc.Receiver, interface{}, bool) {
 	switch n {
@@ -242,24 +212,6 @@ func (DRPCSpaceSyncDescription) Method(n int) (string, drpc.Encoding, drpc.Recei
 						in1.(*ObjectSyncMessage),
 					)
 			}, DRPCSpaceSyncServer.ObjectSync, true
-	case 5:
-		return "/spacesync.SpaceSync/AclAddRecord", drpcEncoding_File_commonspace_spacesyncproto_protos_spacesync_proto{},
-			func(srv interface{}, ctx context.Context, in1, in2 interface{}) (drpc.Message, error) {
-				return srv.(DRPCSpaceSyncServer).
-					AclAddRecord(
-						ctx,
-						in1.(*AclAddRecordRequest),
-					)
-			}, DRPCSpaceSyncServer.AclAddRecord, true
-	case 6:
-		return "/spacesync.SpaceSync/AclGetRecords", drpcEncoding_File_commonspace_spacesyncproto_protos_spacesync_proto{},
-			func(srv interface{}, ctx context.Context, in1, in2 interface{}) (drpc.Message, error) {
-				return srv.(DRPCSpaceSyncServer).
-					AclGetRecords(
-						ctx,
-						in1.(*AclGetRecordsRequest),
-					)
-			}, DRPCSpaceSyncServer.AclGetRecords, true
 	default:
 		return "", nil, nil, nil, false
 	}
@@ -358,35 +310,3 @@ func (x *drpcSpaceSync_ObjectSyncStream) SendAndClose(m *ObjectSyncMessage) erro
 	}
 	return x.CloseSend()
 }
-
-type DRPCSpaceSync_AclAddRecordStream interface {
-	drpc.Stream
-	SendAndClose(*AclAddRecordResponse) error
-}
-
-type drpcSpaceSync_AclAddRecordStream struct {
-	drpc.Stream
-}
-
-func (x *drpcSpaceSync_AclAddRecordStream) SendAndClose(m *AclAddRecordResponse) error {
-	if err := x.MsgSend(m, drpcEncoding_File_commonspace_spacesyncproto_protos_spacesync_proto{}); err != nil {
-		return err
-	}
-	return x.CloseSend()
-}
-
-type DRPCSpaceSync_AclGetRecordsStream interface {
-	drpc.Stream
-	SendAndClose(*AclGetRecordsResponse) error
-}
-
-type drpcSpaceSync_AclGetRecordsStream struct {
-	drpc.Stream
-}
-
-func (x *drpcSpaceSync_AclGetRecordsStream) SendAndClose(m *AclGetRecordsResponse) error {
-	if err := x.MsgSend(m, drpcEncoding_File_commonspace_spacesyncproto_protos_spacesync_proto{}); err != nil {
-		return err
-	}
-	return x.CloseSend()
-}

commonspace/spaceutils_test.go

@@ -151,10 +151,6 @@ func (p *mockPeerManager) GetResponsiblePeers(ctx context.Context) (peers []peer
 	return nil, nil
 }
 
-func (p *mockPeerManager) GetNodePeers(ctx context.Context) (peers []peer.Peer, err error) {
-	return nil, nil
-}
-
 //
 // Mock PeerManagerProvider
 //

commonspace/syncstatus/syncstatus.go

@@ -3,11 +3,10 @@ package syncstatus
 import (
 	"context"
 	"fmt"
-	"sync"
-	"time"
-
 	"github.com/anyproto/any-sync/app"
 	"github.com/anyproto/any-sync/commonspace/spacestate"
+	"sync"
+	"time"
 
 	"github.com/anyproto/any-sync/app/logger"
 	"github.com/anyproto/any-sync/commonspace/object/tree/treestorage"
@@ -179,9 +178,8 @@ func (s *syncStatusService) update(ctx context.Context) (err error) {
 		}
 		s.treeStatusBuf = append(s.treeStatusBuf, treeStatus{treeId, treeHeads.syncStatus, treeHeads.heads})
 	}
-	nodesOnline := s.nodesOnline
 	s.Unlock()
-	s.updateReceiver.UpdateNodeConnection(nodesOnline)
+	s.updateReceiver.UpdateNodeConnection(s.nodesOnline)
 	for _, entry := range s.treeStatusBuf {
 		err = s.updateReceiver.UpdateTree(ctx, entry.treeId, entry.status)
 		if err != nil {

consensus/consensusclient/client.go

@@ -1,243 +0,0 @@
-//go:generate mockgen -destination mock_consensusclient/mock_consensusclient.go github.com/anyproto/any-sync/consensus/consensusclient Service
-package consensusclient
-
-import (
-	"context"
-	"errors"
-	"github.com/anyproto/any-sync/app"
-	"github.com/anyproto/any-sync/app/logger"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/anyproto/any-sync/net/pool"
-	"github.com/anyproto/any-sync/net/rpc/rpcerr"
-	"github.com/anyproto/any-sync/nodeconf"
-	"go.uber.org/zap"
-	"sync"
-	"time"
-)
-
-const CName = "consensus.consensusclient"
-
-var log = logger.NewNamed(CName)
-
-var (
-	ErrWatcherExists    = errors.New("watcher exists")
-	ErrWatcherNotExists = errors.New("watcher not exists")
-)
-
-func New() Service {
-	return new(service)
-}
-
-// Watcher watches new events by specified logId
-type Watcher interface {
-	AddConsensusRecords(recs []*consensusproto.RawRecordWithId)
-	AddConsensusError(err error)
-}
-
-type Service interface {
-	// AddLog adds new log to consensus servers
-	AddLog(ctx context.Context, rec *consensusproto.RawRecordWithId) (err error)
-	// AddRecord adds new record to consensus servers
-	AddRecord(ctx context.Context, logId string, rec *consensusproto.RawRecord) (record *consensusproto.RawRecordWithId, err error)
-	// Watch starts watching to given logId and calls watcher when any relative event received
-	Watch(logId string, w Watcher) (err error)
-	// UnWatch stops watching given logId and removes watcher
-	UnWatch(logId string) (err error)
-	app.ComponentRunnable
-}
-
-type service struct {
-	pool     pool.Pool
-	nodeconf nodeconf.Service
-
-	watchers map[string]Watcher
-	stream   *stream
-	close    chan struct{}
-	mu       sync.Mutex
-}
-
-func (s *service) Init(a *app.App) (err error) {
-	s.pool = a.MustComponent(pool.CName).(pool.Pool)
-	s.nodeconf = a.MustComponent(nodeconf.CName).(nodeconf.Service)
-	s.watchers = make(map[string]Watcher)
-	s.close = make(chan struct{})
-	return nil
-}
-
-func (s *service) Name() (name string) {
-	return CName
-}
-
-func (s *service) Run(_ context.Context) error {
-	go s.streamWatcher()
-	return nil
-}
-
-func (s *service) doClient(ctx context.Context, fn func(cl consensusproto.DRPCConsensusClient) error) error {
-	peer, err := s.pool.GetOneOf(ctx, s.nodeconf.ConsensusPeers())
-	if err != nil {
-		return err
-	}
-	dc, err := peer.AcquireDrpcConn(ctx)
-	if err != nil {
-		return err
-	}
-	defer peer.ReleaseDrpcConn(dc)
-	return fn(consensusproto.NewDRPCConsensusClient(dc))
-}
-
-func (s *service) AddLog(ctx context.Context, rec *consensusproto.RawRecordWithId) (err error) {
-	return s.doClient(ctx, func(cl consensusproto.DRPCConsensusClient) error {
-		if _, err = cl.LogAdd(ctx, &consensusproto.LogAddRequest{
-			Record: rec,
-		}); err != nil {
-			return rpcerr.Unwrap(err)
-		}
-		return nil
-	})
-}
-
-func (s *service) AddRecord(ctx context.Context, logId string, rec *consensusproto.RawRecord) (record *consensusproto.RawRecordWithId, err error) {
-	err = s.doClient(ctx, func(cl consensusproto.DRPCConsensusClient) error {
-		if record, err = cl.RecordAdd(ctx, &consensusproto.RecordAddRequest{
-			LogId:  logId,
-			Record: rec,
-		}); err != nil {
-			return rpcerr.Unwrap(err)
-		}
-		return nil
-	})
-	return
-}
-
-func (s *service) Watch(logId string, w Watcher) (err error) {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	if _, ok := s.watchers[logId]; ok {
-		return ErrWatcherExists
-	}
-	s.watchers[logId] = w
-	if s.stream != nil {
-		if wErr := s.stream.WatchIds([]string{logId}); wErr != nil {
-			log.Warn("WatchIds error", zap.Error(wErr))
-		}
-	}
-	return
-}
-
-func (s *service) UnWatch(logId string) (err error) {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	if _, ok := s.watchers[logId]; !ok {
-		return ErrWatcherNotExists
-	}
-	delete(s.watchers, logId)
-	if s.stream != nil {
-		if wErr := s.stream.UnwatchIds([]string{logId}); wErr != nil {
-			log.Warn("UnWatchIds error", zap.Error(wErr))
-		}
-	}
-	return
-}
-
-func (s *service) openStream(ctx context.Context) (st *stream, err error) {
-	pr, err := s.pool.GetOneOf(ctx, s.nodeconf.ConsensusPeers())
-	if err != nil {
-		return nil, err
-	}
-	dc, err := pr.AcquireDrpcConn(ctx)
-	if err != nil {
-		return nil, err
-	}
-	rpcStream, err := consensusproto.NewDRPCConsensusClient(dc).LogWatch(ctx)
-	if err != nil {
-		return nil, rpcerr.Unwrap(err)
-	}
-	return runStream(rpcStream), nil
-}
-
-func (s *service) streamWatcher() {
-	var (
-		err error
-		st  *stream
-		i   int
-	)
-	for {
-		// open stream
-		if st, err = s.openStream(context.Background()); err != nil {
-			// can't open stream, we will retry until success connection or close
-			if i < 60 {
-				i++
-			}
-			sleepTime := time.Second * time.Duration(i)
-			log.Error("watch log error", zap.Error(err), zap.Duration("waitTime", sleepTime))
-			select {
-			case <-time.After(sleepTime):
-				continue
-			case <-s.close:
-				return
-			}
-		}
-		i = 0
-
-		// collect ids and setup stream
-		s.mu.Lock()
-		var logIds = make([]string, 0, len(s.watchers))
-		for id := range s.watchers {
-			logIds = append(logIds, id)
-		}
-		s.stream = st
-		s.mu.Unlock()
-
-		// restore subscriptions
-		if len(logIds) > 0 {
-			if err = s.stream.WatchIds(logIds); err != nil {
-				log.Error("watch ids error", zap.Error(err))
-				continue
-			}
-		}
-
-		// read stream
-		if err = s.streamReader(); err != nil {
-			log.Error("stream read error", zap.Error(err))
-			continue
-		}
-		return
-	}
-}
-
-func (s *service) streamReader() error {
-	for {
-		events := s.stream.WaitLogs()
-		if len(events) == 0 {
-			return s.stream.Err()
-		}
-		s.mu.Lock()
-		for _, e := range events {
-			if w, ok := s.watchers[e.LogId]; ok {
-				if e.Error == nil {
-					w.AddConsensusRecords(e.Records)
-				} else {
-					w.AddConsensusError(rpcerr.Err(uint64(e.Error.Error)))
-				}
-			} else {
-				log.Warn("received unexpected log id", zap.String("logId", e.LogId))
-			}
-		}
-		s.mu.Unlock()
-	}
-}
-
-func (s *service) Close(_ context.Context) error {
-	s.mu.Lock()
-	if s.stream != nil {
-		_ = s.stream.Close()
-	}
-	s.mu.Unlock()
-	select {
-	case <-s.close:
-	default:
-		close(s.close)
-	}
-	return nil
-}

consensus/consensusclient/client_test.go

@@ -1,241 +0,0 @@
-package consensusclient
-
-import (
-	"context"
-	"fmt"
-	"github.com/anyproto/any-sync/app"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/anyproto/any-sync/consensus/consensusproto/consensuserr"
-	"github.com/anyproto/any-sync/net/pool"
-	"github.com/anyproto/any-sync/net/rpc/rpctest"
-	"github.com/anyproto/any-sync/nodeconf"
-	"github.com/anyproto/any-sync/nodeconf/mock_nodeconf"
-	"github.com/anyproto/any-sync/testutil/accounttest"
-	"github.com/anyproto/any-sync/util/cidutil"
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-	"go.uber.org/mock/gomock"
-	"sync"
-	"testing"
-	"time"
-)
-
-func TestService_Watch(t *testing.T) {
-	t.Run("not found error", func(t *testing.T) {
-		fx := newFixture(t).run(t)
-		defer fx.Finish()
-		var logId = "1"
-		w := &testWatcher{ready: make(chan struct{})}
-		require.NoError(t, fx.Watch(logId, w))
-		st := fx.testServer.waitStream(t)
-		req, err := st.Recv()
-		require.NoError(t, err)
-		assert.Equal(t, []string{logId}, req.WatchIds)
-		require.NoError(t, st.Send(&consensusproto.LogWatchEvent{
-			LogId: logId,
-			Error: &consensusproto.Err{
-				Error: consensusproto.ErrCodes_ErrorOffset + consensusproto.ErrCodes_LogNotFound,
-			},
-		}))
-		<-w.ready
-		assert.Equal(t, consensuserr.ErrLogNotFound, w.err)
-		fx.testServer.releaseStream <- nil
-	})
-	t.Run("watcherExists error", func(t *testing.T) {
-		fx := newFixture(t).run(t)
-		defer fx.Finish()
-		var logId = "1"
-		w := &testWatcher{}
-		require.NoError(t, fx.Watch(logId, w))
-		require.Error(t, fx.Watch(logId, w))
-		st := fx.testServer.waitStream(t)
-		st.Recv()
-		fx.testServer.releaseStream <- nil
-	})
-	t.Run("watch", func(t *testing.T) {
-		fx := newFixture(t).run(t)
-		defer fx.Finish()
-		var logId1 = "1"
-		w := &testWatcher{}
-		require.NoError(t, fx.Watch(logId1, w))
-		st := fx.testServer.waitStream(t)
-		req, err := st.Recv()
-		require.NoError(t, err)
-		assert.Equal(t, []string{logId1}, req.WatchIds)
-
-		var logId2 = "2"
-		w = &testWatcher{}
-		require.NoError(t, fx.Watch(logId2, w))
-		req, err = st.Recv()
-		require.NoError(t, err)
-		assert.Equal(t, []string{logId2}, req.WatchIds)
-
-		fx.testServer.releaseStream <- nil
-	})
-}
-
-func TestService_UnWatch(t *testing.T) {
-	t.Run("no watcher", func(t *testing.T) {
-		fx := newFixture(t).run(t)
-		defer fx.Finish()
-		require.Error(t, fx.UnWatch("1"))
-	})
-	t.Run("success", func(t *testing.T) {
-		fx := newFixture(t).run(t)
-		defer fx.Finish()
-		w := &testWatcher{}
-		require.NoError(t, fx.Watch("1", w))
-		assert.NoError(t, fx.UnWatch("1"))
-	})
-}
-
-func TestService_Init(t *testing.T) {
-	t.Run("reconnect on watch err", func(t *testing.T) {
-		fx := newFixture(t)
-		fx.testServer.watchErrOnce = true
-		fx.run(t)
-		defer fx.Finish()
-		fx.testServer.waitStream(t)
-		fx.testServer.releaseStream <- nil
-	})
-	t.Run("reconnect on start", func(t *testing.T) {
-		fx := newFixture(t)
-		fx.a.MustComponent(pool.CName).(*rpctest.TestPool).WithServer(nil)
-		fx.run(t)
-		defer fx.Finish()
-		time.Sleep(time.Millisecond * 50)
-		fx.a.MustComponent(pool.CName).(*rpctest.TestPool).WithServer(fx.drpcTS)
-		fx.testServer.waitStream(t)
-		fx.testServer.releaseStream <- nil
-	})
-}
-
-func TestService_AddLog(t *testing.T) {
-	fx := newFixture(t).run(t)
-	defer fx.Finish()
-	assert.NoError(t, fx.AddLog(ctx, &consensusproto.RawRecordWithId{}))
-}
-
-func TestService_AddRecord(t *testing.T) {
-	fx := newFixture(t).run(t)
-	defer fx.Finish()
-	rec, err := fx.AddRecord(ctx, "1", &consensusproto.RawRecord{})
-	require.NoError(t, err)
-	assert.NotEmpty(t, rec)
-}
-
-var ctx = context.Background()
-
-func newFixture(t *testing.T) *fixture {
-	fx := &fixture{
-		Service: New(),
-		a:       &app.App{},
-		ctrl:    gomock.NewController(t),
-		testServer: &testServer{
-			stream:        make(chan consensusproto.DRPCConsensus_LogWatchStream),
-			releaseStream: make(chan error),
-		},
-	}
-	fx.nodeconf = mock_nodeconf.NewMockService(fx.ctrl)
-	fx.nodeconf.EXPECT().Name().Return(nodeconf.CName).AnyTimes()
-	fx.nodeconf.EXPECT().Init(gomock.Any()).AnyTimes()
-	fx.nodeconf.EXPECT().Run(gomock.Any()).AnyTimes()
-	fx.nodeconf.EXPECT().Close(gomock.Any()).AnyTimes()
-	fx.nodeconf.EXPECT().ConsensusPeers().Return([]string{"c1", "c2", "c3"}).AnyTimes()
-
-	fx.drpcTS = rpctest.NewTestServer()
-	require.NoError(t, consensusproto.DRPCRegisterConsensus(fx.drpcTS.Mux, fx.testServer))
-	fx.a.Register(fx.Service).
-		Register(&accounttest.AccountTestService{}).
-		Register(fx.nodeconf).
-		Register(rpctest.NewTestPool().WithServer(fx.drpcTS))
-
-	return fx
-}
-
-type fixture struct {
-	Service
-	a          *app.App
-	ctrl       *gomock.Controller
-	testServer *testServer
-	drpcTS     *rpctest.TestServer
-	nodeconf   *mock_nodeconf.MockService
-}
-
-func (fx *fixture) run(t *testing.T) *fixture {
-	require.NoError(t, fx.a.Start(ctx))
-	return fx
-}
-
-func (fx *fixture) Finish() {
-	assert.NoError(fx.ctrl.T, fx.a.Close(ctx))
-	fx.ctrl.Finish()
-}
-
-type testServer struct {
-	stream        chan consensusproto.DRPCConsensus_LogWatchStream
-	addLog        func(ctx context.Context, req *consensusproto.LogAddRequest) error
-	addRecord     func(ctx context.Context, req *consensusproto.RecordAddRequest) error
-	releaseStream chan error
-	watchErrOnce  bool
-}
-
-func (t *testServer) LogAdd(ctx context.Context, req *consensusproto.LogAddRequest) (*consensusproto.Ok, error) {
-	if t.addLog != nil {
-		if err := t.addLog(ctx, req); err != nil {
-			return nil, err
-		}
-	}
-	return &consensusproto.Ok{}, nil
-}
-
-func (t *testServer) RecordAdd(ctx context.Context, req *consensusproto.RecordAddRequest) (*consensusproto.RawRecordWithId, error) {
-	if t.addRecord != nil {
-		if err := t.addRecord(ctx, req); err != nil {
-			return nil, err
-		}
-	}
-	data, _ := req.Record.Marshal()
-	id, _ := cidutil.NewCidFromBytes(data)
-	return &consensusproto.RawRecordWithId{Id: id, Payload: data}, nil
-}
-
-func (t *testServer) LogWatch(stream consensusproto.DRPCConsensus_LogWatchStream) error {
-	if t.watchErrOnce {
-		t.watchErrOnce = false
-		return fmt.Errorf("error")
-	}
-	t.stream <- stream
-	return <-t.releaseStream
-}
-
-func (t *testServer) waitStream(test *testing.T) consensusproto.DRPCConsensus_LogWatchStream {
-	select {
-	case <-time.After(time.Second * 5):
-		test.Fatalf("waiteStream timeout")
-	case st := <-t.stream:
-		return st
-	}
-	return nil
-}
-
-type testWatcher struct {
-	recs  [][]*consensusproto.RawRecordWithId
-	err   error
-	ready chan struct{}
-	once  sync.Once
-}
-
-func (t *testWatcher) AddConsensusRecords(recs []*consensusproto.RawRecordWithId) {
-	t.recs = append(t.recs, recs)
-	t.once.Do(func() {
-		close(t.ready)
-	})
-}
-
-func (t *testWatcher) AddConsensusError(err error) {
-	t.err = err
-	t.once.Do(func() {
-		close(t.ready)
-	})
-}

consensus/consensusclient/mock_consensusclient/mock_consensusclient.go

@@ -1,151 +0,0 @@
-// Code generated by MockGen. DO NOT EDIT.
-// Source: github.com/anyproto/any-sync/consensus/consensusclient (interfaces: Service)
-
-// Package mock_consensusclient is a generated GoMock package.
-package mock_consensusclient
-
-import (
-	context "context"
-	reflect "reflect"
-
-	app "github.com/anyproto/any-sync/app"
-	consensusclient "github.com/anyproto/any-sync/consensus/consensusclient"
-	consensusproto "github.com/anyproto/any-sync/consensus/consensusproto"
-	gomock "go.uber.org/mock/gomock"
-)
-
-// MockService is a mock of Service interface.
-type MockService struct {
-	ctrl     *gomock.Controller
-	recorder *MockServiceMockRecorder
-}
-
-// MockServiceMockRecorder is the mock recorder for MockService.
-type MockServiceMockRecorder struct {
-	mock *MockService
-}
-
-// NewMockService creates a new mock instance.
-func NewMockService(ctrl *gomock.Controller) *MockService {
-	mock := &MockService{ctrl: ctrl}
-	mock.recorder = &MockServiceMockRecorder{mock}
-	return mock
-}
-
-// EXPECT returns an object that allows the caller to indicate expected use.
-func (m *MockService) EXPECT() *MockServiceMockRecorder {
-	return m.recorder
-}
-
-// AddLog mocks base method.
-func (m *MockService) AddLog(arg0 context.Context, arg1 *consensusproto.RawRecordWithId) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AddLog", arg0, arg1)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// AddLog indicates an expected call of AddLog.
-func (mr *MockServiceMockRecorder) AddLog(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddLog", reflect.TypeOf((*MockService)(nil).AddLog), arg0, arg1)
-}
-
-// AddRecord mocks base method.
-func (m *MockService) AddRecord(arg0 context.Context, arg1 string, arg2 *consensusproto.RawRecord) (*consensusproto.RawRecordWithId, error) {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "AddRecord", arg0, arg1, arg2)
-	ret0, _ := ret[0].(*consensusproto.RawRecordWithId)
-	ret1, _ := ret[1].(error)
-	return ret0, ret1
-}
-
-// AddRecord indicates an expected call of AddRecord.
-func (mr *MockServiceMockRecorder) AddRecord(arg0, arg1, arg2 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "AddRecord", reflect.TypeOf((*MockService)(nil).AddRecord), arg0, arg1, arg2)
-}
-
-// Close mocks base method.
-func (m *MockService) Close(arg0 context.Context) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Close", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Close indicates an expected call of Close.
-func (mr *MockServiceMockRecorder) Close(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Close", reflect.TypeOf((*MockService)(nil).Close), arg0)
-}
-
-// Init mocks base method.
-func (m *MockService) Init(arg0 *app.App) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Init", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Init indicates an expected call of Init.
-func (mr *MockServiceMockRecorder) Init(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Init", reflect.TypeOf((*MockService)(nil).Init), arg0)
-}
-
-// Name mocks base method.
-func (m *MockService) Name() string {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Name")
-	ret0, _ := ret[0].(string)
-	return ret0
-}
-
-// Name indicates an expected call of Name.
-func (mr *MockServiceMockRecorder) Name() *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Name", reflect.TypeOf((*MockService)(nil).Name))
-}
-
-// Run mocks base method.
-func (m *MockService) Run(arg0 context.Context) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Run", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Run indicates an expected call of Run.
-func (mr *MockServiceMockRecorder) Run(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Run", reflect.TypeOf((*MockService)(nil).Run), arg0)
-}
-
-// UnWatch mocks base method.
-func (m *MockService) UnWatch(arg0 string) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "UnWatch", arg0)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// UnWatch indicates an expected call of UnWatch.
-func (mr *MockServiceMockRecorder) UnWatch(arg0 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "UnWatch", reflect.TypeOf((*MockService)(nil).UnWatch), arg0)
-}
-
-// Watch mocks base method.
-func (m *MockService) Watch(arg0 string, arg1 consensusclient.Watcher) error {
-	m.ctrl.T.Helper()
-	ret := m.ctrl.Call(m, "Watch", arg0, arg1)
-	ret0, _ := ret[0].(error)
-	return ret0
-}
-
-// Watch indicates an expected call of Watch.
-func (mr *MockServiceMockRecorder) Watch(arg0, arg1 interface{}) *gomock.Call {
-	mr.mock.ctrl.T.Helper()
-	return mr.mock.ctrl.RecordCallWithMethodType(mr.mock, "Watch", reflect.TypeOf((*MockService)(nil).Watch), arg0, arg1)
-}

consensus/consensusclient/stream.go

@@ -1,70 +0,0 @@
-package consensusclient
-
-import (
-	"context"
-	"github.com/anyproto/any-sync/consensus/consensusproto"
-	"github.com/cheggaaa/mb/v3"
-	"sync"
-)
-
-func runStream(rpcStream consensusproto.DRPCConsensus_LogWatchClient) *stream {
-	st := &stream{
-		rpcStream: rpcStream,
-		mb:        mb.New[*consensusproto.LogWatchEvent](100),
-	}
-	go st.readStream()
-	return st
-}
-
-type stream struct {
-	rpcStream consensusproto.DRPCConsensus_LogWatchClient
-	mb        *mb.MB[*consensusproto.LogWatchEvent]
-	mu        sync.Mutex
-	err       error
-}
-
-func (s *stream) WatchIds(logIds []string) (err error) {
-	return s.rpcStream.Send(&consensusproto.LogWatchRequest{
-		WatchIds: logIds,
-	})
-}
-
-func (s *stream) UnwatchIds(logIds []string) (err error) {
-	return s.rpcStream.Send(&consensusproto.LogWatchRequest{
-		UnwatchIds: logIds,
-	})
-}
-
-func (s *stream) WaitLogs() []*consensusproto.LogWatchEvent {
-	events, _ := s.mb.Wait(context.TODO())
-	return events
-}
-
-func (s *stream) Err() error {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-	return s.err
-}
-
-func (s *stream) readStream() {
-	defer s.Close()
-	for {
-		event, err := s.rpcStream.Recv()
-		if err != nil {
-			s.mu.Lock()
-			s.err = err
-			s.mu.Unlock()
-			return
-		}
-		if err = s.mb.Add(s.rpcStream.Context(), event); err != nil {
-			return
-		}
-	}
-}
-
-func (s *stream) Close() error {
-	if err := s.mb.Close(); err == nil {
-		return s.rpcStream.Close()
-	}
-	return nil
-}

consensus/consensusproto/consensus.go

@@ -1,45 +0,0 @@
-package consensusproto
-
-func WrapHeadUpdate(update *LogHeadUpdate, rootRecord *RawRecordWithId) *LogSyncMessage {
-	return &LogSyncMessage{
-		Content: &LogSyncContentValue{
-			Value: &LogSyncContentValue_HeadUpdate{HeadUpdate: update},
-		},
-		Id:      rootRecord.Id,
-		Payload: rootRecord.Payload,
-	}
-}
-
-func WrapFullRequest(request *LogFullSyncRequest, rootRecord *RawRecordWithId) *LogSyncMessage {
-	return &LogSyncMessage{
-		Content: &LogSyncContentValue{
-			Value: &LogSyncContentValue_FullSyncRequest{FullSyncRequest: request},
-		},
-		Id:      rootRecord.Id,
-		Payload: rootRecord.Payload,
-	}
-}
-
-func WrapFullResponse(response *LogFullSyncResponse, rootRecord *RawRecordWithId) *LogSyncMessage {
-	return &LogSyncMessage{
-		Content: &LogSyncContentValue{
-			Value: &LogSyncContentValue_FullSyncResponse{FullSyncResponse: response},
-		},
-		Id:      rootRecord.Id,
-		Payload: rootRecord.Payload,
-	}
-}
-
-func GetHead(msg *LogSyncMessage) (head string) {
-	content := msg.GetContent()
-	switch {
-	case content.GetHeadUpdate() != nil:
-		return content.GetHeadUpdate().Head
-	case content.GetFullSyncRequest() != nil:
-		return content.GetFullSyncRequest().Head
-	case content.GetFullSyncResponse() != nil:
-		return content.GetFullSyncResponse().Head
-	default:
-		return ""
-	}
-}

consensus/consensusproto/consensus_drpc.pb.go

@@ -1,232 +0,0 @@
-// Code generated by protoc-gen-go-drpc. DO NOT EDIT.
-// protoc-gen-go-drpc version: v0.0.33
-// source: consensus/consensusproto/protos/consensus.proto
-
-package consensusproto
-
-import (
-	bytes "bytes"
-	context "context"
-	errors "errors"
-	jsonpb "github.com/gogo/protobuf/jsonpb"
-	proto "github.com/gogo/protobuf/proto"
-	drpc "storj.io/drpc"
-	drpcerr "storj.io/drpc/drpcerr"
-)
-
-type drpcEncoding_File_consensus_consensusproto_protos_consensus_proto struct{}
-
-func (drpcEncoding_File_consensus_consensusproto_protos_consensus_proto) Marshal(msg drpc.Message) ([]byte, error) {
-	return proto.Marshal(msg.(proto.Message))
-}
-
-func (drpcEncoding_File_consensus_consensusproto_protos_consensus_proto) Unmarshal(buf []byte, msg drpc.Message) error {
-	return proto.Unmarshal(buf, msg.(proto.Message))
-}
-
-func (drpcEncoding_File_consensus_consensusproto_protos_consensus_proto) JSONMarshal(msg drpc.Message) ([]byte, error) {
-	var buf bytes.Buffer
-	err := new(jsonpb.Marshaler).Marshal(&buf, msg.(proto.Message))
-	if err != nil {
-		return nil, err
-	}
-	return buf.Bytes(), nil
-}
-
-func (drpcEncoding_File_consensus_consensusproto_protos_consensus_proto) JSONUnmarshal(buf []byte, msg drpc.Message) error {
-	return jsonpb.Unmarshal(bytes.NewReader(buf), msg.(proto.Message))
-}
-
-type DRPCConsensusClient interface {
-	DRPCConn() drpc.Conn
-
-	LogAdd(ctx context.Context, in *LogAddRequest) (*Ok, error)
-	RecordAdd(ctx context.Context, in *RecordAddRequest) (*RawRecordWithId, error)
-	LogWatch(ctx context.Context) (DRPCConsensus_LogWatchClient, error)
-}
-
-type drpcConsensusClient struct {
-	cc drpc.Conn
-}
-
-func NewDRPCConsensusClient(cc drpc.Conn) DRPCConsensusClient {
-	return &drpcConsensusClient{cc}
-}
-
-func (c *drpcConsensusClient) DRPCConn() drpc.Conn { return c.cc }
-
-func (c *drpcConsensusClient) LogAdd(ctx context.Context, in *LogAddRequest) (*Ok, error) {
-	out := new(Ok)
-	err := c.cc.Invoke(ctx, "/consensusProto.Consensus/LogAdd", drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{}, in, out)
-	if err != nil {
-		return nil, err
-	}
-	return out, nil
-}
-
-func (c *drpcConsensusClient) RecordAdd(ctx context.Context, in *RecordAddRequest) (*RawRecordWithId, error) {
-	out := new(RawRecordWithId)
-	err := c.cc.Invoke(ctx, "/consensusProto.Consensus/RecordAdd", drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{}, in, out)
-	if err != nil {
-		return nil, err
-	}
-	return out, nil
-}
-
-func (c *drpcConsensusClient) LogWatch(ctx context.Context) (DRPCConsensus_LogWatchClient, error) {
-	stream, err := c.cc.NewStream(ctx, "/consensusProto.Consensus/LogWatch", drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{})
-	if err != nil {
-		return nil, err
-	}
-	x := &drpcConsensus_LogWatchClient{stream}
-	return x, nil
-}
-
-type DRPCConsensus_LogWatchClient interface {
-	drpc.Stream
-	Send(*LogWatchRequest) error
-	Recv() (*LogWatchEvent, error)
-}
-
-type drpcConsensus_LogWatchClient struct {
-	drpc.Stream
-}
-
-func (x *drpcConsensus_LogWatchClient) GetStream() drpc.Stream {
-	return x.Stream
-}
-
-func (x *drpcConsensus_LogWatchClient) Send(m *LogWatchRequest) error {
-	return x.MsgSend(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{})
-}
-
-func (x *drpcConsensus_LogWatchClient) Recv() (*LogWatchEvent, error) {
-	m := new(LogWatchEvent)
-	if err := x.MsgRecv(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{}); err != nil {
-		return nil, err
-	}
-	return m, nil
-}
-
-func (x *drpcConsensus_LogWatchClient) RecvMsg(m *LogWatchEvent) error {
-	return x.MsgRecv(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{})
-}
-
-type DRPCConsensusServer interface {
-	LogAdd(context.Context, *LogAddRequest) (*Ok, error)
-	RecordAdd(context.Context, *RecordAddRequest) (*RawRecordWithId, error)
-	LogWatch(DRPCConsensus_LogWatchStream) error
-}
-
-type DRPCConsensusUnimplementedServer struct{}
-
-func (s *DRPCConsensusUnimplementedServer) LogAdd(context.Context, *LogAddRequest) (*Ok, error) {
-	return nil, drpcerr.WithCode(errors.New("Unimplemented"), drpcerr.Unimplemented)
-}
-
-func (s *DRPCConsensusUnimplementedServer) RecordAdd(context.Context, *RecordAddRequest) (*RawRecordWithId, error) {
-	return nil, drpcerr.WithCode(errors.New("Unimplemented"), drpcerr.Unimplemented)
-}
-
-func (s *DRPCConsensusUnimplementedServer) LogWatch(DRPCConsensus_LogWatchStream) error {
-	return drpcerr.WithCode(errors.New("Unimplemented"), drpcerr.Unimplemented)
-}
-
-type DRPCConsensusDescription struct{}
-
-func (DRPCConsensusDescription) NumMethods() int { return 3 }
-
-func (DRPCConsensusDescription) Method(n int) (string, drpc.Encoding, drpc.Receiver, interface{}, bool) {
-	switch n {
-	case 0:
-		return "/consensusProto.Consensus/LogAdd", drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{},
-			func(srv interface{}, ctx context.Context, in1, in2 interface{}) (drpc.Message, error) {
-				return srv.(DRPCConsensusServer).
-					LogAdd(
-						ctx,
-						in1.(*LogAddRequest),
-					)
-			}, DRPCConsensusServer.LogAdd, true
-	case 1:
-		return "/consensusProto.Consensus/RecordAdd", drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{},
-			func(srv interface{}, ctx context.Context, in1, in2 interface{}) (drpc.Message, error) {
-				return srv.(DRPCConsensusServer).
-					RecordAdd(
-						ctx,
-						in1.(*RecordAddRequest),
-					)
-			}, DRPCConsensusServer.RecordAdd, true
-	case 2:
-		return "/consensusProto.Consensus/LogWatch", drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{},
-			func(srv interface{}, ctx context.Context, in1, in2 interface{}) (drpc.Message, error) {
-				return nil, srv.(DRPCConsensusServer).
-					LogWatch(
-						&drpcConsensus_LogWatchStream{in1.(drpc.Stream)},
-					)
-			}, DRPCConsensusServer.LogWatch, true
-	default:
-		return "", nil, nil, nil, false
-	}
-}
-
-func DRPCRegisterConsensus(mux drpc.Mux, impl DRPCConsensusServer) error {
-	return mux.Register(impl, DRPCConsensusDescription{})
-}
-
-type DRPCConsensus_LogAddStream interface {
-	drpc.Stream
-	SendAndClose(*Ok) error
-}
-
-type drpcConsensus_LogAddStream struct {
-	drpc.Stream
-}
-
-func (x *drpcConsensus_LogAddStream) SendAndClose(m *Ok) error {
-	if err := x.MsgSend(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{}); err != nil {
-		return err
-	}
-	return x.CloseSend()
-}
-
-type DRPCConsensus_RecordAddStream interface {
-	drpc.Stream
-	SendAndClose(*RawRecordWithId) error
-}
-
-type drpcConsensus_RecordAddStream struct {
-	drpc.Stream
-}
-
-func (x *drpcConsensus_RecordAddStream) SendAndClose(m *RawRecordWithId) error {
-	if err := x.MsgSend(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{}); err != nil {
-		return err
-	}
-	return x.CloseSend()
-}
-
-type DRPCConsensus_LogWatchStream interface {
-	drpc.Stream
-	Send(*LogWatchEvent) error
-	Recv() (*LogWatchRequest, error)
-}
-
-type drpcConsensus_LogWatchStream struct {
-	drpc.Stream
-}
-
-func (x *drpcConsensus_LogWatchStream) Send(m *LogWatchEvent) error {
-	return x.MsgSend(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{})
-}
-
-func (x *drpcConsensus_LogWatchStream) Recv() (*LogWatchRequest, error) {
-	m := new(LogWatchRequest)
-	if err := x.MsgRecv(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{}); err != nil {
-		return nil, err
-	}
-	return m, nil
-}
-
-func (x *drpcConsensus_LogWatchStream) RecvMsg(m *LogWatchRequest) error {
-	return x.MsgRecv(m, drpcEncoding_File_consensus_consensusproto_protos_consensus_proto{})
-}